Fix debugger's "reloaded" event when doing a bfcache navigation
Categories
(DevTools :: Debugger, defect, P3)
Tracking
(Fission Milestone:M7a, firefox90 fixed)
| Tracking | Status | |
|---|---|---|
| firefox90 | --- | fixed |
People
(Reporter: ochameau, Assigned: bomsy)
References
(Blocks 3 open bugs)
Details
(Whiteboard: dt-fission-m3-mvp)
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Followup from: https://phabricator.services.mozilla.com/D106298#3596491
I think this one failure is specific to bfcache as we target switch to an already loaded document and so navigate won't fire.
For top level target switching, unless the document loads super fast, it should not happen. But theoriticaly it may also happen.
The reloaded event is sent from here:
https://searchfox.org/mozilla-central/rev/54f37fc1ac0f98b590af51e01ce82bb74179bf63/devtools/client/debugger/src/actions/navigation.js#57
And is bound to "navigate" from here:
https://searchfox.org/mozilla-central/rev/54f37fc1ac0f98b590af51e01ce82bb74179bf63/devtools/client/debugger/src/client/firefox.js#110
We could probably fix that by using DOCUMENT_EVENT's dom-complete.
Note that once we have one target per WindowGlobal (when target.followWindowGlobalLifecycle=true), it would be easier to have a "loaded" or "navigated" or "domComplete" promise on target, which would resolve once the document is done loading. But for now, as each target may load many documents, we will have to rely on many possible events.
|
||
Updated•3 years ago
|
|
Assignee | |
Updated•3 years ago
|
|
|
||
Updated•3 years ago
|
|
Reporter | |
Comment 1•3 years ago
|
||
Note that browser_toolbox_window_title_changes.js was failing because of the missing reloaded event.
|
|
Assignee | |
Updated•3 years ago
|
|
|
||
Updated•3 years ago
|
Pushed by hmanilla@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e95dfc09290c [devtools] Emit debugger's reloaded event from DOCUMENT_EVENT's dom-complete instead of target's navigate. r=nchevobbe
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Description
•