Closed Bug 1702731 Opened 4 years ago Closed 4 years ago

Rename the "Preferences/Options" to "Preferences" and the "Add-ons" to "Add-ons and Themes"

Categories

(Thunderbird :: General, task)

Product:
Thunderbird
Component:
General
Type:
task

Tracking

(thunderbird_esr78 unaffected, thunderbird88 unaffected, thunderbird89 affected)

Status:
RESOLVED FIXED
Milestone:
89 Branch
Tracking Flags:
Tracking Status
thunderbird_esr78 --- unaffected
thunderbird88 --- unaffected
thunderbird89 --- affected

People

(Reporter: Paenglab, Assigned: aleca)

References

Details

Attachments

(2 files, 5 obsolete files)

1702731-prefs-and-addons-rename.patch
(deleted), patch
Paenglab
: review+
Details | Diff | Splinter Review
1702731-bustage-fix.diff
(deleted), patch
Details | Diff | Splinter Review

FX did this too and Alessandro thought this would be a good thing.

Attached patch 1702731-prefs-and-addons-rename.patch (obsolete) (deleted) — — Splinter Review

I made now a special AppMenu group because they've got the accesskey underlined and all other items have none.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9213287 - Flags: review?(alessandro)

gah. this is going to affect docs and support.
I hope this is the end to their renames.

The pro is, it's always Settings and not different on platforms. Only the position in the menus is still different. In AppMenu it's now only one version.

Comment on attachment 9213287 [details] [diff] [review] 1702731-prefs-and-addons-rename.patch Review of attachment 9213287 [details] [diff] [review]: ----------------------------------------------------------------- Good changes, with some nits to fix. ::: mail/locales/en-US/chrome/communicator/utilityOverlay.dtd @@ +20,4 @@ > <!ENTITY customizeCmd.label "Customize"> > <!ENTITY customizeCmd.accesskey "t"> > > +<!ENTITY openSettingsButton.label "&brandShortName; Settings"> I think we should avoid adding new strings to dtd or properties files and use the occasion to update or create a fluent file. ::: mail/locales/en-US/messenger/menubar.ftl @@ +10,5 @@ > > +## Tools Menu > + > +# Settings is now used to access the Thunderbird settings across all platforms, > +# instead of Options or Preferences. If we want to write this comment here I think we should reference the version as writing "now" doesn't help much. What about something like: "Since v89 we dropped the platforms distinction between Options or Preferences and consolidated everything with Settings." Or something like that. ::: mail/locales/en-US/messenger/messenger.ftl @@ +55,5 @@ > + > +## AppMenu > + > +# Settings is now used to access the Thunderbird settings across all platforms, > +# instead of Options or Preferences. Same comment here. ::: mailnews/base/prefs/content/AccountManager.xhtml @@ +89,5 @@ > <label is="text-link" id="prefsButton" class="sidebar-footer-link" > onclick="openOptionsDialog();"> > <image class="sidebar-footer-icon preferences-icon"/> > <label class="sidebar-footer-label" > + value="&openSettingsButton.label;" Does the account manager come with an existing FTL file? If not we should create one and start with this string.
Attachment #9213287 - Flags: review?(alessandro) → feedback+
Attached patch 1702731-prefs-and-addons-rename.patch (obsolete) (deleted) — — Splinter Review

Updated the localization comment and added the accountManager.ftl.

Attachment #9213287 - Attachment is obsolete: true
Attachment #9213420 - Flags: review?(alessandro)
Comment on attachment 9213420 [details] [diff] [review] 1702731-prefs-and-addons-rename.patch Review of attachment 9213420 [details] [diff] [review]: ----------------------------------------------------------------- With these changes now we have these 2 menu items one after another: - Account Settings - Settings It looks a bit weird, what do you think? Firefox doesn't have this problem. I wonder if it might be confusing for the user and using `Preferences` for the general TB preferences might be more appropriate. It's also easier to distinguish and we avoid the possible confusion when offering support, like "Access the settings, no, not the Account Settings, just settings..." Should we stick with `Preferences`? The string in the search field needs to be updated too: https://searchfox.org/comm-central/rev/65e9c6671d8840c0201454bf8cfdc15e23501a83/mail/locales/en-US/messenger/preferences/preferences.ftl#875
Attachment #9213420 - Flags: review?(alessandro) → feedback+
Attached patch 1702731-prefs-and-addons-rename.patch (obsolete) (deleted) — — Splinter Review

Now using Preferences for all platforms.

Attachment #9213420 - Attachment is obsolete: true
Attachment #9213618 - Flags: review?(alessandro)
Comment on attachment 9213618 [details] [diff] [review] 1702731-prefs-and-addons-rename.patch Review of attachment 9213618 [details] [diff] [review]: ----------------------------------------------------------------- Missed the addonsButton.label in the Account Manager as it reads "Extensions and Themes" ::: mail/base/content/mainMailToolbox.inc.xhtml @@ +396,1 @@ > tooltiptext="&addonsButton.tooltip;" I think this should have its own toolbarbutton-addons-and-themes and also have that tooltiptext added to it so we can remove the addonsButton.tooptip from the messenger.dtd ::: mail/locales/en-US/messenger/accountManager.ftl @@ +1,5 @@ > +# This Source Code Form is subject to the terms of the Mozilla Public > +# License, v. 2.0. If a copy of the MPL was not distributed with this > +# file, You can obtain one at http://mozilla.org/MPL/2.0/. > + > +open-settings-button = { -brand-short-name } Settings Preferences, and also rename this ID with open-preferences-sidebar-button ::: mail/locales/en-US/messenger/menubar.ftl @@ +10,5 @@ > > +## Tools Menu > + > +# Since v89 we dropped the platforms distinction between Options or Preferences > +# and consolidated everything with Settings. Preferences ::: mail/locales/en-US/messenger/messenger.ftl @@ +55,5 @@ > + > +## AppMenu > + > +# Since v89 we dropped the platforms distinction between Options or Preferences > +# and consolidated everything with Settings. Preferences
Attachment #9213618 - Flags: review?(alessandro) → feedback+
Attached patch 1702731-prefs-and-addons-rename.patch (obsolete) (deleted) — — Splinter Review

Changed all to Preferences and Add-ons and Themes. Also in Add-ons manager.

Attachment #9213618 - Attachment is obsolete: true
Attachment #9213828 - Flags: review?(alessandro)
Attached patch 1702731-prefs-and-addons-rename.patch (obsolete) (deleted) — — Splinter Review

Sorry, my last change didn't go into the patch. Now corrected.

Attachment #9213828 - Attachment is obsolete: true
Attachment #9213828 - Flags: review?(alessandro)
Attachment #9213929 - Flags: review?(alessandro)
Comment on attachment 9213929 [details] [diff] [review] 1702731-prefs-and-addons-rename.patch Review of attachment 9213929 [details] [diff] [review]: ----------------------------------------------------------------- Great work, thanks! ::: mail/locales/en-US/messenger/preferences/preferences.ftl @@ +868,5 @@ > # > # Notice: The value of the `.style` attribute is a CSS string, and the `width` > # is the name of the CSS property. It is intended only to adjust the element's width. > # Do not translate. > +search-box-input = Let's call this `search-preferences-input`
Attachment #9213929 - Flags: review?(alessandro) → review+

(In reply to Alessandro Castellani [:aleca] from comment #11)

Comment on attachment 9213929 [details] [diff] [review]
1702731-prefs-and-addons-rename.patch

Review of attachment 9213929 [details] [diff] [review]:

Great work, thanks!

::: mail/locales/en-US/messenger/preferences/preferences.ftl
@@ +868,5 @@

Notice: The value of the .style attribute is a CSS string, and the width

is the name of the CSS property. It is intended only to adjust the element's width.

Do not translate.

+search-box-input =

Let's call this search-preferences-input

done

Attachment #9213929 - Attachment is obsolete: true
Attachment #9213982 - Flags: review+
status-thunderbird88: --- → unaffected
status-thunderbird89: --- → affected
status-thunderbird_esr78: --- → unaffected
Keywords: checkin-needed-tb
Target Milestone: --- → 89 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/451768f51f57
Rename the "Add-ons" to "Add-ons and Themes" and use "Preferences" for all platforms. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed-tb
Resolution: --- → FIXED

Somehow this is causing test failures at least for comm/calendar/test/browser/invitations/browser_icsAttachment.js, comm/mail/test/browser/composition/browser_emlActions.js and some more.

Flags: needinfo?(richard.marti)
Flags: needinfo?(alessandro)

I'll take a look at it.

Flags: needinfo?(alessandro)

Started a try with this removed: https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=a3c705dad23c887ee1cea4e63b2b2af029c1f5e9

I think I'm done for the day. If you find the problem, please land a bustage fix.
Alternatively hg import https://hg.mozilla.org/try-comm-central/rev/947240af322feee461d8ac2f93dde98834ef429c and push that to backout.

Reopening and grabbing this to fix the test failures.

Assignee: richard.marti → alessandro
Status: RESOLVED → REOPENED
Flags: needinfo?(richard.marti)
Resolution: FIXED → ---

This also breaks all tests in /mail/components/extensions/test/browser/ which use MailUtils.openMessageInNewWindow(msgHdr).

Attached patch 1702731-bustage-fix.diff (deleted) — — Splinter Review

This fixes all the failing tests locally.
Pushed a quick try-run to confirm: https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=88ddb5b92e24dd59399eb4a785543b54a35ca909

Since we're now (correctly) using the appmenu fluent string for the appmenu items, we were missing the inclusion of the messenger.ftl file for those windows that open independently from the mail tab.

Maybe adding the full messenger.ftl it's a bit of an overkill, but we can deal with that later.

Pushed by alessandro@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/9c7db09a36e3
Follow up, fix broken tests. rs=bustage-fix DONTBUILD

Status: REOPENED → RESOLVED
Closed: 4 years ago → 4 years ago
Resolution: --- → FIXED

(In reply to Wayne Mery (:wsmwk) from comment #2)

gah. this is going to affect docs and support.
I hope this is the end to their renames.

Totally agree. This change will effect the majority of users because they use Windows OS.
If you had changed MAC & Linux to 'Options' it would have had less impact on users and less impact on virtually all Support Articles and on virtually all Community Help discussions. The word 'Options' uses less space than 'Preferences' and this would appear to be the same for lots of translations.
I could understand the reasoning behind a change if you had changed MAC & Linux to 'Options' as it would have less impact in general. But changing Options to Preferences seems illogical, I cannot understand some of these decisions.

Summary: Rename the "Preferences/Options" to "Settings" and the "Add-ons" to "Add-ons and Themes" → Rename the "Preferences/Options" to "Preferences" and the "Add-ons" to "Add-ons and Themes"
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: