Closed Bug 1702909 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 28363 - [css-flex/TablesNG] Make flex honor table caption height

Categories

(Core :: Layout: Flexbox, task, P4)

Product:
Core
Component:
Layout: Flexbox
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
89 Branch
Tracking Flags:
Tracking Status
firefox89 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 28363 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28363
Details from upstream follow.

b'David Grogan <dgrogan@chromium.org>' wrote:

[css-flex/TablesNG] Make flex honor table caption height

Flexbox needs caption block size to compute table wrapper block size.
Table's css minimum-size specifies size of the grid, not the wrapper.
Wrapper's true block minimum size is css minimum-size + block size.

This patch exposes a method on TablesNG for flex to retrieve the caption
block size. (Thanks atotic!) Flex then adds the result to flex base size
when the flex base size derives from a specified block size or flex
basis.

Bug: 1181403
Change-Id: I61d7caf62708ae32850b89c444374e7a6c40d564
Reviewed-on: https://chromium-review.googlesource.com/2804711
WPT-Export-Revision: c6d70e37921df1b9a2c9f9477b485177520f7b98

Component: web-platform-tests → Layout: Flexbox
Product: Testing → Core
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a876a203e34b [wpt PR 28363] - [css-flex/TablesNG] Make flex honor table caption height, a=testonly https://hg.mozilla.org/integration/autoland/rev/32574b396fab [wpt PR 28363] - Update wpt metadata, a=testonly
Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/a876a203e34b
https://hg.mozilla.org/mozilla-central/rev/32574b396fab

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox89: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.