Closed Bug 1702980 Opened 4 years ago Closed 4 years ago

The Search[defaultSearchEngine] for “” link context menu option is not placed inside its own section

Categories

(Firefox :: Menus, defect, P2)

Product:
Firefox
Component:
Menus
Version:
Firefox 89
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
89 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox87 --- unaffected
firefox88 --- unaffected
firefox89 --- verified

People

(Reporter: emilghitta, Assigned: masterwayz)

References

(Blocks 2 open bugs, Regression)

Details

(Keywords: regression, Whiteboard: [proton-context-menus] [priority:2b])

Attachments

(3 files)

searchGoogleFor.png
(deleted), image/png
Details
Bug 1702980 - Fix "Search [defaultSearchEngine] for" contextmenu option not having its separator r?emalysz
(deleted), text/x-phabricator-request
Details
Bug 1702980 - Add test to make sure the context menu order is what we expect r?emalysz
(deleted), text/x-phabricator-request
Details
Attached image searchGoogleFor.png (deleted) —

Affected versions

  • Firefox 89.0a1 (BuildId:20210404214218)

Affected platforms

  • macOS 11
  • Windows 10 64bit
  • Ubuntu 18.04

Steps to reproduce

  1. Launch Firefox.
  2. Access the following link
  3. Right click on any text link.

Expected result

  • The Search [defaultSearchEngine] for “ “ option is placed in its own section as per the slide deck.

Actual result

  • The Search [defaultSearchEngine] for “ “ option is not placed inside its own section.

Regression Range
This is a regression.

Hi Michelle,

It seems that mozregression pointed out Bug 1701162 for causing this regression.

Can you please take a look?

Thank you!

Flags: needinfo?(michelle)
Has Regression Range: --- → yes
Has STR: --- → yes
Regressed by: 1701162

Set release status flags based on info from the regressing bug 1701162

status-firefox87: --- → unaffected
status-firefox88: --- → unaffected
status-firefox-esr78: --- → unaffected
Assignee: nobody → michelle
Status: NEW → ASSIGNED

Whoops. My patch should fix it, at least with my testing on a local build, currently it's awaiting review.

Flags: needinfo?(michelle)
Pushed by michelle@masterwayz.nl: https://hg.mozilla.org/integration/autoland/rev/20aa15b05faa Fix "Search [defaultSearchEngine] for" contextmenu option not having its separator r=emalysz

Would it be useful to add an automated test for the case QA reported here?

Flags: needinfo?(emalysz)

Yeah, we're going to add a test to browser_contextmenu_sendpage.js for positioning. Marking this as leave open until that lands

Flags: needinfo?(emalysz)
Keywords: leave-open
Priority: -- → P2
Whiteboard: [proton-context-menus] → [proton-context-menus] [priority:2b]
Attachment #9213854 - Attachment description: Bug 1702980 - Add test to make sure the context menu oorder is what we expect r?emalysz → Bug 1702980 - Add test to make sure the context menu order is what we expect r?emalysz
Keywords: leave-open
Pushed by michelle@masterwayz.nl: https://hg.mozilla.org/integration/autoland/rev/1300e90c6eec Add test to make sure the context menu order is what we expect r=emalysz

https://hg.mozilla.org/mozilla-central/rev/1300e90c6eec

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox89: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
Flags: in-testsuite+

Verified that this is fixed using latest Nightly 89.0a1 across platforms (Windows 10, macOS 11.3 and Ubuntu 18.04). Search <search engine> for "xxx" is now in its own group in between separators and has the correct placement as per design.

Status: RESOLVED → VERIFIED
status-firefox89: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: