Closed Bug 1703025 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 28367 - Revert "webcodecs: Stop closing frames in Audio|VideoEncoder.encode()"

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox89 fixed)

RESOLVED FIXED
89 Branch
Tracking Status
firefox89 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 28367 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28367
Details from upstream follow.

b'Fabian Sommer <fabiansommer@chromium.org>' wrote:

Revert "webcodecs: Stop closing frames in Audio|VideoEncoder.encode()"

This reverts commit 477ea10ee350777a599a4541b6e436ec42563597.

Reason for revert:

It looks like this CL is responsible for breaking the step
"blink_web_tests" on the builder "WebKit Linux MSAN".

First failing build:
https://ci.chromium.org/ui/p/chromium/builders/ci/WebKit%20Linux%20MSAN/9927

Original change's description:

webcodecs: Stop closing frames in Audio|VideoEncoder.encode()

Change-Id: I0281c1bdd836a94f968bf8fdf4fe8d09392845c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2803617
Reviewed-by: Thomas Guilbert \<tguilbert@chromium.org>
Reviewed-by: Chrome Cunningham \<chcunningham@chromium.org>
Commit-Queue: Eugene Zemtsov \<eugene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#869112}

Change-Id: Iacb9e31ff575129a7b320954a5d65dfaf6274b19
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2805814
Bot-Commit: Rubber Stamper \<rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Fabian Sommer \<fabiansommer@chromium.org>
Auto-Submit: Fabian Sommer \<fabiansommer@chromium.org>
Commit-Queue: Fabian Sommer \<fabiansommer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#869156}

PR 28367 applied with additional changes from upstream: bcda9254b0b4e6c1aa251f45d240a96e22d6fb1e, 9097d3f783ba87b8928fd3516fa475473e21bc1a

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 9 subtests

Status Summary

Firefox

OK : 2
FAIL : 19
ERROR: 1

Chrome

OK : 2
PASS : 38
FAIL : 4
ERROR: 1

Safari

OK : 2
FAIL : 19
ERROR: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/webcodecs/audio-encoder.any.html: ERROR (Chrome: ERROR, Safari: ERROR)
Simple audio encoding: FAIL (Chrome: PASS, Safari: FAIL)
/webcodecs/video-encoder.any.html
Test VideoEncoder construction: FAIL (Chrome: PASS, Safari: FAIL)
Test VideoEncoder.configure(): FAIL (Chrome: PASS, Safari: FAIL)
Test successful configure(), encode(), and flush(): FAIL (Chrome: FAIL, Safari: FAIL)
Test successful reset() and re-confiugre(): FAIL (Chrome: PASS, Safari: FAIL)
Test successful encode() after re-configure().: FAIL (Chrome: PASS, Safari: FAIL)
Test encoder consumes (closes) frames.: FAIL (Chrome: PASS, Safari: FAIL)
Verify closed VideoEncoder operations: FAIL (Chrome: PASS, Safari: FAIL)
Verify unconfigured VideoEncoder operations: FAIL (Chrome: PASS, Safari: FAIL)
Verify encoding closed frames throws.: FAIL (Chrome: PASS, Safari: FAIL)
/webcodecs/video-encoder.any.worker.html
Test VideoEncoder construction: FAIL (Chrome: PASS, Safari: FAIL)
Test VideoEncoder.configure(): FAIL (Chrome: PASS, Safari: FAIL)
Test successful configure(), encode(), and flush(): FAIL (Chrome: FAIL, Safari: FAIL)
Test successful reset() and re-confiugre(): FAIL (Chrome: PASS, Safari: FAIL)
Test successful encode() after re-configure().: FAIL (Chrome: PASS, Safari: FAIL)
Test encoder consumes (closes) frames.: FAIL (Chrome: PASS, Safari: FAIL)
Verify closed VideoEncoder operations: FAIL (Chrome: PASS, Safari: FAIL)
Verify unconfigured VideoEncoder operations: FAIL (Chrome: PASS, Safari: FAIL)
Verify encoding closed frames throws.: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/478dca6e172a [wpt PR 28367] - Revert "webcodecs: Stop closing frames in Audio|VideoEncoder.encode()", a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.