Closed Bug 1703357 Opened 4 years ago Closed 3 years ago

Write test to ensure OS.File is not imported in the startup path (before opening first browser window)

Categories

(Toolkit Graveyard :: OS.File, task, P3)

Product:
Toolkit Graveyard
Component:
OS.File
Type:
task

Tracking

(firefox97 fixed)

Status:
RESOLVED FIXED
Milestone:
97 Branch
Tracking Flags:
Tracking Status
firefox97 --- fixed

People

(Reporter: emmamalysz, Assigned: standard8)

References

Details

Attachments

(1 file)

Bug 1703357 - Update browser_startup to prevent osfile.jsm being loaded before opening first browser window. r?florian!
(deleted), text/x-phabricator-request
Details

We should make sure that any future modules do not import osfile.jsm by mistake and instead use IOUtils

Severity: -- → S3
Priority: -- → P3
Depends on: 1733485
Depends on: 1733535
Depends on: 1733538
Depends on: 1733540
Blocks: 1522925

I've just filed a set of mentored bugs that I think will be enough to get us in a state where we can add osfile.jsm to the deny lists in browser_startup.js for at least the "before opening first browser window" point. There may be more needed, but it is a little hard to tell at the moment.

I think we'll probably need bug 1649599 and bug 1649605 for "before first paint" - however, lets go for the earliest option first to begin to be able to block it, and we can progressively move it even later as we progress.

Depends on: 1649599
Depends on: 1735132
Summary: Write test to ensure OS.File is not imported in the startup path → Write test to ensure OS.File is not imported in the startup path before opening first browser window
Assignee: nobody → standard8
Status: NEW → ASSIGNED
Summary: Write test to ensure OS.File is not imported in the startup path before opening first browser window → Write test to ensure OS.File is not imported in the startup path (before opening first browser window)
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a4c999428d86 Update browser_startup to prevent osfile.jsm being loaded before opening first browser window. r=florian

https://hg.mozilla.org/mozilla-central/rev/a4c999428d86

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox96: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
Regressions: 1736189

Backed out for causing Bug 1736189

Backout link: https://hg.mozilla.org/integration/autoland/rev/772dfe279def087d275150ef1cc57350c05cdae2

Status: RESOLVED → REOPENED
status-firefox96: fixed → affected
Flags: needinfo?(standard8)
Resolution: FIXED → ---

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/772dfe279def087d275150ef1cc57350c05cdae2

Target Milestone: 96 Branch → ---
Flags: needinfo?(standard8)

I'm changing where we catch to slightly later - "before handling user events", as bug 1649605 has landed since this originally landed, which clears us loading OS.File until after that.

status-firefox96: affected → ---
Summary: Write test to ensure OS.File is not imported in the startup path (before opening first browser window) → Write test to ensure OS.File is not imported in the startup path (before handling user events)
Attachment #9247499 - Attachment description: Bug 1703357 - Update browser_startup to prevent osfile.jsm being loaded before opening first browser window. r?florian! → Bug 1703357 - Update browser_startup to prevent osfile.jsm being loaded before handling user events. r?florian!
Attachment #9247499 - Attachment description: Bug 1703357 - Update browser_startup to prevent osfile.jsm being loaded before handling user events. r?florian! → Bug 1703357 - Update browser_startup to prevent osfile.jsm being loaded before opening first browser window. r?florian!

Unfortunately I spoke too soon and didn't wait on the try server results. There's still a few more cases before we can clear the idle section as well. I've filed bug 1745459 as a follow-up to move the block later in startup.

Summary: Write test to ensure OS.File is not imported in the startup path (before handling user events) → Write test to ensure OS.File is not imported in the startup path (before opening first browser window)
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ba147b5b6ef8 Update browser_startup to prevent osfile.jsm being loaded before opening first browser window. r=florian

https://hg.mozilla.org/mozilla-central/rev/ba147b5b6ef8

Status: REOPENED → RESOLVED
Closed: 3 years ago → 3 years ago
status-firefox97: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch
Blocks: 1745459
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: