Closed
Bug 1703384
Opened 4 years ago
Closed 4 years ago
Failure in browser/components/urlbar/tests/browser/browser_autocomplete_a11y_label.js with proton urlbar
Categories
(Firefox :: Address Bar, defect, P1)
Firefox
Address Bar
Tracking
()
Tracking | Status | |
---|---|---|
firefox89 | --- | fixed |
People
(Reporter: mak, Assigned: bugzilla)
References
Details
(Whiteboard: [proton-address-bar])
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
There's a failure in browser/components/urlbar/tests/browser/browser_autocomplete_a11y_label.js when graduating the proton urlbar.
Updated•4 years ago
|
See Also: → https://jira.mozilla.com/browse/FIDEFE-1023
Updated•4 years ago
|
Priority: -- → P1
Assignee | ||
Updated•4 years ago
|
Assignee: nobody → htwyford
Severity: -- → S3
Status: NEW → ASSIGNED
Iteration: --- → 89.2 - Apr 5 - Apr 18
Points: --- → 1
Assignee | ||
Comment 1•4 years ago
|
||
The issue here is
FAIL Result a11y label should be: <title>— Switch to Tab - Got "about: robots Switch to Tab", expected "about: robots— Switch to Tab"
This is because we're no longer showing the title separator before the switch-to-tab action text. We should:
- Verify with Product and UX that we're sticking with the chiclet-style switch-to-tab action text
- If yes, check if there's a difference between the way screen readers read "<title>— Switch to Tab " and "<title> Switch to Tab"
2a) If no, just change the test.
2b) If yes, ensure the title separator isn't hidden to screen readers.
Assignee | ||
Comment 2•4 years ago
|
||
We're sticking with the switch-to-tab chiclet design, i.e. we're removing the title separator. Also, there's a difference in the way VoiceOver reads "<title>— Switch to Tab " and "<title> Switch to Tab". So we're going with option (2b).
Assignee | ||
Comment 3•4 years ago
|
||
We want the screen reader to pause between announcing the result title and the switch-to-tab action text. I considered:
- Set position:absolute on the title separator and left: -999px or the like. This works but is bad semantically IMO.
- Continue to set visibility: hidden on the title separator. Insert an em dash into the aria-label on the row/action text, so screen readers pause. This would work, but is more complex. It's not clear in the CSS what's happening in the a11y tree.
- Take advantage of the fact that we know from the CSS exactly how big the title-separator is. The title-separator is an em dash with a 0.4em margin. Em dashes are, by definition, exactly 1em wide. Convenient!
Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/632daf704310
Make the switch-to-tab title separator transparent so it stays in the accessibility tree. r=mak
Comment 5•4 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox89:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•