IOUtils.write to a directory with a tempfile does not fail
Categories
(Toolkit Graveyard :: OS.File, defect, P3)
Tracking
(firefox90 fixed)
Tracking | Status | |
---|---|---|
firefox90 | --- | fixed |
People
(Reporter: barret, Assigned: barret)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Doing IOUtils.write(directory, data)
fails as expected (because you cannot open a directory for writing, but IOUtils.write(directory, data, { tmpFile: "somePath" })
will not fail. Instead, we end up with a file containing data
a ${directory}/somePath
.
Assignee | ||
Comment 1•4 years ago
|
||
Updated•4 years ago
|
Comment 3•4 years ago
|
||
Backed out for causing failures due to files in tmp folder.
backout: https://hg.mozilla.org/integration/autoland/rev/c00239b6c35155149b2e2d8caa02c1c96d21e546
failure log: https://treeherder.mozilla.org/logviewer?job_id=337410809&repo=autoland&lineNumber=2258
task 2021-04-22T05:23:26.628Z] 05:23:26 INFO - TEST-PASS | dom/base/test/browser_aboutnewtab_process_selection.js | Navigating away from the preloaded browser (child side, cross-origin) should create a new content process. -
[task 2021-04-22T05:23:26.628Z] 05:23:26 INFO - Buffered messages finished
[task 2021-04-22T05:23:26.628Z] 05:23:26 INFO - TEST-UNEXPECTED-FAIL | dom/base/test/browser_aboutnewtab_process_selection.js | A promise chain failed to handle a rejection: Could not stat the file at /tmp/tmpNO18t9.mozrunner/datareporting/state.json - stack: (No stack available.)
[task 2021-04-22T05:23:26.629Z] 05:23:26 INFO - Rejection date: Thu Apr 22 2021 05:23:17 GMT+0000 (Coordinated Universal Time) - false == true - JS frame :: resource://testing-common/PromiseTestUtils.jsm :: assertNoUncaughtRejections :: line 285
[task 2021-04-22T05:23:26.629Z] 05:23:26 INFO - Stack trace:
[task 2021-04-22T05:23:26.629Z] 05:23:26 INFO - resource://testing-common/PromiseTestUtils.jsm:assertNoUncaughtRejections:285
[task 2021-04-22T05:23:26.629Z] 05:23:26 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1127
[task 2021-04-22T05:23:26.629Z] 05:23:26 INFO - Leaving test bound
[task 2021-04-22T05:23:26.629Z] 05:23:26 INFO - Entering test bound preloaded_state_attribute
[task 2021-04-22T05:23:28.051Z] 05:23:28 INFO - TEST-PASS | dom/base/test/browser_aboutnewtab_process_selection.js | Sanity check that the first preloaded browser has the correct attribute -
Also failing:
- TEST-UNEXPECTED-FAIL | dom/system/tests/ioutils/test_ioutils_read_write.html | NotFoundError: Could not stat the file at /tmp/test_write_with_backup_and_tmp_options.tmp - Should not throw any errors
- TEST-UNEXPECTED-FAIL | browser/components/migration/tests/marionette/test_refresh_firefox.py TestFirefoxRefresh.testResetEverything | AssertionError: Sequences differ: ['https://www.mozilla.org/en-US/firefox/nightly/firstrun/'] != ['about:welcomeback']
Assignee | ||
Updated•4 years ago
|
Comment 5•4 years ago
|
||
bugherder |
Updated•2 years ago
|
Description
•