Closed Bug 1703586 Opened 4 years ago Closed 4 years ago

The buttons in the "Report a Broken Site" UI in the protections panel are styled incorrectly

Categories

(Firefox :: Protections UI, defect)

defect

Tracking

()

RESOLVED FIXED
89 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox87 --- unaffected
firefox88 --- unaffected
firefox89 --- fixed

People

(Reporter: itiel_yn8, Assigned: luzdelarosaramirez, Mentored)

References

(Regression)

Details

(Keywords: regression)

Attachments

(8 files)

Attached image Screenshot (deleted) —

Also resetting the margin-inline of the URL field to 0 could be nice, to make it flush with the rest of the elements.

Set release status flags based on info from the regressing bug 1697486

Assignee: nobody → luzdelarosaramirez
Mentor: prathikshaprasadsuman
Status: NEW → ASSIGNED

The above patch addresses four tasks:

  1. Fixes the left alignment of the "Browse without being followed" and strings below that in the main view.
  2. Fixes the styling of the buttons on the "Report a Broken Site" panel.
  3. Fixes the left side alignment in the subpanel when you click on a blocked item in the main view.
  4. Fixes the URL field margin on the "Report a Broken Site" panel.

Also, I attached some screenshots for each task with and without the patch.

Attached image task_1_without_fix.png (deleted) —

Task 1 screenshot without the fix

Attached image task_1_with_fix.png (deleted) —

Task 1 screenshot with the fix

Attached image task_2_without_fix.png (deleted) —

Task 2 and 4 screenshot without the fix

Attached image task_2_with_fix.png (deleted) —

Task 2 and 4 screenshot with the fix

Attached image task_3_without_fix.png (deleted) —

Task 3 screenshot without the fix

Attached image task_3_with_fix.png (deleted) —

Task 3 screenshot with the fix

Attachment #9215975 - Attachment description: Bug 1703586 - The buttons in the Report a Broken Site UI in the protections panel are styled incorrectly. r=prathiksha → Bug 1703586 - Fix tiny layout issues in the protections panel. r=prathiksha
Pushed by prathikshaprasadsuman@gmail.com: https://hg.mozilla.org/integration/autoland/rev/9fb4a291768b Fix tiny layout issues in the protections panel. r=prathiksha
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: