Closed
Bug 1703807
Opened 4 years ago
Closed 4 years ago
Customize toolbar page - update checkboxes focus rings to respect Proton format
Categories
(Firefox :: Toolbars and Customization, enhancement, P3)
Tracking
()
VERIFIED
FIXED
89 Branch
Tracking | Status | |
---|---|---|
firefox89 | --- | wontfix |
People
(Reporter: cfogel, Assigned: itiel_yn8)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [proton-toolbar])
Attachments
(2 files)
Affected versions
- 89.0a1(2021-04-07)
Affected platforms
- Win10;
Steps to reproduce
- pref set to true: browser.proton.enabled
- Launch Firefox, right click on the toolbar click on Customize toolbar option;
- Click on Drag Space checkbox;
- Shift+TAB to reach Title Bar checkbox;
Expected result
- checkboxes have the Proton styling applied;
Actual result
- only colors updated to Proton styling;
Regression range
- visible with proton changes;
Additional notes
- remains to be confirmed on Ubuntu;
- set as S4, as this might not be worked upon yet;
- same for Checkbox for Density and Dragspage;
- attached screenshot to illustrate the issue.
Reporter | ||
Updated•4 years ago
|
Has STR: --- → yes
Updated•4 years ago
|
See Also: → https://jira.mozilla.com/browse/FIDEFE-1089
Updated•4 years ago
|
Priority: -- → P3
Updated•4 years ago
|
Assignee: nobody → itiel_yn8
Status: NEW → ASSIGNED
Pushed by itiel_yn8@walla.com:
https://hg.mozilla.org/integration/autoland/rev/b1695cda8cf9
Adjust non-native checkboxes and menulists focus ring for Proton r=mconley
Comment 3•4 years ago
|
||
Backed out changeset b1695cda8cf9 (Bug 1703807) for causing bc failures in browser_parsable_css.js.
https://hg.mozilla.org/integration/autoland/rev/8dfe8c91f1d7fb7d7757811c08f43513a7aeae67
Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&revision=b1695cda8cf952331addc65abafaae9997fedfce&selectedTaskRun=ATCpUprYSHWznFHZCf0RWw.0
Failure log:
https://treeherder.mozilla.org/logviewer?job_id=336406685&repo=autoland&lineNumber=2643
Flags: needinfo?(itiel_yn8)
Pushed by itiel_yn8@walla.com:
https://hg.mozilla.org/integration/autoland/rev/0aac8041b5fd
Adjust non-native checkboxes and menulists focus ring for Proton r=mconley
Comment 5•4 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
Comment 6•4 years ago
|
||
Verified fixed with 89.0a1 (20210414093129) on Windows 10x64. The checkboxes have proton styling.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•