Closed Bug 1703914 Opened 4 years ago Closed 3 years ago

Remove --toolbarbutton-icon-fill-opacity CSS variable

Categories

(Firefox :: Theme, task, P3)

Product:
Firefox
Component:
Theme
Type:
task
Points:
1

Tracking

()

Status:
RESOLVED FIXED
Milestone:
92 Branch
Tracking Flags:
Tracking Status
firefox92 --- fixed

People

(Reporter: mconley, Assigned: bigiri)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-cleanups])

Attachments

(1 file)

Bug 1703914 - Removed --toolbarbutton-icon-fill-opacity CSS var r=mconley
(deleted), text/x-phabricator-request
Details

In bug 1703651, we made it so that most icons have an opacity of 1 by default. We did this by updating the --toolbarbutton-icon-fill-opacity CSS variable, mainly so that we could continue to support the non-Proton styles simultaneously.

Once Proton ships and hits release, we should consider retiring the --toolbarbutton-icon-fill-opacity CSS variable entirely, since it's probably not needed anymore.

Depends on: 1703651
Priority: -- → P3
Points: --- → 1

https://searchfox.org/mozilla-central/search?q=toolbarbutton-icon-fill-opacity shows it is only ever set to 1 now, so we can just remove it.

Summary: Consider removing --toolbarbutton-icon-fill-opacity CSS variable → Remove --toolbarbutton-icon-fill-opacity CSS variable
Assignee: nobody → bigiri
Status: NEW → ASSIGNED

All uses of --toolbarbutton-icon-fill-opacity have been replaced with 1 and all declarations of it have been removed.

Pushed by bigiri@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/770273d8e001 Removed --toolbarbutton-icon-fill-opacity CSS var r=mconley,desktop-theme-reviewers,dao

https://hg.mozilla.org/mozilla-central/rev/770273d8e001

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox92: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: