Closed Bug 1704050 Opened 4 years ago Closed 4 years ago

Urlbar text highlight does not match Figma spec

Categories

(Firefox :: Address Bar, defect, P5)

Firefox 89
defect

Tracking

()

RESOLVED WONTFIX
Tracking Status
firefox-esr78 --- unaffected
firefox87 --- unaffected
firefox88 --- unaffected
firefox89 --- affected

People

(Reporter: phorea, Unassigned)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [proton-address-bar])

Attachments

(2 files)

Attached image text selection on dark theme (deleted) —

Affected versions

  • Fx89.0a1 2021-04-08

Affected platforms

  • Windows 10 64-bit
  • OSX 11.2.3

Preconditions

  • The following prefs are enabled in about:config:
    browser.proton.enabled
    browser.proton.toolbar.enabled
    browser.proton.urlbar.enabled

Steps to reproduce

  1. Launch Firefox and from about:addons - Themes, select Dark Theme
  2. Input a long string in the address bar and then select around half of the string using the mouse or the keyboard
  3. Change the theme to Light and repeat the previous step

Expected result

  • The selected string matches Figma dark and light themes

Actual result

  • For dark theme: Text selection is white (Windows) and blue-ish (OSX) if the window is in focus, respectively grey when the window is out of focus
  • For light theme: Text selection is blue

Regression range

  • Not a regression, text selection is the same pre-Proton

In the dark theme spec, there's a note that says text selection color should be determined by the OS, meaning the current behaviour is correct. I think other parts of the Figma spec using a different highlight color is a mistake in the spec. Amy can confirm.

Link to the section in the spec: https://www.figma.com/file/FjUe6ORvXZgJvI3rPuTV33/Desktop-UI-(Mozilla-Confidential-)?node-id=4193%3A1558

Flags: needinfo?(amlee)

Marking as P5 since this seems to be a need for Figma adjustments

Priority: -- → P5

(In reply to Harry Twyford [:harry] from comment #1)

Created attachment 9214667 [details]
Screen Shot 2021-04-09 at 9.02.12 AM.png

In the dark theme spec, there's a note that says text selection color should be determined by the OS, meaning the current behaviour is correct. I think other parts of the Figma spec using a different highlight color is a mistake in the spec. Amy can confirm.

Link to the section in the spec: https://www.figma.com/file/FjUe6ORvXZgJvI3rPuTV33/Desktop-UI-(Mozilla-Confidential-)?node-id=4193%3A1558

Hi, yes this is determined by the OS.

Flags: needinfo?(amlee)
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WONTFIX

But the white highlight in dark theme should be fixed so please take a look at 1476524, it looks wrong and bad

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: