[Proton] Right-clicking on the overscroll blank space will toggle the context menu for the elements in the tabs bar, bookmarks bar, etc
Categories
(Core :: Panning and Zooming, defect, P2)
Tracking
()
People
(Reporter: andrei.purice, Assigned: botond)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [mac:ux] )
Attachments
(6 files)
Tested on:
Nightly 89.0a1
TestedPlatform:
MacOS 10.14
MacOS 10.15
Have the following pref enabled:
"apz.overscroll.enabled" = "True"
Steps to reproduce:
- Open any webpage (i.e. : www.google.com).
- Scroll up and down in order to perform the overscroll
- Interact with the empty blank overscroll space
Expected Results:
The cursor is static and there is no interaction with the blank overscroll space.
Actual Results:
The cursor's position (even though static) is moved (but not visually) and changes with the length of the scroll.
Notes:
In this video we have scrolled and pressed mouse button 2, in the overscroll area, thus opening context menus from current tab and bookmark options. Though the cursor was stationed the overscroll effect was dragging it upwards.
Not a regression since the feature was added in Nightly 89.
|
Reporter | |
Updated•4 years ago
|
|
||
Comment 1•4 years ago
|
||
After you dismiss the context menu (and lift your fingers from the touchpad completely) the page stays in overscroll too.
|
Assignee | |
Comment 2•4 years ago
|
||
This was supposed to have been fixed by bug 1686146, but it looks like it wasn't (I can reproduce). Will investigate.
|
|
Assignee | |
Updated•4 years ago
|
|
||
Comment 3•4 years ago
|
||
(In reply to Timothy Nikkel (:tnikkel) from comment #1)
After you dismiss the context menu (and lift your fingers from the touchpad completely) the page stays in overscroll too.
It's related to bug 1703705, any incoming events handled by APZ (i.e. calling AsyncPanZoomController::SetState) will prevent from restoring the overscroll state.
|
|
Assignee | |
Comment 4•4 years ago
|
||
On Linux at least, the reason for this is that the widget code dispatches the context menu event to Gecko without respecting the event status returned by APZ.
The diagnosis is likely similar for Mac, but in the Mac widget code.
|
|
Assignee | |
Comment 5•4 years ago
|
||
|
|
Assignee | |
Comment 6•4 years ago
|
||
Depends on D111761
|
|
Assignee | |
Comment 7•4 years ago
|
||
Depends on D111762
|
|
Assignee | |
Comment 8•4 years ago
|
||
Hiro, could I get your help with fixing this for Mac? I've already written a test which is failing on Mac, and just needs to be made to pass.
(The Mac fix could be in this bug, or in a different bug in which case I can disable the test on Mac when I land it in this bug.)
|
|
||
Comment 9•4 years ago
|
||
FWIW, with this change on Mac, contextmenu no longer appears by right clicking in overscrolled gutters, but the test still fails for some reasons.
|
|
||
Comment 10•4 years ago
|
||
(In reply to Hiroyuki Ikezoe (:hiro) from comment #9)
Created attachment 9215343 [details] [diff] [review]
A patch for MacFWIW, with this change on Mac, contextmenu no longer appears by right clicking in overscrolled gutters, but the test still fails for some reasons.
I did comment the failure reason in https://phabricator.services.mozilla.com/D111761#inline-622695.
|
|
||
Comment 11•4 years ago
|
||
|
||
Updated•4 years ago
|
|
||
Comment 12•4 years ago
|
||
|
||
Comment 13•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/49eac9a88178
https://hg.mozilla.org/mozilla-central/rev/e11655b5fcb8
https://hg.mozilla.org/mozilla-central/rev/24f9cd867dd2
https://hg.mozilla.org/mozilla-central/rev/1c11e0dd1cdb
|
|
Reporter | |
Comment 14•4 years ago
|
||
Verified fixed on the latest version of Nightly 89.0a1 (2021-04-18) (20210418213620) on MacOS 10.14, 10.15 and 11.2.
|
|
Reporter | |
Updated•4 years ago
|
|
||
Updated•3 years ago
|
Description
•