When opening a native context menu in the bookmarks sidebar, add-on items are missing
Categories
(Core :: Widget: Cocoa, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox89 | --- | verified |
People
(Reporter: mstange, Assigned: mstange)
References
Details
(Whiteboard: [proton-context-menus][mac:mr1])
Attachments
(4 files)
|
Bug 1704127 - Use NS_NewRunnableFunction instead of a custom nsXULPopupShowingEvent class. r=tnikkel
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details |
Steps to reproduce:
- Enable
widget.macos.native-context-menus. - Install the Side View add-on from https://addons.mozilla.org/en-US/firefox/addon/side-view/ .
- Open the bookmarks sidebar.
- Right-click a bookmark.
Expected results:
The menu should contain an "Open in sidebar" item.
Actual results:
The item is not present. It is only present if widget.macos.native-context-menus is false.
This bug was caught by the test browser/components/extensions/test/browser/browser_ext_contextMenus.js.
|
Assignee | |
Comment 1•4 years ago
|
||
The problem here is that native context menus do not set the right x/y values on the popupshowing event. onBookmarksContextMenu uses those values to find the right cell in the tree.
|
||
Updated•4 years ago
|
|
|
Assignee | |
Comment 2•4 years ago
|
||
|
|
Assignee | |
Comment 3•4 years ago
|
||
Depends on D111499
|
|
Assignee | |
Comment 4•4 years ago
|
||
Depends on D111500
|
|
Assignee | |
Comment 5•4 years ago
|
||
This makes sure that all the correct properties are set, such as the event
position and input mode.
Depends on D111501
|
||
Comment 7•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/68ecb4413768
https://hg.mozilla.org/mozilla-central/rev/60238814a4bd
https://hg.mozilla.org/mozilla-central/rev/3a08030ba3a3
https://hg.mozilla.org/mozilla-central/rev/b23d2354ba02
|
||
Comment 8•4 years ago
|
||
Reproduced the issue mentioned in comment 0 using Firefox 89.0a1 (build from 2021-04-09).
This issue is verified fixed using Firefox 89.0a1 (BuildId:20210414160838) on macOS 10.15 with native menus enabled.
Description
•