Closed Bug 1704212 Opened 4 years ago Closed 4 years ago

Make XULElement.openMenu(true) work for native context menus

Categories

(Core :: Widget: Cocoa, task)

Product:
Core
Component:
Widget: Cocoa
Platform:
All
macOS
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
89 Branch
Tracking Flags:
Tracking Status
firefox89 --- fixed

People

(Reporter: mstange, Assigned: mstange)

References

Details

(Whiteboard: [proton-context-menus][mac:mr1])

Attachments

(7 files, 1 obsolete file)

Bug 1704212 - Move part of nsXULElement::OpenMenu into a new method called nsXULPopupManager::HideMenu. r=tnikkel
(deleted), text/x-phabricator-request
Details
Bug 1704212 - Remove unused return value from MenuOpened(), make MenuOpened() ignore repeated invocations, and adjust comments. r=harry
(deleted), text/x-phabricator-request
Details
Bug 1704212 - Add NativeMenu::OpenSubmenu. r=harry
(deleted), text/x-phabricator-request
Details
Bug 1704212 - Make nsXULPopupManager::ShowMenu handle native menus, so that menu.openMenu(true) can be used in tests to support native menus. r=tnikkel
(deleted), text/x-phabricator-request
Details
Bug 1704212 - Add NativeMenu::CloseSubmenu. r=harry
(deleted), text/x-phabricator-request
Details
Bug 1704212 - Make nsXULPopupManager::HideMenu handle native menus, so that menu.openMenu(false) can be used in tests to support native menus. r=tnikkel
(deleted), text/x-phabricator-request
Details
Bug 1704212 - Make sure we don't forget about simulated-open submenus when closing their parents, and try to enforce that submenus run their popuphidden events before their parents. r=harry
(deleted), text/x-phabricator-request
Details

XULElement has an openMenu method which can be used to open context menu submenus: menu.openMenu(true).
We should make this method work with native menus as well, so that automated tests using it will work with both non-native and native menus.

Summary: Make XULMenuElement.openSubmenu work for native context menus → Make XULElement.openMenu(true) work for native context menus

Depends on D111522

Depends on D111661

Depends on D111664

Attachment #9214993 - Attachment is obsolete: true
Pushed by mstange@themasta.com: https://hg.mozilla.org/integration/autoland/rev/21d2bf5db183 Move part of nsXULElement::OpenMenu into a new method called nsXULPopupManager::HideMenu. r=tnikkel https://hg.mozilla.org/integration/autoland/rev/97a92ca9b16f Remove unused return value from MenuOpened(), make MenuOpened() ignore repeated invocations, and adjust comments. r=harry https://hg.mozilla.org/integration/autoland/rev/4fa3e5b83b9d Add NativeMenu::OpenSubmenu. r=harry https://hg.mozilla.org/integration/autoland/rev/8aac76367f33 Make nsXULPopupManager::ShowMenu handle native menus, so that menu.openMenu(true) can be used in tests to support native menus. r=tnikkel https://hg.mozilla.org/integration/autoland/rev/297987c412d9 Add NativeMenu::CloseSubmenu. r=harry https://hg.mozilla.org/integration/autoland/rev/0fc48ae0ad09 Make nsXULPopupManager::HideMenu handle native menus, so that menu.openMenu(false) can be used in tests to support native menus. r=tnikkel https://hg.mozilla.org/integration/autoland/rev/f040df39cdc1 Make sure we don't forget about simulated-open submenus when closing their parents, and try to enforce that submenus run their popuphidden events before their parents. r=harry
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: