Closed Bug 1704312 Opened 4 years ago Closed 4 years ago

Label alignment is incorrect in Text Encoding toolbutton

Categories

(Firefox :: Toolbars and Customization, defect)

Firefox 89
Desktop
Windows 10
defect

Tracking

()

RESOLVED INVALID

People

(Reporter: alice0775, Unassigned)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: nightly-community, regression, Whiteboard: [proton-door-hangers])

Attachments

(1 file)

Attached image screenshot (deleted) —

Steps to reproduce:

  1. Put Text Encoding toolbutton in nav bar
  2. Open data:text/html;Shift_JIS,Other than UTF-8:%E3%81%82<a href="https://www.google.com" style="float:right;padding-right:50px;">Go to Google</a>
  3. Click Text Encoding toolbutton

Actual results:
Label alignment is incorrect.
See screenshot

Expected results:
Label should be aligned.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=8aa1b80a8c6b66cccc2e37080fbf6197eee8d801&tochange=1716229005d8b97f305bd663b8bc8d3fec4a4f3a

There is intentionally a lack of icon gutter in the Proton panels. @amylee, do you know what we're supposed to do with panels like the Charset panel which allows users to select one from a set of choices?

Flags: needinfo?(amlee)
Whiteboard: [proton-door-hangers]

@mconley Hi, the 89.0 screenshot (left) is correct, indenting the selected item with no gutter.

Flags: needinfo?(amlee)

Okay, thank you!

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INVALID
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: