Closed Bug 1704414 Opened 4 years ago Closed 4 years ago

Proton: page zoom button inside URL bar has barely visible hover feedback when Dark theme is selected

Categories

(Firefox :: Address Bar, defect, P2)

Firefox 89
defect

Tracking

()

VERIFIED FIXED
89 Branch
Tracking Status
firefox89 --- verified

People

(Reporter: billdillensrevenge, Assigned: mak)

References

(Blocks 1 open bug)

Details

(Keywords: nightly-community, Whiteboard: [proton-address-bar] [priority:2a])

Attachments

(2 files)

Attached image Proton page zoom button dark theme.png (deleted) —

Go to Customize > Themes and select "Dark". Change page zoom, then hover cursor over the button that appears in the URL bar. Observe there is no hover feedback. Strangely though, when I select "Default" theme, there IS hover feedback, even though nothing appears to have changed (I have Windows 10 in dark mode).

Confirmed for macOS. Hover state is there for light theme, as well as the default and Alpenglow with the OS set to dark, but not the stand alone Dark theme itself.

OS: Unspecified → All
Hardware: Unspecified → All

Actually there is hover, it's just hard to see it due to the very dark background. Try Alpenglow that is another brighttext theme and you'll see it.

We may want to hardcode some colors for the default themes, but this is, imo, low priority.

Whiteboard: [proton-address-bar]
Summary: Proton: page zoom button inside URL bar has no hover feedback when Dark theme is selected → Proton: page zoom button inside URL bar has barely visible hover feedback when Dark theme is selected

The fact that dark theme with light OS theme gives no visible hover state whereas default theme with dark OS theme does seems a little concerning (I also see it on Win10). Should both scenarios not give the exact same appearance?

Priority: -- → P2
Whiteboard: [proton-address-bar] → [proton-address-bar] [priority:2a]
Assignee: nobody → mak
Status: NEW → ASSIGNED
Pushed by mak77@bonardo.net: https://hg.mozilla.org/integration/autoland/rev/38ffdcebd383 Unfocused urlbar chiclet should look the same as Dark theme when default theme is in dark mode. r=harry,desktop-theme-reviewers
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch

verified fix on windows10 64bit, ubuntu 20 and MacOs 10.15 using firefox nightly 89.0a1

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: