Closed
Bug 1704459
Opened 3 years ago
Closed 3 years ago
User properties aren't cleared in case of server side target switching
Categories
(DevTools :: Inspector: Rules, defect, P3)
DevTools
Inspector: Rules
Tracking
(firefox91 fixed)
RESOLVED
FIXED
91 Branch
| Tracking | Status | |
|---|---|---|
| firefox91 | --- | fixed |
People
(Reporter: ochameau, Assigned: nchevobbe)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Because user properties are cleared by listening to navigate event:
https://searchfox.org/mozilla-central/rev/fa48ebee58d59fa846919c3e2c3122b08db57c9c/devtools/client/inspector/rules/rules.js#2024
this.inspector.currentTarget.on("navigate", this.clearUserProperties);
This isn't called/cleared when doing a server side target switching.
i.e. when enabling devtools.target-switching.server.enabled and navigating between two distinct origins.
We should instead rely on onTargetAvailable and/or DOCUMENT_EVENT, which both fires reliably.
|
||
Updated•3 years ago
|
Fission Milestone: --- → M7a
Whiteboard: dt-fission-m3-triage → dt-fission-m3-mvp
|
||
Updated•3 years ago
|
Severity: -- → S3
Priority: -- → P3
|
|
||
Updated•3 years ago
|
Fission Milestone: M7a → M8
|
Assignee | |
Updated•3 years ago
|
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•3 years ago
|
||
We're using the will-navigate element as it fires very early
and we want to get rid of any data stored for the document
we're navigating away from.
|
|
||
Updated•3 years ago
|
Fission Milestone: M8 → ---
Whiteboard: dt-fission-m3-mvp
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/07928d5d62e0 [devtools] Clear rule view userProperties on DOCUMENT_EVENT resource. r=ochameau.
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox91:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•