Make dom/serviceworkers/test/test_openWindow.html to pass with Fission+bfcache
Categories
(Core :: DOM: Service Workers, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox89 | --- | fixed |
People
(Reporter: smaug, Assigned: emilio)
References
(Blocks 1 open bug)
Details
Attachments
(2 files, 1 obsolete file)
The test seems to fail reliably with Fission+BFcache. The failure looks similar to bug 1670471.
Assignee | ||
Updated•4 years ago
|
Reporter | ||
Comment 1•4 years ago
|
||
The failure wasn't in peterv's latest try run.
Assignee | ||
Comment 2•4 years ago
|
||
With fission+BFCache, we get a notification for the initial document,
and that fails the same-origin check (because about:blank isn't
same-origin with the opener) so we resolve the promise with null
rather than returning a client.
Instead, wait for the right load to arrive if the top level window
global is the initial document.
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 3•4 years ago
|
||
Ah, it fails on current central. Does peterv's try run have other patches on top?
Assignee | ||
Comment 4•4 years ago
|
||
From Matrix:
emilio: I would expect peterv's patches just change the timing a bit so perhaps the failure didn't show up in that run
Comment 6•4 years ago
|
||
Backed out for causing leackcheck failures.
Backout link: https://hg.mozilla.org/integration/autoland/rev/adaa9e66f6f422fef5581b7186008b46b864b105
Failure log: https://treeherder.mozilla.org/logviewer?job_id=336660863&repo=autoland&lineNumber=8956
https://treeherder.mozilla.org/logviewer?job_id=336662561&repo=autoland&lineNumber=6138
Assignee | ||
Comment 7•4 years ago
|
||
The patch got backed out due to a problem that's pre-existing. This
listener keeps alive itself via a cyclic reference to mPromise, and
relies on the STOP notification to clean up that cycle.
nsDocLoader was firing that notification, but BrowserChild stopped
listening too early.
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 8•4 years ago
|
||
This is enough to fix the leak though perhaps the other patch also makes
sense.
Depends on D112351
Comment 10•4 years ago
|
||
Comment 11•4 years ago
|
||
Comment 12•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/965ee49c1418
https://hg.mozilla.org/mozilla-central/rev/4c2d34efd577
https://hg.mozilla.org/mozilla-central/rev/12cff22d0247
Updated•4 years ago
|
Updated•4 years ago
|
Description
•