Deduplicate and consolidate checkmark icons across the tree
Categories
(Firefox :: Theme, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox91 | --- | verified |
People
(Reporter: mconley, Assigned: bigiri)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [proton-cleanups][proton-icons])
Attachments
(1 file, 1 obsolete file)
|
(deleted),
text/x-phabricator-request
|
Details |
After bug 1699889, the following duplicate checkmarks will exist:
- chrome/toolkit/skin/classic/global/icons/success.svg
- chrome/toolkit/skin/classic/global/icons/check.svg
We also have this old DevTools checkmark around which we should probably change to use the shared one.
- browser/chrome/devtools/skin/images/check.svg
|
||
Comment 1•4 years ago
|
||
fwiw, success.svg is linked to https://searchfox.org/mozilla-central/rev/3de2db87f3c9001ae478318d47a2ca3427574382/browser/themes/shared/icons/success-animation.svg . So that should be removed as well or be updated.
|
||
Updated•4 years ago
|
|
||
Updated•4 years ago
|
|
Reporter | |
Updated•4 years ago
|
|
Assignee | |
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 2•3 years ago
|
||
The success-animation.svg has been split out into Bug 1716827 to avoid scope creep.
|
|
Assignee | |
Comment 3•3 years ago
|
||
Replaced instances of success.svg with check.svg and removed success.svg.
|
||
Comment 5•3 years ago
|
||
| bugherder | ||
|
||
Comment 6•3 years ago
|
||
Hi Mike, can you please tell us which icons are these ? where can we find them ?
|
|
Reporter | |
Comment 7•3 years ago
|
||
Hi Rares,
Sorry for the delay. The success.svg icons were de-duplicated to check.svg, meaning that to verify this, you need to look at all of the old places that success.svg was being used. Those places are:
- about:logins (after successfully copying a username or password to the clipboard)
- about:config (when editing a value)
- about:addons (verified add-ons)
|
|
||
Comment 8•3 years ago
|
||
Thank you Mike, I was able to verify these on Windows, Mac and Ubuntu in our latest Nightly build 91.0a1 (2021-07-08), I will mark this task accordingly.
|
|
Assignee | |
Comment 9•3 years ago
|
||
Removing unused and unwanted Confirmation Hints.
|
|
Assignee | |
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
|
||
Comment 10•3 years ago
|
||
Comment on attachment 9241865 [details]
Bug 1704669 - Removing unused/unwanted Confirmation Hints r=harry
Revision D126016 was moved to bug 1703979. Setting attachment 9241865 [details] to obsolete.
Description
•