Closed Bug 1704767 Opened 4 years ago Closed 3 years ago

Remove --downloads-item-height in Firefox

Categories

(Firefox :: Downloads Panel, task, P3)

task

Tracking

()

RESOLVED INVALID

People

(Reporter: prathiksha, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-cleanups])

Attachments

(1 file)

Severity: -- → S3
Whiteboard: [proton-cleanups]
Priority: -- → P3

hey I would like to take this issue. and from my understanding, we need to remove all this line '--downloads-item-height' in entire firefox codebase and also I should ensure that removing this line does not affect any other elements which rely on this line.

Am I right?

Flags: needinfo?(tigleym)

(In reply to Dhanesh from comment #1)

hey I would like to take this issue. and from my understanding, we need to remove all this line '--downloads-item-height' in entire firefox codebase and also I should ensure that removing this line does not affect any other elements which rely on this line.

Am I right?

Hi Dhanesh! Yes, we want to remove all occurrences of --downloads-item-height and just directly set the height on the download item (@item@) in the stylesheet they're used in.

Flags: needinfo?(tigleym)

The value of '--downloads-item-height' seems to differ from OS to OS. So what value should I set ?

Attached image Screenshot.png (deleted) —

Prathiksha, is this bug still valid, given comment #3 ? It seems we're setting the same thing to different values in a bunch of different places still.

Flags: needinfo?(prathikshaprasadsuman)

(In reply to :Gijs (out; back Jun 21; he/him) from comment #5)

Prathiksha, is this bug still valid, given comment #3 ? It seems we're setting the same thing to different values in a bunch of different places still.

Hm, it doesn't seem valid.

Status: NEW → RESOLVED
Closed: 3 years ago
Flags: needinfo?(prathikshaprasadsuman)
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: