Closed Bug 1704871 Opened 4 years ago Closed 4 years ago

Allow initializing FOG from JS with a custom application id

Categories

(Toolkit :: Telemetry, task, P1)

task

Tracking

()

RESOLVED FIXED
89 Branch
Tracking Status
firefox89 --- fixed

People

(Reporter: chutten, Assigned: chutten)

References

Details

Attachments

(1 file)

For a consumer like the Background Task Runtime's individual background tasks, we need a JS-accessible FOG init function that can take a custom application id. Otherwise if and when it sends builtin pings they'll look as though they've come from Firefox Desktop itself.

This work could've been done in bug 1694505 but I scoped that bug too narrowly.

Note that, should a background task choose to use its own application id (which it should), it will need to file the appropriate bug to have itself added as a new application_id, and it should consider listing itself under Firefox Desktop's app_name so it appears as a "variant" in the same family.

Assignee: nobody → chutten
Status: NEW → ASSIGNED

(In reply to Chris H-C :chutten from comment #0)

Note that, should a background task choose to use its own application id (which it should), it will need to file the appropriate bug to have itself added as a new application_id, and it should consider listing itself under Firefox Desktop's app_name so it appears as a "variant" in the same family.

It's going to be another "channel" of Firefox Desktop then (because that's how we differentiate multiple variants under a single app name).
I think that's still fine though

Pushed by chutten@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/74e4f0d181f3 Add an optional application id override to FOG init r=janerik
Flags: needinfo?(chutten)

Well that's embarrassing.

This time I triple-checked that I linted, built, ran, and passed tests.

Flags: needinfo?(chutten)
Pushed by chutten@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d17549cef399 Add an optional application id override to FOG init r=janerik
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: