Closed Bug 1704879 Opened 4 years ago Closed 4 years ago

Add support for specifying a mouse button in XULMenuPopup.activateItem

Categories

(Core :: Widget: Cocoa, task)

Product:
Core
Component:
Widget: Cocoa
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox89 --- fixed
firefox90 --- fixed

People

(Reporter: mstange, Assigned: mstange)

References

Details

(Whiteboard: [proton-uplift])

Attachments

(2 files)

Bug 1704879 - Allow specifying the command event's button field in XULPopupElement.activateItem. r=emilio
(deleted), text/x-phabricator-request
Details
Bug 1704879 - Use activateItem in browser/components/extensions/test/browser/head.js even if a button is used. r=robwu
(deleted), text/x-phabricator-request
Details

Our WebExtension menu items have the ability to detect the mouse button that a context menu item was clicked with: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/menus/OnClickData

This was added in bug 1469148 and is only supported in Firefox.

We have a test for this at browser/components/extensions/test/browser/browser_ext_menus_capture_secondary_click.js.

I'd like to convert this test to use the activateItem API from bug 1704206, but at the moment, activateItem does not allow specifying the mouse button.

Depends on: 1704948
Assignee: nobody → mstange.moz
Status: NEW → ASSIGNED
Pushed by mstange@themasta.com: https://hg.mozilla.org/integration/autoland/rev/79945b876a1d Allow specifying the command event's button field in XULPopupElement.activateItem. r=emilio https://hg.mozilla.org/integration/autoland/rev/02705918c4bf Use activateItem in browser/components/extensions/test/browser/head.js even if a button is used. r=robwu

Backed out for conflicting with the backout of Bug 1704948

Flags: needinfo?(mstange.moz)
Blocks: 1705257
Pushed by mstange@themasta.com: https://hg.mozilla.org/integration/autoland/rev/033cbb106695 Allow specifying the command event's button field in XULPopupElement.activateItem. r=emilio https://hg.mozilla.org/integration/autoland/rev/c714e62ff3ea Use activateItem in browser/components/extensions/test/browser/head.js even if a button is used. r=robwu

https://hg.mozilla.org/mozilla-central/rev/033cbb106695
https://hg.mozilla.org/mozilla-central/rev/c714e62ff3ea

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
Flags: needinfo?(mstange.moz)
Whiteboard: [proton-uplift]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: