Closed Bug 1704880 Opened 4 years ago Closed 4 years ago

The Add/Edit bookmarks folder dialog doesn't have enough spacing between the folder name field and the buttons

Categories

(Toolkit Graveyard :: Notifications and Alerts, defect, P2)

Product:
Toolkit Graveyard
Component:
Notifications and Alerts
Platform:
Desktop
All
Type:
defect

Tracking

(firefox87 unaffected, firefox88 unaffected, firefox89 verified, firefox90 verified)

Status:
VERIFIED FIXED
Milestone:
89 Branch
Tracking Flags:
Tracking Status
firefox87 --- unaffected
firefox88 --- unaffected
firefox89 --- verified
firefox90 --- verified

People

(Reporter: marcela.calderon, Assigned: mtigley)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [proton-modals] [priority:2b])

Attachments

(1 file)

add_Edit bookmarks folder.png
(deleted), image/png
Details
Attached image add_Edit bookmarks folder.png (deleted) —

[Affected platfforms]:
Platforms: Windows 7

[Steps to reproduce]:

  1. Launch the Firefox browser.
  2. Perform right-click on Bookmarks toolbar and select "New folder"/"Edit folder"

[Expected result]
"Add Bookmarks folder" modal is displayed according to the new Proton design.

[Actual result]
"Add Bookmarks folder" modal has its buttons almost overlapping the text area

Blocks: proton-modals, 1694132
Severity: -- → S3
Has Regression Range: --- → no
Has STR: --- → yes
status-firefox87: --- → disabled
status-firefox88: --- → unaffected
Whiteboard: [proton-modals]

(In reply to Marcela from comment #0)

[Affected platfforms]:
Platforms: Windows 7

FWIW I can also reproduce on Windows 10 and macOS, so marking desktop/all. This may or may not end up being fixed in bug 1702249.

status-firefox87: disabled → unaffected
Depends on: 1702249
OS: Unspecified → All
Hardware: Unspecified → Desktop
Summary: The Add/Edit bookmarks folder has its buttons almost overlapping the text area → The Add/Edit bookmarks folder dialog doesn't have enough spacing between the folder name field and the buttons

(In reply to :Gijs (he/him) from comment #1)

FWIW I can also reproduce on Windows 10 and macOS, so marking desktop/all. This may or may not end up being fixed in bug 1702249.

Gijs, this should be fixed in Bug 1702293, which is currently in review.

Depends on: 1702293
No longer depends on: 1702249
Priority: -- → P2
Whiteboard: [proton-modals] → [proton-modals] [priority:2b]

Fixed by bug 1702293

Assignee: nobody → mtigley
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox89: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
Flags: qe-verify+

Reproducible on Nightly version 89.0a1 on Windows7, Windows10, MacOS 10.15, and Ubuntu 20. 64bit.
Verified fix on Nightly version 90.0a1 BuildID: 20210427221830. Checked on Windows7, Windows10, MacOS 10.15, and Ubuntu 20. 64bit.
I'll change flags accordingly.

Status: RESOLVED → VERIFIED
status-firefox89: fixed → verified
status-firefox90: --- → verified
Flags: qe-verify+
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: