Checkbox in modal dialogs (e.g. remove extension, content handling) shows a focus outline when the dialog is opened
Categories
(Toolkit Graveyard :: Notifications and Alerts, defect, P1)
Tracking
(firefox87 unaffected, firefox88 unaffected, firefox89 verified, firefox90 verified)
| Tracking | Status | |
|---|---|---|
| firefox87 | --- | unaffected |
| firefox88 | --- | unaffected |
| firefox89 | --- | verified |
| firefox90 | --- | verified |
People
(Reporter: clara.guerrero, Assigned: mconley)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [proton-modals] [priority:2a] [proton-uplift])
Attachments
(3 files)
|
(deleted),
image/png
|
Details | |
|
(deleted),
image/png
|
Details | |
|
(deleted),
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details |
Screen Shot 2021-04-13 at 12.21.38.png
Affected platforms:
Platforms: Mac OS11
Steps to reproduce
- Launch the Firefox browser.
- install any add-on (i.e. Privacy Badger)
- Right Click the Extension and Select Remove Extension from the Context menu.
Expected result
The Remove (Extension Name) from Firefox modal should be displayed according with the new Proton design.
Actual result
The "Report this extension to Mozilla" checkbox is highlighted by default , as if I had pressed tab key.
|
Reporter | |
Updated•4 years ago
|
|
|
Reporter | |
Updated•4 years ago
|
|
|
Reporter | |
Comment 1•4 years ago
|
||
I can also reproduce in the "Allow this site to open zoommtg link" modal.
|
||
Comment 2•4 years ago
|
||
Is this macOS-specific?
|
|
Reporter | |
Comment 3•4 years ago
|
||
Hi Gijs ,
The focus outline appearing in the remove extension modal is macOS-specific.
However, comment 1 happens in every OS (ubuntu and win as well)
Let me know if you need additional information.
Best,
Clara
|
||
Updated•4 years ago
|
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
||
Updated•4 years ago
|
|
|
||
Comment 4•4 years ago
|
||
Bernard: fwiw, there was some prior discussion in https://bugzilla.mozilla.org/show_bug.cgi?id=1706259#c3 , as well as in https://phabricator.services.mozilla.com/D110483 , and so this may not be straightforward.
|
|
||
Updated•4 years ago
|
|
Assignee | |
Comment 5•3 years ago
|
||
I'm not able to reproduce with the add-on removal case (comment 0) anymore on macOS. Are you, Clara?
|
|
Assignee | |
Comment 6•3 years ago
|
||
I can, however, reproduce with the permissionDialog.xhtml dialog on macOS.
|
|
Assignee | |
Comment 7•3 years ago
|
||
|
||
Updated•3 years ago
|
|
||
Comment 9•3 years ago
|
||
| bugherder | ||
|
||
Comment 10•3 years ago
|
||
Mike, could you request an uplift to beta as this is a p2a? Thanks
|
|
Assignee | |
Comment 11•3 years ago
|
||
Comment on attachment 9218461 [details]
Bug 1704882 - Prevent focus ring when automatically moving focus to first focusable element in a SubDialog. r?Gijs!
Beta/Release Uplift Approval Request
- User impact if declined: Required for MR1 / Proton
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): A simple, one-liner change that only affects subdialog focus rings.
- String changes made/needed: None.
|
|
||
Comment 12•3 years ago
|
||
Comment on attachment 9218461 [details]
Bug 1704882 - Prevent focus ring when automatically moving focus to first focusable element in a SubDialog. r?Gijs!
Approved for 89 beta 6, thanks.
|
|
||
Updated•3 years ago
|
|
|
||
Comment 13•3 years ago
|
||
| bugherder uplift | ||
|
||
Comment 14•3 years ago
|
||
This issue is verified as fixed in our latest 89.0b7 and our latest Nightly build 90.0a1 (2021-05-04) on Mac 11.
Also tested the scenario from Comment 1 with the Zoom link and that issue no longer occurs either. I will update the flags.
|
|
Reporter | |
Updated•3 years ago
|
|
||
Updated•1 year ago
|
Description
•