Closed
Bug 1705188
Opened 4 years ago
Closed 3 years ago
Get rid of browser CSS that sets popupnotification icons
Categories
(Firefox :: Theme, task, P3)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
100 Branch
| Tracking | Status | |
|---|---|---|
| firefox100 | --- | fixed |
People
(Reporter: mconley, Assigned: bigiri)
References
(Blocks 1 open bug)
Details
(Whiteboard: [proton-cleanups])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
With Proton, we don't show icons in popupnotification panels unless the caller explicitly requests it at opening time. We should get rid of the old CSS rules that set the icons that we don't show anymore.
These are the ones I found at a glance:
|
||
Updated•4 years ago
|
See Also: → https://jira.mozilla.com/browse/FIDEFE-1211
|
||
Updated•4 years ago
|
Priority: -- → P3
|
||
Updated•3 years ago
|
Points: --- → 2
|
Assignee | |
Updated•3 years ago
|
Assignee: nobody → bigiri
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•3 years ago
|
||
Removed CSS referencing .popup-notification-icon[...]
Pushed by bigiri@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a78b962181ae
Removed orphaned CSS for popupnotification icons r=dao
Backout by abutkovits@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8a19793edb70
Backed out changeset a78b962181ae for causing failures at browser_all_files_referenced.js.
|
||
Comment 4•3 years ago
|
||
Backed out for causing failures at browser_all_files_referenced.js.
backout link: https://hg.mozilla.org/integration/autoland/rev/8a19793edb70bd9ecca93d7baef072013bde48d9
Failure log: https://treeherder.mozilla.org/logviewer?job_id=371587382&repo=autoland&lineNumber=2487
Flags: needinfo?(bigiri)
|
||
Updated•3 years ago
|
Attachment #9268278 -
Attachment description: Bug 1705188 - Removed orphaned CSS for popupnotification icons r=Dao! → WIP: Bug 1705188 - Removed orphaned CSS for popupnotification icons r=Dao!
|
|
||
Updated•3 years ago
|
Attachment #9268278 -
Attachment description: WIP: Bug 1705188 - Removed orphaned CSS for popupnotification icons r=Dao! → Bug 1705188 - Removed orphaned CSS for popupnotification icons r=Dao!
|
|
Assignee | |
Comment 5•3 years ago
|
||
The images addon-install-error.svg and addon-install-warning.svg were orphaned by these changes. My new patch removes them.
Flags: needinfo?(bigiri)
Pushed by bigiri@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/10fed540fa34
Removed orphaned CSS for popupnotification icons r=dao
|
||
Comment 7•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox100:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•