Open Bug 1705440 Opened 4 years ago Updated 1 year ago

Clean up all the modal prefs and old implementations after proton ships

Categories

(Toolkit :: Content Prompts, defect, P3)

Product:
Toolkit
Component:
Content Prompts
Platform:
Desktop
All
Type:
defect
Points:
2

Tracking

()

Tracking Flags:
Tracking Status
firefox89 --- affected

People

(Reporter: Gijs, Unassigned)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [proton-cleanups])

Once we ship, we should remove the prompts.{tab,content,window}PromptSubDialog prefs, and the tabmodalprompt implementation which will be unused, and clean up all the remaining tests specific to the old implementation(s).

Priority: -- → P3
Points: --- → 2

(In reply to :Gijs (he/him) from comment #0)

the tabmodalprompt implementation which will be unused, and clean up all the remaining tests specific to the old implementation(s).

It looks like at least from bug 1702059 we're still using the tabmodalprompt implementation in about:addons, and we'd have to either fix that or keep the old stuff around, I guess... I don't know off-hand how hard it would be to move those consumers over to the new framework.

Severity: -- → S3
Component: Notifications and Alerts → Content Prompts

Maybe of interest to you, Greg.

Duplicate of this bug: 1849543
You need to log in before you can comment on or make changes to this bug.