Closed Bug 1705539 Opened 4 years ago Closed 4 years ago

Move browser-specific panel adjustments out of toolkit popup.css style sheets

Categories

(Firefox :: Theme, task, P3)

Product:
Firefox
Component:
Theme
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox89 --- fixed
firefox90 --- fixed

People

(Reporter: mconley, Assigned: emmamalysz)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-cleanups][proton-uplift])

Attachments

(1 file)

Bug 1705539, move panel rules out of toolkit style sheets and into browser.css
(deleted), text/x-phabricator-request
pascalc
: approval-mozilla-beta+
Details

Bug 1695702 added some rules to reposition some browser panels, and those rules ended up in toolkit/themes/<OS>/global/popup.css - example:

https://searchfox.org/mozilla-central/rev/5e70cd673a0ba0ad19b662c1cf656e0823781596/toolkit/themes/windows/global/popup.css#84-135

We should really move those browser-specific things out of toolkit and into something like browser/themes/<OS>/browser.css.

Blocks: 1704242
Assignee: nobody → emalysz
No longer blocks: 1704242
Status: NEW → ASSIGNED
Blocks: 1704242
Priority: -- → P3
Pushed by emalysz@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e01c0e9746b6 move panel rules out of toolkit style sheets and into browser.css r=Gijs

https://hg.mozilla.org/mozilla-central/rev/e01c0e9746b6

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch

Comment on attachment 9216445 [details]
Bug 1705539, move panel rules out of toolkit style sheets and into browser.css

Beta/Release Uplift Approval Request

  • User impact if declined: Required for MR1 / Proton
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Cleanup work for MR1 that didn't make the uplift.
  • String changes made/needed: n/a
Attachment #9216445 - Flags: approval-mozilla-beta?
Whiteboard: [proton-cleanups] → [proton-cleanups][proton-uplift]

Comment on attachment 9216445 [details]
Bug 1705539, move panel rules out of toolkit style sheets and into browser.css

Approved for beta, thanks

Attachment #9216445 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Regressions: 1734835
No longer regressions: 1734835
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: