Closed Bug 1705814 Opened 4 years ago Closed 4 years ago

PROTON: Search bar missing 2 borders in Contrast Mode

Categories

(Firefox :: Search, defect, P2)

Desktop
Windows 10
defect

Tracking

()

VERIFIED FIXED
89 Branch
Tracking Status
firefox87 --- unaffected
firefox88 --- disabled
firefox89 --- verified
firefox90 --- verified

People

(Reporter: muirpablo, Unassigned)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [proton-address-bar] [priority:2a])

Attachments

(1 file)

Attached image highcontrast.png (deleted) —

Affected platforms
Ubuntu 20 64bit is not affected
Mac OSX 10.14 is not affected
Windows 10 64bit affected

version
Fx89.0a1 affected

Preconditions
-Have high contrast mode enabled (winsows10 OS high contrast mode)
-proton On, (its on by default in nightly)

Steps to reproduce
-Launch Firefox nightly (proton is enabled by default)
-enable the search bar. in about:preferences#search
-type some words in search bar

Expected result
Borders should be visible on all sides

Actual result
Border is visible in only 1 side.

Severity: -- → S4
Whiteboard: [proton-address-bar]

Hi romain, could you please set a priority for bug?
thanks!

Flags: needinfo?(rtestard)
Summary: Search bar missing 2 borders in Contrast Mode → PROTON: Search bar missing 2 borders in Contrast Mode

From my initial investigation this is due to some rounding issues with -moz-window-shadow, for which we may decide to remove the rounded border and -moz-window-shadow for prefers-contrast

Flags: needinfo?(rtestard)
Priority: -- → P2
Whiteboard: [proton-address-bar] → [proton-address-bar] [priority:2a]

Neil, any idea why -moz-window-shadow and rounded border may cause this pixel-rounding problem? could this be a widget/layout/graphics bug?
Here the panel has a 1px solid border

Flags: needinfo?(enndeakin)
Priority: P2 → P1
Priority: P1 → P2

Looks to be fixed by bug 1704040.

Blocks: 1704040
Status: NEW → RESOLVED
Closed: 4 years ago
Flags: needinfo?(enndeakin)
Resolution: --- → FIXED

yes, I can confirmed I don't see the bug anymore. Thank you!

Fixed in bug 1704040, which landed in 90 and uplifted to 89.

Target Milestone: --- → 89 Branch

verified fix on windows10 64bit, ubuntu 20 and MacOs 10.14 using firefox nightly 90.0a1 and Beta 89.0b7

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: