Closed
Bug 1706096
Opened 4 years ago
Closed 3 years ago
Update media and Picture in Picture icons (PiP)
Categories
(Firefox :: Theme, enhancement, P2)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
90 Branch
People
(Reporter: sfoster, Assigned: mconley)
References
(Blocks 1 open bug)
Details
(Whiteboard: [proton-icons] [priority:2a] [proton-uplift])
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details |
We have new icons for use in Picture in Picture. Please see the procedure doc which has details on where to find the new icons, how to put together the patch and verify the result.
Updated•4 years ago
|
See Also: → https://jira.mozilla.com/browse/FIDEFE-1291
Assignee | ||
Updated•4 years ago
|
Assignee: nobody → mconley
Assignee | ||
Comment 1•4 years ago
|
||
Since I'm pretty familiar with these, I'm going to try to de-duplicate them against their toolkit/themes/shared/media counterparts while I'm at it.
Summary: Update Picture in Picture icons (PiP) → Update media and Picture in Picture icons (PiP)
Assignee | ||
Comment 2•4 years ago
|
||
Updated•4 years ago
|
Priority: -- → P2
Whiteboard: [proton-icons] → [proton-icons] [priority:2a]
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6f85c555febf
Update media and Picture-in-Picture icons. r=sfoster,desktop-theme-reviewers,harry
Comment 5•4 years ago
|
||
Backed out for android build bustages and bc failures
Failure log:
- Bustage: https://treeherder.mozilla.org/logviewer?job_id=337512488&repo=autoland&lineNumber=47240
- bc failure: https://treeherder.mozilla.org/logviewer?job_id=337517371&repo=autoland&lineNumber=2333
- linting failure: https://treeherder.mozilla.org/logviewer?job_id=337514867&repo=autoland&lineNumber=908
Backout: https://hg.mozilla.org/integration/autoland/rev/5b00d3dd7af27193b42a9cdd45ec887fb84be199
Flags: needinfo?(mconley)
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/695c41f2ed25
Update media and Picture-in-Picture icons. r=sfoster,desktop-theme-reviewers,harry
Assignee | ||
Updated•3 years ago
|
Flags: needinfo?(mconley)
Comment 8•3 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox90:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
Assignee | ||
Comment 9•3 years ago
|
||
Comment on attachment 9217437 [details]
Bug 1706096 - Update media and Picture-in-Picture icons. r?sfoster!
Beta/Release Uplift Approval Request
- User impact if declined: Required for MR1 / Proton
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Asset swap for new Proton icons.
- String changes made/needed: None.
Attachment #9217437 -
Flags: approval-mozilla-beta?
Updated•3 years ago
|
status-firefox89:
--- → affected
Whiteboard: [proton-icons] [priority:2a] → [proton-icons] [priority:2a] [proton-uplift]
Comment 10•3 years ago
|
||
Comment on attachment 9217437 [details]
Bug 1706096 - Update media and Picture-in-Picture icons. r?sfoster!
Approved for 89 beta 6, thanks.
Attachment #9217437 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 11•3 years ago
|
||
bugherder uplift |
You need to log in
before you can comment on or make changes to this bug.
Description
•