Closed Bug 1706112 Opened 4 years ago Closed 4 years ago

The closed Urlbar doesn't have a border when clicking a search tip

Categories

(Firefox :: Address Bar, defect, P2)

Product:
Firefox
Component:
Address Bar
Type:
defect
Points:
2

Tracking

()

Status:
VERIFIED FIXED
Milestone:
90 Branch
Iteration:
90.1 - Apr 19 - May 2
Tracking Flags:
Tracking Status
firefox89 --- verified
firefox90 --- verified

People

(Reporter: bugzilla, Assigned: daisuke)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-address-bar] [proton-uplift])

Attachments

(2 files)

Urlbar after clicking search tip
(deleted), image/png
Details
Bug 1706112: Remove suppress-focus-borde when clicking a search tip.r?harry!
(deleted), text/x-phabricator-request
pascalc
: approval-mozilla-beta+
Details
Attached image Urlbar after clicking search tip (deleted) —

STR:

  1. Set browser.urlbar.searchTips.test.ignoreShowLimits to true to make this easier to reproduce. The bug also reproduces when Search Tips are shown normally.
  2. Open a new tab or navigate to your search engine's home page (e.g. google.com).
  3. Observe that the Urlbar shows a Search Tip.
  4. Click the Urlbar input or the "Okay, Got It" button on the Search Tip.

Expected: The Urlbar is closed, focused and has a border.

Actual: The Urlbar is closed, focused, and does not have a border.

We probably need special suppress-focus-border behaviour around Search Tips.

Assignee: nobody → daisuke
Status: NEW → ASSIGNED
Iteration: --- → 90.1 - Apr 19 - May 2
Points: --- → 2
Whiteboard: [proton-address-bar]
Pushed by dakatsuka.birchill@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e4a2e8083239 Remove suppress-focus-borde when clicking a search tip.r=harry

https://hg.mozilla.org/mozilla-central/rev/e4a2e8083239

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
Whiteboard: [proton-address-bar] → [proton-address-bar] [proton-uplift]

Comment on attachment 9216969 [details]
Bug 1706112: Remove suppress-focus-borde when clicking a search tip.r?harry!

Uplift dependency for bug 1700374

Attachment #9216969 - Flags: approval-mozilla-beta+

verified fix on windows10 64bit, ubuntu 20 and MacOs 10.14 using firefox nightly 90.0a1 and Beta 89.0b7

Status: RESOLVED → VERIFIED
status-firefox89: fixed → verified
status-firefox90: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: