Closed
Bug 170615
Opened 22 years ago
Closed 20 years ago
eliminate use of nsAutoString in parser attribute token
Categories
(Core :: DOM: HTML Parser, defect, P3)
Core
DOM: HTML Parser
Tracking
()
RESOLVED
FIXED
mozilla1.4beta
People
(Reporter: cathleennscp, Assigned: harishd)
References
Details
(Keywords: memory-footprint)
Attachments
(1 file)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.0.1) Gecko/20020823 Netscape/7.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.0.1) Gecko/20020823 Netscape/7.0
to reduce the size of attribute token for footprint improvement.
Reproducible: Always
Steps to Reproduce:
1.
2.
3.
This patch should reduce the attribute token size by ~100 bytes. Basically,
I've replaced the nsAutoString, for mTextValue, with nsSlidingSubstring and
nsString.
The idea is to use nsString for attribute values that contain entities ( which,
AFAIK, is way less compared to attribute values without entities ) and for the
rest use nsSlidingSubstring ( eliminates string copy! ).
Severity: normal → major
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Priority: -- → P1
|
||
Comment 2•21 years ago
|
||
Comment on attachment 100484 [details] [diff] [review]
patch v1.0 [ reduce attr token size and removed unused code ]
Asking for reviews
Attachment #100484 -
Flags: superreview?(dbaron)
Attachment #100484 -
Flags: review?(bz-vacation)
|
||
Comment 3•21 years ago
|
||
This is pretty big... I'm not likely to get to it before 1.7a. :(
|
|
||
Comment 4•21 years ago
|
||
Comment on attachment 100484 [details] [diff] [review]
patch v1.0 [ reduce attr token size and removed unused code ]
The patch does no longer apply and with darin's string changes the whole patch
probably needs to be redone.
Attachment #100484 -
Flags: superreview?(dbaron)
Attachment #100484 -
Flags: review?(bzbarsky)
|
||
Comment 5•20 years ago
|
||
This was fixed by the checkin to bug 269853, marking FIXED.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•