Currently, increasefontsize, decreasefontsize, gethtml, heading,
contentReadOnly, readonly and insertBrOnReturn commands are supported
only by Gecko. So, if nobody uses some or all of them, we can drop the
unused commands.

For saving the space of Document.mUseCounters, this patch groups
Document.queryCommandState and Document.queryCommandValue because they
are both getter of the command. The difference is not important. And also
this patch groups Document.queryCommandSupported and
Document.queryCommandEnabled because they may be used for feature detection
and the difference is not important.

Comment on attachment 9229506 [details]
Data review

Sorry for the delay in this, I was on PTO and didn't update BMO to reflect this. For future reference, if you do not receive any response within a couple of business days from a steward, you are welcome to ping in the #data-stewards channel on matrix or select another steward.

A couple of questions/requests before I can proceed with the data-review:

1. Could you please provide answers for which populations you will be measuring, or all channels if that is the case?

2. Could you please elaborate on how the spec of the use counters determines default-on/off? (I would expect that this would be "default-on" but only counted if the command was accessed, but I want to be sure I understand.)

Again, sorry for any hold-up on this and happy to expedite this once the above questions are resolved.

• Travis

(In reply to Travis Long [:travis_] from comment #3)

Sorry for the delay in this, I was on PTO and didn't update BMO to reflect this. For future reference, if you do not receive any response within a couple of business days from a steward, you are welcome to ping in the #data-stewards channel on matrix or select another steward.

No problem, and thank you for the information.

A couple of questions/requests before I can proceed with the data-review:

1. Could you please provide answers for which populations you will be measuring, or all channels if that is the case?

I think that use counter collects in all channels.

As of Firefox 65 the collection of Use Counters is enabled on all channels.
https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/collection/use-counters.html#use-counters

2. Could you please elaborate on how the spec of the use counters determines default-on/off? (I would expect that this would be "default-on" but only counted if the command was accessed, but I want to be sure I understand.)

I don't find any documents, but here is the code:
https://searchfox.org/mozilla-central/rev/b79212b4fc017f27ac2435a658d4e9b9798efa86/toolkit/components/telemetry/build_scripts/mozparsers/parse_histograms.py#149,151
(And I guess that if it's default-off, we don't get meaningful result for this purpose.)

Thank you for the additional info, I will proceed with the review

Comment on attachment 9229506 [details]
Data review

Data Review

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, in the UserCounters.conf and through the Probe Dictionary

2. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, through the standard telemetry preference

3. If the request is for permanent data collection, is there someone who will monitor the data over time?

Masayuki Nakano will be responsible for the permanent collection of this metric

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, User Interaction

5. Is the data collection request for default-on or default-off?

Default-off

6. Does the instrumentation include the addition of any new identifiers?

No

7. Is the data collection covered by the existing Firefox privacy notice?

Yes

8. Does the data collection use a third-party collection tool?

No

Result

data-review+

Thank you!

https://hg.mozilla.org/mozilla-central/rev/dbe091049245