Bookmark star icon uses OS color making it less noticable
Categories
(Firefox :: Address Bar, defect, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr78 | --- | unaffected |
firefox88 | --- | unaffected |
firefox89 | --- | wontfix |
firefox90 | --- | fix-optional |
firefox91 | --- | fix-optional |
People
(Reporter: evilpie, Unassigned)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: regression, Whiteboard: [proton-address-bar] [priority:2b])
Attachments
(3 files)
It seems like Firefox recently started using some OS theme color for the bookmark icon when a page is bookmarked. For me that color doesn't seem appropriate as it's quite low contrast? (sorry I am not great with color terms)
Reporter | ||
Comment 1•4 years ago
|
||
Reporter | ||
Updated•4 years ago
|
Updated•4 years ago
|
Comment 2•4 years ago
|
||
I assume this is Linux, on other platforms we don't use the system accent. I think this is a recent change, if you can find the bug that made it, it would be very useful.
Reporter | ||
Comment 3•4 years ago
|
||
Yeah this on Linux. This was apparently changed by bug 1705741. However while bisecting this I noticed that we used some out-of-place cyan color before, so this is at least better and maybe shouldn't be changed.
Updated•4 years ago
|
Comment 4•4 years ago
|
||
Curious, which GTK theme is this? Maybe we can increase the contrast of the accent color a bit.
Comment 5•4 years ago
|
||
(I thought it was Yaru-mate, but it's not, or at least I get a darker color using that theme)
Reporter | ||
Comment 6•4 years ago
|
||
This is Mint-Y-Dark on Linux Mint Cinnamon.
Comment 7•4 years ago
|
||
Set release status flags based on info from the regressing bug 1705741
Updated•4 years ago
|
Updated•4 years ago
|
Reporter | ||
Comment 8•4 years ago
|
||
I think the problem is actually worse with the download icon indicating that a download finished.
Comment 9•4 years ago
|
||
NIing Asa here to help understand if we should adjust the contrast for accent color on Linux.
Updated•4 years ago
|
Comment 10•4 years ago
|
||
I think given the rendering of the other GTK widgets using this theme this is fine, tbh. I looked at the relevant GTK theme and here are the colors it defines:
@define-color theme_fg_color #DADADA;
@define-color theme_text_color #DADADA;
@define-color theme_bg_color #383838;
@define-color theme_base_color #404040;
@define-color theme_selected_bg_color #8fa876;
@define-color theme_selected_fg_color #ffffff;
@define-color fg_color #DADADA;
@define-color text_color #DADADA;
@define-color bg_color #383838;
@define-color base_color #404040;
@define-color selected_bg_color #8fa876;
@define-color selected_fg_color #ffffff;
@define-color insensitive_bg_color #3d3d3d;
@define-color insensitive_fg_color alpha(#dadada, 0.5);
@define-color insensitive_base_color #404040;
@define-color theme_unfocused_fg_color #DADADA;
@define-color theme_unfocused_text_color #DADADA;
@define-color theme_unfocused_bg_color #383838;
@define-color theme_unfocused_base_color #404040;
@define-color borders #292929;
@define-color unfocused_borders #292929;
@define-color warning_color #f27835;
@define-color error_color #FC4138;
@define-color success_color #73d216;
@define-color placeholder_text_color #A8A8A8;
@define-color content_view_bg #404040;
@define-color wm_title #DADADA;
@define-color wm_unfocused_title alpha(#ded6d6, 0.5);
@define-color wm_bg #2f2f2f;
@define-color wm_bg_unfocused #333333;
@define-color wm_highlight #373737;
@define-color wm_shadow alpha(black, 0.35);
@define-color wm_button_close_bg #cc575d;
@define-color wm_button_close_hover_bg #d7787d;
@define-color wm_button_close_active_bg #be3841;
@define-color wm_icon_close_bg #2f343f;
@define-color wm_button_hover_bg #454C5C;
@define-color wm_button_active_bg #8fa876;
@define-color wm_button_hover_border #262932;
@define-color wm_icon_bg #90939B;
@define-color wm_icon_unfocused_bg #666A74;
@define-color wm_icon_hover_bg #C4C7CC;
@define-color wm_icon_active_bg #ffffff;
At a glance I don't se any color that we could use from there that has more contrast. We could lighten it up a bit with something like color-mix(in srgb, -moz-accent-color 100%, white 10%)
or such, but that's just going to make other themes look weird so I'd rather not.
Updated•4 years ago
|
Updated•3 years ago
|
Comment 11•3 years ago
|
||
I don't believe this is an accessibility issue. The contrast of the icon color is sufficient against its background color for meeting accessibility guidelines. It does appear to be a general usability regression though.
Updated•3 years ago
|
Comment 12•3 years ago
|
||
checked the issue today on nightly run on ubuntu 20 64bit with latest nightly 92.0a1
star in urlbar, star in search suggestions and star in one-offs area is orange.
Updated•3 years ago
|
Description
•