Closed Bug 1706816 Opened 4 years ago Closed 4 years ago

Close open native menus when another native menu wants to open

Categories

(Core :: Widget: Cocoa, task)

Product:
Core
Component:
Widget: Cocoa
Platform:
All
macOS
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox89 --- fixed
firefox90 --- fixed

People

(Reporter: mstange, Assigned: mstange)

References

Details

(Whiteboard: [proton-uplift])

Attachments

(1 file)

Bug 1706816 - If we're asked to open a native menu when another menu is already open, close the other menu first. r=tnikkel
(deleted), text/x-phabricator-request
Details

Bug 1701843 just added a test which first opens a context menu inside about:config, and then a context menu on a bookmark. It doesn't close the first menu before the second.

Native context menus currently fail that test because the first menu isn't closed properly.

We can close the first menu automatically if we encounter this situation.

This situation is extremely unlikely to arise in regular Firefox usage: If the user right-clicks something else while a context menu is open, macOS closes the old context menu first, and then it tells us about the right click.

Pushed by mstange@themasta.com: https://hg.mozilla.org/integration/autoland/rev/aca9e268a4cd If we're asked to open a native menu when another menu is already open, close the other menu first. r=harry

https://hg.mozilla.org/mozilla-central/rev/aca9e268a4cd

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
Whiteboard: [proton-uplift]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: