Closed
Bug 1706915
Opened 4 years ago
Closed 3 years ago
Check that all commented-out code has been addressed
Categories
(Core :: WebRTC, task, P2)
Core
WebRTC
Tracking
()
RESOLVED
FIXED
People
(Reporter: ng, Assigned: mjf)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/plain
|
Details |
Go through dminor’s patches to see that all code that was commented out has been handled and fixed.
Reporter | ||
Updated•4 years ago
|
Severity: -- → S3
Priority: -- → P2
Assignee | ||
Updated•3 years ago
|
Assignee: nobody → mfroman
Assignee | ||
Comment 1•3 years ago
|
||
Attaching my analysis of dminor's patches in Bug 1654112. I found 3 patches that need follow-up bugs filed. I will add see-also bugs here.
ef548d7758c7 - Disable creating av1 encoder and decoder
check third_party/libwebrtc/media/engine/internal_decoder_factory.cc
commented out kIsLibaomAv1DecoderSupported - xxxx needs cleanup xxxx -
third_party/libwebrtc/media/engine/internal_encoder_factory.cc
commented out kIsLibaomAv1EncoderSupported - xxxx needs cleanup xxxx -
127ace4d8887 - Tweak upstream gn files for Firefox build
look for commented or "if (false)" in all the BUILD.gn files and make these changes upstreamable by putting the changes behind 'build_with_mozilla'
check third_party/libwebrtc/BUILD.gn
look for #"api:create_peerconnection_factory"
third_party/libwebrtc/api/video/BUILD.gn
look for #"//third_party/libyuv"
third_party/libwebrtc/build/config/BUILD.gn
look for #if (use_custom_libcxx) {
third_party/libwebrtc/build/config/compiler/BUILD.gn
look for #import("//build/config/gclient_args.gni")
third_party/libwebrtc/build/config/sysroot.gni
look for #assert(
# exec_script("//build/dir_exists.py",
third_party/libwebrtc/build/toolchain/linux/BUILD.gn
look for #gcc_toolchain("mips64") {
third_party/libwebrtc/call/BUILD.gn
look for #"../api:libjingle_peerconnection_api"
third_party/libwebrtc/common_video/BUILD.gn
look for #"//third_party/libyuv"
third_party/libwebrtc/media/BUILD.gn
look for #"../api/transport:stun_types"
#"base/adapted_video_track_source.cc",
#"base/adapted_video_track_source.h",
#"base/audio_source.h",
#"base/delayable.h",
#"base/media_channel.cc",
#"base/media_channel.h",
#"base/media_engine.cc",
#"base/media_engine.h",
#"base/rid_description.cc",
#"base/rid_description.h",
#"base/rtp_data_engine.cc",
#"base/rtp_data_engine.h",
#"base/rtp_utils.cc",
#"base/rtp_utils.h",
#"base/stream_params.cc",
#"base/stream_params.h",
#"base/turn_utils.cc",
#"base/turn_utils.h",
#"../modules/video_coding/codecs/av1:libaom_av1_decoder",
#"../modules/video_coding/codecs/av1:libaom_av1_encoder",
#"../test:fake_video_codecs",
#"engine/fake_video_codec_factory.cc",
#"engine/fake_video_codec_factory.h",
#"../api:libjingle_peerconnection_api",
#":rtc_data",
third_party/libwebrtc/modules/audio_device/BUILD.gn
look for #"include/test_audio_device.cc",
#"include/test_audio_device.h",
third_party/libwebrtc/modules/desktop_capture/BUILD.gn
look for #import("//tools/generate_stubs/rules.gni")
#pkg_config("gio") {
#pkg_config("pipewire") {
#generate_stubs("pipewire_stubs") {
#":pipewire_config",
#":gio",
#configs += [ ":pipewire" ]
#deps += [ ":pipewire_stubs" ]
third_party/libwebrtc/modules/rtp_rtcp/BUILD.gn
look for #"../../api:libjingle_peerconnection_api"
third_party/libwebrtc/modules/video_capture/BUILD.gn
look for #"//third_party/libyuv"
third_party/libwebrtc/modules/video_coding/BUILD.gn
look for #import("//third_party/libaom/options.gni")
#"//third_party/libyuv"
third_party/libwebrtc/modules/video_coding/codecs/av1/BUILD.gn
look for #import("//third_party/libaom/options.gni")
#"//third_party/libaom",
#"//third_party/libyuv",
third_party/libwebrtc/modules/video_processing/BUILD.gn
look for #"//third_party/libyuv"
third_party/libwebrtc/rtc_base/BUILD.gn
look for +if (false) {
+ rtc_library("rtc_json") {
#"async_invoker.cc",
#"async_invoker.h",
#"async_invoker_inl.h",
#"async_packet_socket.cc",
#"async_packet_socket.h",
#"async_tcp_socket.cc",
#"async_tcp_socket.h",
#"async_udp_socket.cc",
#"async_udp_socket.h",
#"deprecated/signal_thread.cc",
#"deprecated/signal_thread.h",
#"helpers.cc",
#"helpers.h",
#"http_common.cc",
#"http_common.h",
#"mdns_responder_interface.h",
#"message_digest.cc",
#"message_digest.h",
#"net_helper.cc",
#"net_helper.h",
#"network.cc",
#"network.h",
#"network_monitor.cc",
#"network_monitor.h",
#"network_monitor_factory.cc",
#"network_monitor_factory.h",
#"openssl.h",
#"openssl_adapter.cc",
#"openssl_adapter.h",
#"openssl_certificate.cc",
#"openssl_certificate.h",
#"openssl_digest.cc",
#"openssl_digest.h",
#"openssl_identity.cc",
#"openssl_identity.h",
#"openssl_session_cache.cc",
#"openssl_session_cache.h",
#"openssl_stream_adapter.cc",
#"openssl_stream_adapter.h",
#"openssl_utility.cc",
#"openssl_utility.h",
#"proxy_info.cc",
#"proxy_info.h",
#"rtc_certificate.cc",
#"rtc_certificate.h",
#"rtc_certificate_generator.cc",
#"rtc_certificate_generator.h",
#"signal_thread.h",
#"socket.cc",
#"socket.h",
#"socket_adapters.cc",
#"socket_adapters.h",
#"socket_address_pair.cc",
#"socket_address_pair.h",
#"socket_factory.h",
#"ssl_adapter.cc",
#"ssl_adapter.h",
#"ssl_certificate.cc",
#"ssl_certificate.h",
#"ssl_fingerprint.cc",
#"ssl_fingerprint.h",
#"ssl_identity.cc",
#"ssl_identity.h",
#"ssl_stream_adapter.cc",
#"ssl_stream_adapter.h",
#"thread_message.h",
#"unique_id_generator.cc",
#"unique_id_generator.h",
#if (is_posix || is_fuchsia) {
third_party/libwebrtc/test/BUILD.gn
look for +if (false) {
+ group("test") {
#testonly = true
#"rtcp_packet_parser.cc",
#"rtcp_packet_parser.h",
#"rtp_file_reader.cc",
#"rtp_file_reader.h",
#"rtp_file_writer.cc",
#"rtp_file_writer.h",
+if (false) {
+ rtc_library("field_trial") {
third_party/libwebrtc/third_party/abseil-cpp/BUILD.gn
look for +#import("//testing/test.gni")
if (false) {
test("absl_tests") {
third_party/libwebrtc/third_party/abseil-cpp/absl/algorithm/BUILD.gn
look for +if (false) {
+ absl_source_set("algorithm_test") {
third_party/libwebrtc/third_party/abseil-cpp/absl/base/BUILD.gn
look for +if (false) {
+ absl_source_set("spinlock_test_common") {
+if (false) {
+ absl_source_set("config_test") {
third_party/libwebrtc/third_party/abseil-cpp/absl/container/BUILD.gn
look for +if (false) {
+ absl_source_set("unordered_map_constructor_test") {
+if (false) {
+ absl_source_set("inlined_vector_test") {
third_party/libwebrtc/third_party/abseil-cpp/absl/hash/BUILD.gn
look for +if (false) {
+ absl_source_set("hash_testing") {
third_party/libwebrtc/third_party/abseil-cpp/absl/memory/BUILD.gn
look for +if (false) {
+ absl_source_set("memory_test") {
third_party/libwebrtc/third_party/abseil-cpp/absl/meta/BUILD.gn
look for +if (false) {
+ absl_source_set("type_traits_test") {
third_party/libwebrtc/third_party/abseil-cpp/absl/strings/BUILD.gn
look for +if (false) {
+ absl_source_set("ascii_test") {
third_party/libwebrtc/third_party/abseil-cpp/absl/synchronization/BUILD.gn
look for +if (false) {
+ absl_source_set("per_thread_sem_test_common") {
third_party/libwebrtc/third_party/abseil-cpp/absl/time/BUILD.gn
look for +if (false) {
+ absl_source_set("test_util") {
third_party/libwebrtc/third_party/abseil-cpp/absl/types/BUILD.gn
look for +if (false) {
+ absl_source_set("optional_test") {
third_party/libwebrtc/third_party/pffft/BUILD.gn
look for +#import("//testing/libfuzzer/fuzzer_test.gni")
+#import("//testing/test.gni")
+if (false) {
+ group("fuzzers") {
third_party/libwebrtc/third_party/rnnoise/BUILD.gn
look for +#import("//testing/test.gni")
third_party/libwebrtc/video/BUILD.gn
look for #"../api:libjingle_peerconnection_api"
0dc6c152d8c6 - Update WebRTC MediaDataCodec
check dom/media/webrtc/libwebrtcglue/WebrtcMediaDataEncoderCodec.h
GetFragHeader commented out
- xxxx needs cleanup xxxx - bde976e055f2 deleted commented out code
in cpp file, but not in header
Assignee | ||
Comment 2•3 years ago
|
||
Bugs to track these fixes are Bug 1744644, Bug 1744645, Bug 1744646. This bug can now be closed since the analysis work is complete.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•