Open Bug 1706955 Opened 3 years ago Updated 3 years ago

About profiles - Highlight focus on Open Folder button cuts off slightly the text to its left

Categories

(Toolkit :: Startup and Profile System, defect)

defect

Tracking

()

Tracking Status
firefox-esr78 --- wontfix
firefox88 --- wontfix
firefox89 --- fix-optional
firefox90 --- fix-optional

People

(Reporter: asoncutean, Unassigned, NeedInfo)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Attached image screenshoot issue.png (deleted) —

Affected versions

  • 88.0
  • 89.0b2
  • 90.0a1 (2021-04-21)

Affected platforms

  • Windows 10
  • Ubuntu 20

Steps to reproduce

  1. Open about:profiles
  2. Navigate the page using the Tab key until the Open Folder button is reached

Expected result

  • There is a minimum space between the button's highlight focus and the text

Actual result

  • The highlight focus and the text are slightly overlapped

Regression range

Has Regression Range: --- → yes
Has STR: --- → yes

Bug 1511394 looks like the likely candidate.

Flags: needinfo?(matthias)
Flags: needinfo?(dao+bmo)
Regressed by: 1511394

I agree, this was probably introduced by my commit.
However I think that the correct way to fix this would be to increase the margin-inline-start in .opendir of aboutProfiles.css to not deviate from the photon spec?

Flags: needinfo?(matthias)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: