Closed Bug 1706973 Opened 4 years ago Closed 3 years ago

The tab selection border for primary password 'Learn More' link is too big

Categories

(Firefox :: Theme, defect)

Product:
Firefox
Component:
Theme
Platform:
Desktop
All
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
91 Branch
Tracking Flags:
Tracking Status
firefox88 --- wontfix
firefox89 --- wontfix
firefox90 --- wontfix
firefox91 --- verified
firefox92 --- verified

People

(Reporter: cbaica, Assigned: pyjacpp)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

learn more tab selection border
(deleted), image/png
Details
Bug 1706973 - Fix learn more button too wide. r?#desktop-theme-reviewers
(deleted), text/x-phabricator-request
Details
Attached image learn more tab selection border (deleted) —

Affected versions

  • Fx89.0b2
  • Fx90.0a1

Affected platforms

  • Windows 10
  • Ubuntu 18.04
  • macOS 11

Steps to reproduce

  1. Launch Firefox.
  2. Navigate to about:preferences#privacy.
  3. Scroll down to the logins and passwords.
  4. Uncheck the "Show alerts about passwords" then navigate using tabs until 'Learn More' from the Primary Password line.

Expected result

  • The selection border is the same as for the other 'Learn More' links.

Actual result

  • The selection border is bigger.

Regression range

  • This might be a regression.

Additional notes

  • The issue is not proton specific, but it is more visible with a solid border.
QA Whiteboard: [qa-regression-triage]
Has Regression Range: --- → no
Has STR: --- → yes

Fix the learn button of the master password that was too wide.

Assignee: nobody → pyjacpp
Status: NEW → ASSIGNED
Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/autoland/rev/2db6a4941022 Fix learn more button too wide. r=desktop-theme-reviewers,Itiel

https://hg.mozilla.org/mozilla-central/rev/2db6a4941022

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox91: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
Flags: qe-verify+

Verified the fix on Firefox 91.0b8 and Nightly 92.0a1 using macOS 10.15, Windows 10 x64 and Ubuntu 18.04 x64. The issue is not reproducing anymore.

Status: RESOLVED → VERIFIED
status-firefox91: fixed → verified
status-firefox92: --- → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: