1707096 - permafailing clang-trunk bustage /builds/worker/workspace/obj-build/dist/include/js/Value.h:393:3: error: definition of implicit copy assignment operator for 'Value' is deprecated because it has a user-declared copy constructor [-Werror,-Wdeprecated-copy]

Reporter

Description

•

4 years ago

treeherder

Filed by: abutkovits [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=337478439&repo=mozilla-beta
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/DgoTH-D9RASDMxgVDjcnag/runs/0/artifacts/public/logs/live_backing.log

[task 2021-04-22T19:26:02.190Z] 19:26:02  WARNING -  /builds/worker/checkouts/gecko/netwerk/sctp/src/user_socket.c:2453:27: warning: loop will run at most once (loop increment never executed) [-Wunreachable-code-loop-increment]
[task 2021-04-22T19:26:02.190Z] 19:26:02     INFO -          for (i = 0; i < addrcnt; i++) {
[task 2021-04-22T19:26:02.190Z] 19:26:02     INFO -                                   ^~~
[task 2021-04-22T19:26:02.190Z] 19:26:02     INFO -  1 warning generated.
[task 2021-04-22T19:26:02.190Z] 19:26:02     INFO -  make[4]: Leaving directory '/builds/worker/workspace/obj-build/netwerk/sctp/src'
[task 2021-04-22T19:26:02.207Z] 19:26:02     INFO -  make[4]: Entering directory '/builds/worker/workspace/obj-build/security/manager/pki'
[task 2021-04-22T19:26:02.207Z] 19:26:02     INFO -  mkdir -p '.deps/'
[task 2021-04-22T19:26:02.208Z] 19:26:02     INFO -  make[4]: Leaving directory '/builds/worker/workspace/obj-build/security/manager/pki'
[task 2021-04-22T19:26:02.220Z] 19:26:02     INFO -  make[4]: Entering directory '/builds/worker/workspace/obj-build/security/manager/pki'
[task 2021-04-22T19:26:02.220Z] 19:26:02     INFO -  security/manager/pki/Unified_cpp_security_manager_pki0.o
[task 2021-04-22T19:26:02.221Z] 19:26:02     INFO -  make[4]: Leaving directory '/builds/worker/workspace/obj-build/security/manager/pki'
[task 2021-04-22T19:26:02.567Z] 19:26:02     INFO -  make[4]: Entering directory '/builds/worker/workspace/obj-build/parser/htmlparser'
[task 2021-04-22T19:26:02.570Z] 19:26:02     INFO -  /builds/worker/fetches/clang/bin/clang++ --sysroot /builds/worker/fetches/sysroot -gcc-toolchain /builds/worker/fetches/clang -std=gnu++17 -o Unified_cpp_parser_htmlparser0.o -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fstack-clash-protection -DNDEBUG=1 -DTRIMMED=1 -DOS_POSIX=1 -DOS_LINUX=1 -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/parser/htmlparser -I/builds/worker/workspace/obj-build/parser/htmlparser -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/checkouts/gecko/ipc/glue -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -Qunused-arguments -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=free-nonheap-object -Wno-error=return-std-move -Wno-error=atomic-alignment -Wno-error=deprecated-copy -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-psabi -Wno-unknown-warning-option -fno-sized-deallocation -fno-aligned-new -fno-exceptions -fno-strict-aliasing -fPIC -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -O2 -fno-omit-frame-pointer -funwind-tables -Werror -Wno-error=shadow -fexperimental-new-pass-manager  -MD -MP -MF .deps/Unified_cpp_parser_htmlparser0.o.pp   Unified_cpp_parser_htmlparser0.cpp
[task 2021-04-22T19:26:02.570Z] 19:26:02     INFO -  make[4]: Leaving directory '/builds/worker/workspace/obj-build/parser/htmlparser'
[task 2021-04-22T19:26:02.592Z] 19:26:02     INFO -  make[4]: Entering directory '/builds/worker/workspace/obj-build/gfx/layers'
[task 2021-04-22T19:26:02.597Z] 19:26:02     INFO -  /builds/worker/fetches/clang/bin/clang++ --sysroot /builds/worker/fetches/sysroot -gcc-toolchain /builds/worker/fetches/clang -std=gnu++17 -o Unified_cpp_gfx_layers6.o -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fstack-clash-protection -DNDEBUG=1 -DTRIMMED=1 -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DMOZ_APP_VERSION=89.0 -DOS_POSIX=1 -DOS_LINUX=1 -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/gfx/layers -I/builds/worker/workspace/obj-build/gfx/layers -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/checkouts/gecko/ipc/glue -I/builds/worker/checkouts/gecko/docshell/base -I/builds/worker/checkouts/gecko/dom/canvas -I/builds/worker/checkouts/gecko/layout/base -I/builds/worker/checkouts/gecko/layout/generic -I/builds/worker/checkouts/gecko/media/libyuv/libyuv/include -I/builds/worker/checkouts/gecko/gfx/skia -I/builds/worker/checkouts/gecko/gfx/skia/skia -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -Qunused-arguments -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=free-nonheap-object -Wno-error=return-std-move -Wno-error=atomic-alignment -Wno-error=deprecated-copy -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-psabi -Wno-unknown-warning-option -fno-sized-deallocation -fno-aligned-new -fno-exceptions -fno-strict-aliasing -fPIC -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -O2 -fno-omit-frame-pointer -funwind-tables -Werror -I/builds/worker/workspace/obj-build/dist/include/cairo -I/builds/worker/checkouts/gecko/widget/gtk/compat-gtk3 -pthread -I/builds/worker/fetches/sysroot/usr/include/gtk-3.0/unix-print -I/builds/worker/fetches/sysroot/usr/include/gtk-3.0 -I/builds/worker/fetches/sysroot/usr/include/at-spi2-atk/2.0 -I/builds/worker/fetches/sysroot/usr/include/at-spi-2.0 -I/builds/worker/fetches/sysroot/usr/include/dbus-1.0 -I/builds/worker/fetches/sysroot/usr/lib/x86_64-linux-gnu/dbus-1.0/include -I/builds/worker/fetches/sysroot/usr/include/gtk-3.0 -I/builds/worker/fetches/sysroot/usr/include/cairo -I/builds/worker/fetches/sysroot/usr/include/pango-1.0 -I/builds/worker/fetches/sysroot/usr/include/harfbuzz -I/builds/worker/fetches/sysroot/usr/include/pango-1.0 -I/builds/worker/fetches/sysroot/usr/include/atk-1.0 -I/builds/worker/fetches/sysroot/usr/include/cairo -I/builds/worker/fetches/sysroot/usr/include/pixman-1 -I/builds/worker/fetches/sysroot/usr/include/freetype2 -I/builds/worker/fetches/sysroot/usr/include/libpng12 -I/builds/worker/fetches/sysroot/usr/include/gdk-pixbuf-2.0 -I/builds/worker/fetches/sysroot/usr/include/libpng12 -I/builds/worker/fetches/sysroot/usr/include/gio-unix-2.0/ -I/builds/worker/fetches/sysroot/usr/include/glib-2.0 -I/builds/worker/fetches/sysroot/usr/lib/x86_64-linux-gnu/glib-2.0/include -Werror=switch -Wno-error=shadow -Wno-maybe-uninitialized -fexperimental-new-pass-manager  -MD -MP -MF .deps/Unified_cpp_gfx_layers6.o.pp   Unified_cpp_gfx_layers6.cpp
[task 2021-04-22T19:26:02.597Z] 19:26:02     INFO -  make[4]: Leaving directory '/builds/worker/workspace/obj-build/gfx/layers'
[task 2021-04-22T19:26:02.598Z] 19:26:02     INFO -  make[4]: Entering directory '/builds/worker/workspace/obj-build/gfx/layers'
[task 2021-04-22T19:26:02.599Z] 19:26:02     INFO -  gfx/layers/Unified_cpp_gfx_layers7.o
[task 2021-04-22T19:26:02.599Z] 19:26:02     INFO -  make[4]: Leaving directory '/builds/worker/workspace/obj-build/gfx/layers'
[task 2021-04-22T19:26:02.747Z] 19:26:02     INFO -  make[4]: Entering directory '/builds/worker/workspace/obj-build/media/libvpx'
[task 2021-04-22T19:26:02.748Z] 19:26:02     INFO -  media/libvpx/subpel_variance_sse2.o
[task 2021-04-22T19:26:02.749Z] 19:26:02     INFO -  /builds/worker/fetches/nasm/nasm -o subpel_variance_sse2.o -f elf64 -F dwarf -I/builds/worker/checkouts/gecko/media/libvpx/config/linux/x64/ -I./ -I/builds/worker/checkouts/gecko/media/libvpx/libvpx/   /builds/worker/checkouts/gecko/media/libvpx/libvpx/vpx_dsp/x86/subpel_variance_sse2.asm
[task 2021-04-22T19:26:02.750Z] 19:26:02     INFO -  make[4]: Leaving directory '/builds/worker/workspace/obj-build/media/libvpx'
[task 2021-04-22T19:26:02.896Z] 19:26:02     INFO -  make[4]: Entering directory '/builds/worker/workspace/obj-build/media/libvpx'
[task 2021-04-22T19:26:02.896Z] 19:26:02     INFO -  media/libvpx/subtract_sse2.o
[task 2021-04-22T19:26:02.896Z] 19:26:02     INFO -  /builds/worker/fetches/nasm/nasm -o subtract_sse2.o -f elf64 -F dwarf -I/builds/worker/checkouts/gecko/media/libvpx/config/linux/x64/ -I./ -I/builds/worker/checkouts/gecko/media/libvpx/libvpx/   /builds/worker/checkouts/gecko/media/libvpx/libvpx/vpx_dsp/x86/subtract_sse2.asm
[task 2021-04-22T19:26:02.896Z] 19:26:02     INFO -  make[4]: Leaving directory '/builds/worker/workspace/obj-build/media/libvpx'
[task 2021-04-22T19:26:03.063Z] 19:26:03     INFO -  make[4]: Entering directory '/builds/worker/workspace/obj-build/media/libvpx'
[task 2021-04-22T19:26:03.063Z] 19:26:03     INFO -  media/libvpx/vpx_convolve_copy_sse2.o
[task 2021-04-22T19:26:03.063Z] 19:26:03     INFO -  /builds/worker/fetches/nasm/nasm -o vpx_convolve_copy_sse2.o -f elf64 -F dwarf -I/builds/worker/checkouts/gecko/media/libvpx/config/linux/x64/ -I./ -I/builds/worker/checkouts/gecko/media/libvpx/libvpx/   /builds/worker/checkouts/gecko/media/libvpx/libvpx/vpx_dsp/x86/vpx_convolve_copy_sse2.asm
[task 2021-04-22T19:26:03.064Z] 19:26:03     INFO -  make[4]: Leaving directory '/builds/worker/workspace/obj-build/media/libvpx'
[task 2021-04-22T19:26:03.089Z] 19:26:03     INFO -  make[4]: Entering directory '/builds/worker/workspace/obj-build/media/libvpx'
[task 2021-04-22T19:26:03.090Z] 19:26:03     INFO -  media/libvpx/vpx_subpixel_8t_sse2.o
[task 2021-04-22T19:26:03.090Z] 19:26:03     INFO -  /builds/worker/fetches/nasm/nasm -o vpx_subpixel_8t_sse2.o -f elf64 -F dwarf -I/builds/worker/checkouts/gecko/media/libvpx/config/linux/x64/ -I./ -I/builds/worker/checkouts/gecko/media/libvpx/libvpx/   /builds/worker/checkouts/gecko/media/libvpx/libvpx/vpx_dsp/x86/vpx_subpixel_8t_sse2.asm
[task 2021-04-22T19:26:03.090Z] 19:26:03     INFO -  make[4]: Leaving directory '/builds/worker/workspace/obj-build/media/libvpx'
[task 2021-04-22T19:26:03.187Z] 19:26:03     INFO -  make[4]: Entering directory '/builds/worker/workspace/obj-build/js/src'
[task 2021-04-22T19:26:03.190Z] 19:26:03     INFO -  /builds/worker/fetches/clang/bin/clang++ --sysroot /builds/worker/fetches/sysroot -gcc-toolchain /builds/worker/fetches/clang -std=gnu++17 -o Unified_cpp_js_src26.o -c  -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fstack-clash-protection -DNDEBUG=1 -DTRIMMED=1 -DWASM_SUPPORTS_HUGE_MEMORY -DJS_HAS_CTYPES -DFFI_BUILDING -DEXPORT_JS_API -DMOZ_HAS_MOZGLUE -I/builds/worker/checkouts/gecko/js/src -I/builds/worker/workspace/obj-build/js/src -I/builds/worker/workspace/obj-build/js/src/ctypes/libffi/include -I/builds/worker/checkouts/gecko/js/src/ctypes/libffi/src/x86 -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/js/src/js-confdefs.h -Qunused-arguments -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=free-nonheap-object -Wno-error=return-std-move -Wno-error=atomic-alignment -Wno-error=deprecated-copy -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-psabi -Wno-unknown-warning-option -fno-sized-deallocation -fno-aligned-new -fPIC -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -O3 -fno-omit-frame-pointer -funwind-tables -Werror -fno-strict-aliasing -Werror=format -Wno-shadow -fexperimental-new-pass-manager  -MD -MP -MF .deps/Unified_cpp_js_src26.o.pp   Unified_cpp_js_src26.cpp
[task 2021-04-22T19:26:03.191Z] 19:26:03     INFO -  make[4]: Leaving directory '/builds/worker/workspace/obj-build/js/src'
[task 2021-04-22T19:26:03.192Z] 19:26:03     INFO -  make[4]: Entering directory '/builds/worker/workspace/obj-build/js/src'
[task 2021-04-22T19:26:03.192Z] 19:26:03     INFO -  js/src/Unified_cpp_js_src27.o
[task 2021-04-22T19:26:03.192Z] 19:26:03     INFO -  make[4]: Leaving directory '/builds/worker/workspace/obj-build/js/src'
[task 2021-04-22T19:26:03.347Z] 19:26:03     INFO -  make[4]: Entering directory '/builds/worker/workspace/obj-build/security/ct'
[task 2021-04-22T19:26:03.350Z] 19:26:03     INFO -  /builds/worker/fetches/clang/bin/clang++ --sysroot /builds/worker/fetches/sysroot -gcc-toolchain /builds/worker/fetches/clang -std=gnu++17 -o Unified_cpp_security_ct0.o -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fstack-clash-protection -DNDEBUG -DTRIMMED=1 -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/security/ct -I/builds/worker/workspace/obj-build/security/ct -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -Qunused-arguments -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=free-nonheap-object -Wno-error=return-std-move -Wno-error=atomic-alignment -Wno-error=deprecated-copy -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-psabi -Wno-unknown-warning-option -fno-sized-deallocation -fno-aligned-new -fno-exceptions -fno-strict-aliasing -fPIC -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -O2 -fno-omit-frame-pointer -funwind-tables -Werror -Wall -Wextra -Wunreachable-code -Wno-unused-parameter -fexperimental-new-pass-manager  -MD -MP -MF .deps/Unified_cpp_security_ct0.o.pp   Unified_cpp_security_ct0.cpp
[task 2021-04-22T19:26:03.351Z] 19:26:03     INFO -  make[4]: Leaving directory '/builds/worker/workspace/obj-build/security/ct'
[task 2021-04-22T19:26:03.354Z] 19:26:03     INFO -  make[4]: Entering directory '/builds/worker/workspace/obj-build/security/nss/lib/crmf/crmf_crmf'
[task 2021-04-22T19:26:03.354Z] 19:26:03     INFO -  mkdir -p '.deps/'
[task 2021-04-22T19:26:03.355Z] 19:26:03     INFO -  make[4]: Leaving directory '/builds/worker/workspace/obj-build/security/nss/lib/crmf/crmf_crmf'
[task 2021-04-22T19:26:03.448Z] 19:26:03     INFO -  make[4]: Entering directory '/builds/worker/workspace/obj-build/security/nss/lib/crmf/crmf_crmf'
[task 2021-04-22T19:26:03.448Z] 19:26:03     INFO -  security/nss/lib/crmf/asn1cmn.o
[task 2021-04-22T19:26:03.448Z] 19:26:03     INFO -  /builds/worker/fetches/clang/bin/clang --sysroot /builds/worker/fetches/sysroot -gcc-toolchain /builds/worker/fetches/clang -std=gnu99 -o asn1cmn.o -c  -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fstack-clash-protection -DNDEBUG -DTRIMMED=1 -DNSS_FIPS_DISABLED -DNSS_NO_INIT_SUPPORT -DNSS_X86_OR_X64 -DNSS_X64 -DNSS_USE_64 -DUSE_UTIL_DIRECTLY -DNO_NSPR_10_SUPPORT -DSSL_DISABLE_DEPRECATED_CIPHER_SUITE_NAMES -DLINUX2_1 -DLINUX -Dlinux -D_DEFAULT_SOURCE -D_BSD_SOURCE -D_POSIX_SOURCE -DSQL_MEASURE_USE_TEMP_DIR -DHAVE_STRERROR -DXP_UNIX -D_REENTRANT -DNSS_DISABLE_DBM -DNSS_ENABLE_DRAFT_HPKE -DNSS_DISABLE_LIBPKIX -I/builds/worker/checkouts/gecko/security/nss/lib/crmf -I/builds/worker/workspace/obj-build/security/nss/lib/crmf/crmf_crmf -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/private/nss -I/builds/worker/workspace/obj-build/dist/include/nss -I/builds/worker/workspace/obj-build/dist/include -include /builds/worker/workspace/obj-build/mozilla-config.h -DMOZILLA_CLIENT -Qunused-arguments -fno-strict-aliasing -fPIC -ffunction-sections -fdata-sections -fno-math-errno -pthread -pipe -g -O2 -fno-omit-frame-pointer -funwind-tables -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=free-nonheap-object -Wno-error=return-std-move -Wno-error=atomic-alignment -Wno-error=deprecated-copy -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Werror=implicit-function-declaration -Wno-psabi -fexperimental-new-pass-manager  -MD -MP -MF .deps/asn1cmn.o.pp   /builds/worker/checkouts/gecko/security/nss/lib/crmf/asn1cmn.c
[task 2021-04-22T19:26:03.448Z] 19:26:03     INFO -  make[4]: Leaving directory '/builds/worker/workspace/obj-build/security/nss/lib/crmf/crmf_crmf'
[task 2021-04-22T19:26:03.563Z] 19:26:03     INFO -  make[4]: Entering directory '/builds/worker/workspace/obj-build/media/libvpx'
[task 2021-04-22T19:26:03.563Z] 19:26:03     INFO -  media/libvpx/vpx_subpixel_8t_ssse3.o
[task 2021-04-22T19:26:03.563Z] 19:26:03     INFO -  /builds/worker/fetches/nasm/nasm -o vpx_subpixel_8t_ssse3.o -f elf64 -F dwarf -I/builds/worker/checkouts/gecko/media/libvpx/config/linux/x64/ -I./ -I/builds/worker/checkouts/gecko/media/libvpx/libvpx/   /builds/worker/checkouts/gecko/media/libvpx/libvpx/vpx_dsp/x86/vpx_subpixel_8t_ssse3.asm
[task 2021-04-22T19:26:03.563Z] 19:26:03     INFO -  make[4]: Leaving directory '/builds/worker/workspace/obj-build/media/libvpx'
[task 2021-04-22T19:26:03.576Z] 19:26:03     INFO -  make[4]: Entering directory '/builds/worker/workspace/obj-build/media/libvpx'
[task 2021-04-22T19:26:03.576Z] 19:26:03     INFO -  media/libvpx/vpx_subpixel_bilinear_sse2.o
[task 2021-04-22T19:26:03.576Z] 19:26:03     INFO -  /builds/worker/fetches/nasm/nasm -o vpx_subpixel_bilinear_sse2.o -f elf64 -F dwarf -I/builds/worker/checkouts/gecko/media/libvpx/config/linux/x64/ -I./ -I/builds/worker/checkouts/gecko/media/libvpx/libvpx/   /builds/worker/checkouts/gecko/media/libvpx/libvpx/vpx_dsp/x86/vpx_subpixel_bilinear_sse2.asm
[task 2021-04-22T19:26:03.576Z] 19:26:03     INFO -  make[4]: Leaving directory '/builds/worker/workspace/obj-build/media/libvpx'
[task 2021-04-22T19:26:03.585Z] 19:26:03     INFO -  make[4]: Entering directory '/builds/worker/workspace/obj-build/security/certverifier'
[task 2021-04-22T19:26:03.586Z] 19:26:03     INFO -  /builds/worker/fetches/clang/bin/clang++ --sysroot /builds/worker/fetches/sysroot -gcc-toolchain /builds/worker/fetches/clang -std=gnu++17 -o Unified_cpp_certverifier0.o -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fstack-clash-protection -DNDEBUG=1 -DTRIMMED=1 -DOS_POSIX=1 -DOS_LINUX=1 -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/security/certverifier -I/builds/worker/workspace/obj-build/security/certverifier -I/builds/worker/checkouts/gecko/security/ct -I/builds/worker/checkouts/gecko/security/manager/ssl -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/checkouts/gecko/ipc/glue -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -Qunused-arguments -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=free-nonheap-object -Wno-error=return-std-move -Wno-error=atomic-alignment -Wno-error=deprecated-copy -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-psabi -Wno-unknown-warning-option -fno-sized-deallocation -fno-aligned-new -fno-exceptions -fno-strict-aliasing -fPIC -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -O2 -fno-omit-frame-pointer -funwind-tables -Werror -Wall -Wextra -Wunreachable-code -Wno-unused-parameter -fexperimental-new-pass-manager  -MD -MP -MF .deps/Unified_cpp_certverifier0.o.pp   Unified_cpp_certverifier0.cpp
[task 2021-04-22T19:26:03.586Z] 19:26:03     INFO -  In file included from Unified_cpp_certverifier0.cpp:11:
[task 2021-04-22T19:26:03.586Z] 19:26:03     INFO -  In file included from /builds/worker/checkouts/gecko/security/certverifier/CertVerifier.cpp:7:
[task 2021-04-22T19:26:03.586Z] 19:26:03     INFO -  In file included from /builds/worker/checkouts/gecko/security/certverifier/CertVerifier.h:16:
[task 2021-04-22T19:26:03.586Z] 19:26:03     INFO -  In file included from /builds/worker/checkouts/gecko/security/manager/ssl/ScopedNSSTypes.h:24:
[task 2021-04-22T19:26:03.586Z] 19:26:03     INFO -  In file included from /builds/worker/checkouts/gecko/security/manager/ssl/NSSErrorsService.h:13:
[task 2021-04-22T19:26:03.586Z] 19:26:03     INFO -  In file included from /builds/worker/workspace/obj-build/dist/include/nsIStringBundle.h:14:
[task 2021-04-22T19:26:03.586Z] 19:26:03     INFO -  In file included from /builds/worker/workspace/obj-build/dist/include/nsISimpleEnumerator.h:13:
[task 2021-04-22T19:26:03.586Z] 19:26:03    ERROR -  /builds/worker/workspace/obj-build/dist/include/js/Value.h:393:3: error: definition of implicit copy assignment operator for 'Value' is deprecated because it has a user-declared copy constructor [-Werror,-Wdeprecated-copy]
[task 2021-04-22T19:26:03.586Z] 19:26:03     INFO -    Value(const Value& v) = default;
[task 2021-04-22T19:26:03.586Z] 19:26:03     INFO -    ^
[task 2021-04-22T19:26:03.586Z] 19:26:03     INFO -  /builds/worker/workspace/obj-build/dist/include/js/CallArgs.h:264:15: note: in implicit copy assignment operator for 'JS::Value' first required here
[task 2021-04-22T19:26:03.586Z] 19:26:03     INFO -      argv_[-2] = aCalleev;
[task 2021-04-22T19:26:03.586Z] 19:26:03     INFO -                ^
[task 2021-04-22T19:26:03.586Z] 19:26:03     INFO -  In file included from Unified_cpp_certverifier0.cpp:11:
[task 2021-04-22T19:26:03.587Z] 19:26:03     INFO -  In file included from /builds/worker/checkouts/gecko/security/certverifier/CertVerifier.cpp:7:
[task 2021-04-22T19:26:03.587Z] 19:26:03     INFO -  In file included from /builds/worker/checkouts/gecko/security/certverifier/CertVerifier.h:16:
[task 2021-04-22T19:26:03.587Z] 19:26:03     INFO -  In file included from /builds/worker/checkouts/gecko/security/manager/ssl/ScopedNSSTypes.h:24:
[task 2021-04-22T19:26:03.587Z] 19:26:03     INFO -  In file included from /builds/worker/checkouts/gecko/security/manager/ssl/NSSErrorsService.h:13:
[task 2021-04-22T19:26:03.587Z] 19:26:03     INFO -  In file included from /builds/worker/workspace/obj-build/dist/include/nsIStringBundle.h:14:
[task 2021-04-22T19:26:03.587Z] 19:26:03     INFO -  In file included from /builds/worker/workspace/obj-build/dist/include/nsISimpleEnumerator.h:13:
[task 2021-04-22T19:26:03.587Z] 19:26:03     INFO -  In file included from /builds/worker/workspace/obj-build/dist/include/js/Value.h:24:
[task 2021-04-22T19:26:03.589Z] 19:26:03    ERROR -  /builds/worker/workspace/obj-build/dist/include/js/RootingAPI.h:650:3: error: definition of implicit copy constructor for 'Handle<JSObject *>' is deprecated because it has a user-declared copy assignment operator [-Werror,-Wdeprecated-copy]
[task 2021-04-22T19:26:03.589Z] 19:26:03     INFO -    DELETE_ASSIGNMENT_OPS(Handle, T);
[task 2021-04-22T19:26:03.589Z] 19:26:03     INFO -    ^
[task 2021-04-22T19:26:03.589Z] 19:26:03     INFO -  /builds/worker/workspace/obj-build/dist/include/js/RootingAPI.h:189:15: note: expanded from macro 'DELETE_ASSIGNMENT_OPS'
[task 2021-04-22T19:26:03.589Z] 19:26:03     INFO -    Wrapper<T>& operator=(const Wrapper<T>&) = delete;
[task 2021-04-22T19:26:03.589Z] 19:26:03     INFO -                ^
[task 2021-04-22T19:26:03.589Z] 19:26:03     INFO -  /builds/worker/workspace/obj-build/dist/include/js/Class.h:166:28: note: in implicit copy constructor for 'JS::Handle<JSObject *>' first required here
[task 2021-04-22T19:26:03.589Z] 19:26:03     INFO -      return reportError(cx, obj, id);
[task 2021-04-22T19:26:03.589Z] 19:26:03     INFO -                             ^
[task 2021-04-22T19:26:03.589Z] 19:26:03     INFO -  In file included from Unified_cpp_certverifier0.cpp:11:
[task 2021-04-22T19:26:03.589Z] 19:26:03     INFO -  In file included from /builds/worker/checkouts/gecko/security/certverifier/CertVerifier.cpp:7:
[task 2021-04-22T19:26:03.589Z] 19:26:03     INFO -  In file included from /builds/worker/checkouts/gecko/security/certverifier/CertVerifier.h:16:
[task 2021-04-22T19:26:03.589Z] 19:26:03     INFO -  In file included from /builds/worker/checkouts/gecko/security/manager/ssl/ScopedNSSTypes.h:24:
[task 2021-04-22T19:26:03.596Z] 19:26:03     INFO -  In file included from /builds/worker/checkouts/gecko/security/manager/ssl/NSSErrorsService.h:13:
[task 2021-04-22T19:26:03.596Z] 19:26:03     INFO -  In file included from /builds/worker/workspace/obj-build/dist/include/nsIStringBundle.h:14:
[task 2021-04-22T19:26:03.596Z] 19:26:03     INFO -  In file included from /builds/worker/workspace/obj-build/dist/include/nsISimpleEnumerator.h:13:
[task 2021-04-22T19:26:03.597Z] 19:26:03     INFO -  In file included from /builds/worker/workspace/obj-build/dist/include/js/Value.h:24:
[task 2021-04-22T19:26:03.597Z] 19:26:03    ERROR -  /builds/worker/workspace/obj-build/dist/include/js/RootingAPI.h:650:3: error: definition of implicit copy constructor for 'Handle<JS::PropertyKey>' is deprecated because it has a user-declared copy assignment operator [-Werror,-Wdeprecated-copy]```

Andi [:andi]

Assignee

Comment 1

•

4 years ago

Yeah, it's because of https://github.com/llvm/llvm-project/commit/abf3ca61e3235681f26d0f527b8e2763dd4c0c62#diff-c21da66b943620c063559b855971be3b2622d5ba1e99e9ff6d9cf0bf132b9fce

Andi [:andi]

Assignee

Updated

•

4 years ago

Component: JavaScript: GC → General

Product: Core → Firefox Build System

Version: unspecified → Trunk

Andi [:andi]

Assignee

Comment 2

•

4 years ago

Attached file Bug 1707096 - revert LLVM D79714 that causes build bustage on m-c and m-r. (deleted) — Details

We should probably enable this later on when we do the aproapriate fixes in m-c and they
are also tagged in m-r but for now we should have this changed backed out of llvm locally.

Phabricator Automation

Updated

•

4 years ago

Assignee: nobody → bpostelnicu

Status: NEW → ASSIGNED

Phabricator Automation

Updated

•

4 years ago

Attachment #9217973 - Attachment description: WIP: Bug 1707096 - revert LLVM D79714 that causes build bustage on m-c and m-r. → Bug 1707096 - revert LLVM D79714 that causes build bustage on m-c and m-r.

Pulsebot

Comment 3

•

4 years ago

Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/eb1b1b24a532 revert LLVM D79714 that causes build bustage on m-c and m-r. r=marco

Alexandru Michis [:malexandru]

Comment 4

•

4 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/eb1b1b24a532

Status: ASSIGNED → RESOLVED

Closed: 4 years ago

status-firefox90: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 90 Branch

Comment hidden (Intermittent Failures Robot)

Andi [:andi]

Assignee

Updated

•

4 years ago

See Also: → https://bugzilla.mozilla.org/show_bug.cgi?id=1707799

Sylvestre Ledru [:Sylvestre]

Comment 6

•

4 years ago

Doing backout of the patch in our local version of clang isn't the right approach. It will break when distros start using clang-13.

We should either:

disable the warning when it exists like in https://searchfox.org/mozilla-central/source/build/moz.configure/warnings.configure#131-133
fix the detected issues in our code base
fix clang upstream to not include -Wdeprecated-copy by default

We should not patch clang upstream for this kind of changes, it won't scale

Status: RESOLVED → REOPENED

Flags: needinfo?(bpostelnicu)

Resolution: FIXED → ---

BugBot [:suhaib / :marco/ :calixte]

Updated

•

4 years ago

status-firefox90: fixed → affected

Andi [:andi]

Assignee

Comment 7

•

4 years ago

Attached file Bug 1707096 - fix `deprecated-copy` detected by clang-trunk. r=sfink,jandem (deleted) — Details

Sylvestre Ledru [:Sylvestre]

Updated

•

3 years ago

Blocks: build-clang-trunk

Phabricator Automation

Updated

•

3 years ago

Attachment #9219820 - Attachment description: Bug 1707096 - fix `deprecated-copy` detected by clang-trunk. r=sfink → Bug 1707096 - fix `deprecated-copy` detected by clang-trunk. r=sfink,jandem

Pulsebot

Comment 8

•

3 years ago

Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6a7db9514f9e fix `deprecated-copy` detected by clang-trunk. r=sfink,jandem

Andi [:andi]

Assignee

Comment 9

•

3 years ago

Comment on attachment 9219820 [details]
Bug 1707096 - fix deprecated-copy detected by clang-trunk. r=sfink,jandem

Beta/Release Uplift Approval Request

User impact if declined: The user is not impacted
Is this code covered by automated tests?: Unknown
Has the fix been verified in Nightly?: Yes
Needs manual test from QE?: No
If yes, steps to reproduce:
List of other uplifts needed: None
Risk to taking this patch: Low
Why is the change risky/not risky? (and alternatives if risky): This is not risky, only adds some syntax sugar for C++ in order to be compliant with clang-trunk that adds a new warning, deprecated-copy. If this doesn't gets uplifted we will have permanent build failure of : Linux x64 opt build-linux64-plain-clang-trunk/opt Bp-clang-trunk on mozilla-release.
String changes made/needed: no further changes needed

Flags: needinfo?(bpostelnicu)

Attachment #9219820 - Flags: approval-mozilla-release?

Attachment #9219820 - Flags: approval-mozilla-beta?

Andi [:andi]

Assignee

Updated

•

3 years ago

Attachment #9217973 - Flags: approval-mozilla-release?

Attachment #9217973 - Flags: approval-mozilla-beta?

Andi [:andi]

Assignee

Updated

•

3 years ago

Attachment #9217973 - Flags: approval-mozilla-release?

Attachment #9217973 - Flags: approval-mozilla-beta?

Pascal Chevrel:pascalc (PTO until August 21)

Comment 10

•

3 years ago

We are in RC week, the beta repository is frozen until the merge next Monday, is there an urgent need to have that uplifted in 89 before 90 merges to beta?

Flags: needinfo?(bpostelnicu)

Cristian Brindusan [:cbrindusan]

Comment 11

•

3 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/6a7db9514f9e

Status: REOPENED → RESOLVED

Closed: 4 years ago → 3 years ago

status-firefox90: affected → fixed

Resolution: --- → FIXED

Andi [:andi]

Assignee

Comment 12

•

3 years ago

We are in RC week, the beta repository is frozen until the merge next Monday, is there an urgent need to have that uplifted in 89 before 90 merges to beta?

mozilla-release will bre broken once this lands to m-c.

Flags: needinfo?(bpostelnicu)

Pascal Chevrel:pascalc (PTO until August 21)

Comment 13

•

3 years ago

Comment on attachment 9219820 [details]
Bug 1707096 - fix deprecated-copy detected by clang-trunk. r=sfink,jandem

I am taking it on mozilla-release as a ride-along to our RC2. Mozilla-beta is closed this week.

Attachment #9219820 - Flags: approval-mozilla-release?

Attachment #9219820 - Flags: approval-mozilla-release+

Attachment #9219820 - Flags: approval-mozilla-beta?

Attachment #9219820 - Flags: approval-mozilla-beta-

Pascal Chevrel:pascalc (PTO until August 21)

Comment 14

•

3 years ago

bugherder uplift

https://hg.mozilla.org/releases/mozilla-release/rev/956b05ef96d4

status-firefox89: --- → fixed

Comment hidden (Intermittent Failures Robot)

Andreea Pavel [:apavel]

Comment 16

•

3 years ago

This still occurs on mozilla-central and mozilla-release
Failure log: https://treeherder.mozilla.org/logviewer?job_id=341494261&repo=mozilla-release&lineNumber=4799

[task 2021-06-02T02:25:25.370Z] 02:25:25 [task 2021-06-02T02:25:25.370Z] 02:25:25 [task 2021-06-02T02:25:25.579Z] 02:25:25 [task 2021-06-02T02:25:25.579Z] 02:25:25 [task 2021-06-02T02:25:25.579Z] 02:25:25 [task 2021-06-02T02:25:25.587Z] 02:25:25 [task 2021-06-02T02:25:25.587Z] 02:25:25 [task 2021-06-02T02:25:25.587Z] 02:25:25 [task 2021-06-02T02:25:25.934Z] 02:25:25 [task 2021-06-02T02:25:25.934Z] 02:25:25 [task 2021-06-02T02:25:25.934Z] 02:25:25 [task 2021-06-02T02:25:25.934Z] 02:25:25 [task 2021-06-02T02:25:26.807Z] 02:25:26 [task 2021-06-02T02:25:26.807Z] 02:25:26 [task 2021-06-02T02:25:26.807Z] 02:25:26 [task 2021-06-02T02:25:26.815Z] 02:25:26 [task 2021-06-02T02:25:26.815Z] 02:25:26 [task 2021-06-02T02:25:26.815Z] 02:25:26 [task 2021-06-02T02:25:26.820Z] 02:25:26 [task 2021-06-02T02:25:26.820Z] 02:25:26 [task 2021-06-02T02:25:26.821Z] 02:25:26 [task 2021-06-02T02:25:26.821Z] 02:25:26 [task 2021-06-02T02:25:27.034Z] 02:25:27 [task 2021-06-02T02:25:27.034Z] 02:25:27 [task 2021-06-02T02:25:27.034Z] 02:25:27 [task 2021-06-02T02:25:27.034Z] 02:25:27 [task 2021-06-02T02:25:27.034Z] 02:25:27 [task 2021-06-02T02:25:27.034Z] 02:25:27 [task 2021-06-02T02:25:27.034Z] 02:25:27 [task 2021-06-02T02:25:27.034Z] 02:25:27 [task 2021-06-02T02:25:27.034Z] 02:25:27 [task 2021-06-02T02:25:27.034Z] 02:25:27 [task 2021-06-02T02:25:27.034Z] 02:25:27 [task 2021-06-02T02:25:27.034Z] 02:25:27 [task 2021-06-02T02:25:27.034Z] 02:25:27 [task 2021-06-02T02:25:27.035Z] 02:25:27 [task 2021-06-02T02:25:27.035Z] 02:25:27 [task 2021-06-02T02:25:27.189Z] 02:25:27 [task 2021-06-02T02:25:27.189Z] 02:25:27 [task 2021-06-02T02:25:27.189Z] 02:25:27 [task 2021-06-02T02:25:27.199Z] 02:25:27 [task 2021-06-02T02:25:27.199Z] 02:25:27 INFO - mozglue/misc/TimeStamp_posix.o
INFO - make[4]: Leaving directory '/builds/worker/workspace/obj-build/mozglue/misc'
INFO - make[4]: Entering directory '/builds/worker/workspace/obj-build/accessible/atk'
INFO - /builds/worker/fetches/clang/bin/clang++ --sysroot /builds/worker/fetches/sysroot -gcc-toolchain /builds/worker/fetches/clang -std=gnu++17 -o DOMtoATK.o -c -I/builds/worker/workspace/obj-build/dist/stl_wrappers -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fstack-clash-protection -DNDEBUG=1 -DTRIMMED=1 -DOS_POSIX=1 -DOS_LINUX=1 -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/accessible/atk -I/builds/worker/workspace/obj-build/accessible/atk -I/builds/worker/checkouts/gecko/accessible/base -I/builds/worker/checkouts/gecko/accessible/generic -I/builds/worker/checkouts/gecko/accessible/html -I/builds/worker/checkouts/gecko/accessible/ipc -I/builds/worker/checkouts/gecko/accessible/ipc/other -I/builds/worker/checkouts/gecko/accessible/xpcom -I/builds/worker/checkouts/gecko/accessible/xul -I/builds/worker/checkouts/gecko/other-licenses/atk-1.0 -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/checkouts/gecko/ipc/glue -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -Qunused-arguments -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=free-nonheap-object -Wno-error=return-std-move -Wno-error=atomic-alignment -Wno-error=deprecated-copy -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-psabi -Wno-unknown-warning-option -fno-sized-deallocation -fno-aligned-new -fno-exceptions -fno-strict-aliasing -fPIC -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -O2 -fomit-frame-pointer -funwind-tables -Werror -I/builds/worker/checkouts/gecko/widget/gtk/compat-gtk3 -pthread -I/builds/worker/fetches/sysroot/usr/include/gtk-3.0/unix-print -I/builds/worker/fetches/sysroot/usr/include/gtk-3.0 -I/builds/worker/fetches/sysroot/usr/include/at-spi2-atk/2.0 -I/builds/worker/fetches/sysroot/usr/include/at-spi-2.0 -I/builds/worker/fetches/sysroot/usr/include/dbus-1.0 -I/builds/worker/fetches/sysroot/usr/lib/x86_64-linux-gnu/dbus-1.0/include -I/builds/worker/fetches/sysroot/usr/include/gtk-3.0 -I/builds/worker/fetches/sysroot/usr/include/cairo -I/builds/worker/fetches/sysroot/usr/include/pango-1.0 -I/builds/worker/fetches/sysroot/usr/include/harfbuzz -I/builds/worker/fetches/sysroot/usr/include/pango-1.0 -I/builds/worker/fetches/sysroot/usr/include/atk-1.0 -I/builds/worker/fetches/sysroot/usr/include/cairo -I/builds/worker/fetches/sysroot/usr/include/pixman-1 -I/builds/worker/fetches/sysroot/usr/include/freetype2 -I/builds/worker/fetches/sysroot/usr/include/libpng12 -I/builds/worker/fetches/sysroot/usr/include/gdk-pixbuf-2.0 -I/builds/worker/fetches/sysroot/usr/include/libpng12 -I/builds/worker/fetches/sysroot/usr/include/gio-unix-2.0/ -I/builds/worker/fetches/sysroot/usr/include/glib-2.0 -I/builds/worker/fetches/sysroot/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/builds/worker/fetches/sysroot/usr/include/dbus-1.0 -I/builds/worker/fetches/sysroot/usr/lib/x86_64-linux-gnu/dbus-1.0/include -Wno-error=unused-function -Wno-error=shadow -Wno-unused-local-typedefs -fexperimental-new-pass-manager -MD -MP -MF .deps/DOMtoATK.o.pp /builds/worker/checkouts/gecko/accessible/atk/DOMtoATK.cpp
INFO - make[4]: Leaving directory '/builds/worker/workspace/obj-build/accessible/atk'
INFO - make[4]: Entering directory '/builds/worker/workspace/obj-build/accessible/atk'
INFO - accessible/atk/Platform.o
INFO - make[4]: Leaving directory '/builds/worker/workspace/obj-build/accessible/atk'
INFO - make[4]: Entering directory '/builds/worker/workspace/obj-build/mfbt'
INFO - mfbt/lz4.o
INFO - /builds/worker/fetches/clang/bin/clang --sysroot /builds/worker/fetches/sysroot -gcc-toolchain /builds/worker/fetches/clang -std=gnu99 -o lz4.o -c -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fstack-clash-protection -DNDEBUG=1 -DTRIMMED=1 -DIMPL_MFBT -DLZ4LIB_VISIBILITY= -I/builds/worker/checkouts/gecko/mfbt -I/builds/worker/workspace/obj-build/mfbt -I/builds/worker/checkouts/gecko/mfbt/double-conversion -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -include /builds/worker/workspace/obj-build/mozilla-config.h -DMOZILLA_CLIENT -Qunused-arguments -fno-strict-aliasing -fPIC -ffunction-sections -fdata-sections -fno-math-errno -pthread -pipe -g -O2 -fomit-frame-pointer -funwind-tables -Werror -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=free-nonheap-object -Wno-error=return-std-move -Wno-error=atomic-alignment -Wno-error=deprecated-copy -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Werror=implicit-function-declaration -Wno-psabi -fexperimental-new-pass-manager -MD -MP -MF .deps/lz4.o.pp /builds/worker/checkouts/gecko/mfbt/lz4/lz4.c
INFO - make[4]: Leaving directory '/builds/worker/workspace/obj-build/mfbt'
INFO - make[4]: Entering directory '/builds/worker/workspace/obj-build/mozglue/misc'
INFO - /builds/worker/fetches/clang/bin/clang++ --sysroot /builds/worker/fetches/sysroot -gcc-toolchain /builds/worker/fetches/clang -std=gnu++17 -o TimeStamp_posix.o -c -I/builds/worker/workspace/obj-build/dist/stl_wrappers -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fstack-clash-protection -DNDEBUG=1 -DTRIMMED=1 '-DMOZ_APP_BASENAME="Firefox"' '-DMOZ_APP_VENDOR="Mozilla"' -DIMPL_MFBT -DMOZ_HAS_MOZGLUE -I/builds/worker/checkouts/gecko/mozglue/misc -I/builds/worker/workspace/obj-build/mozglue/misc -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -Qunused-arguments -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=free-nonheap-object -Wno-error=return-std-move -Wno-error=atomic-alignment -Wno-error=deprecated-copy -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-psabi -Wno-unknown-warning-option -fno-sized-deallocation -fno-aligned-new -fno-exceptions -fno-strict-aliasing -fPIC -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -O2 -fomit-frame-pointer -funwind-tables -Werror -fexperimental-new-pass-manager -MD -MP -MF .deps/TimeStamp_posix.o.pp /builds/worker/checkouts/gecko/mozglue/misc/TimeStamp_posix.cpp
INFO - make[4]: Leaving directory '/builds/worker/workspace/obj-build/mozglue/misc'
INFO - make[4]: Entering directory '/builds/worker/workspace/obj-build/mozglue/misc'
INFO - mozglue/misc/Uptime.o
INFO - make[4]: Leaving directory '/builds/worker/workspace/obj-build/mozglue/misc'
INFO - make[4]: Entering directory '/builds/worker/workspace/obj-build/mfbt'
INFO - mfbt/lz4frame.o
INFO - /builds/worker/fetches/clang/bin/clang --sysroot /builds/worker/fetches/sysroot -gcc-toolchain /builds/worker/fetches/clang -std=gnu99 -o lz4frame.o -c -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fstack-clash-protection -DNDEBUG=1 -DTRIMMED=1 -DIMPL_MFBT -DLZ4LIB_VISIBILITY= -I/builds/worker/checkouts/gecko/mfbt -I/builds/worker/workspace/obj-build/mfbt -I/builds/worker/checkouts/gecko/mfbt/double-conversion -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -include /builds/worker/workspace/obj-build/mozilla-config.h -DMOZILLA_CLIENT -Qunused-arguments -fno-strict-aliasing -fPIC -ffunction-sections -fdata-sections -fno-math-errno -pthread -pipe -g -O2 -fomit-frame-pointer -funwind-tables -Werror -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=free-nonheap-object -Wno-error=return-std-move -Wno-error=atomic-alignment -Wno-error=deprecated-copy -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Werror=implicit-function-declaration -Wno-psabi -fexperimental-new-pass-manager -MD -MP -MF .deps/lz4frame.o.pp /builds/worker/checkouts/gecko/mfbt/lz4/lz4frame.c
INFO - make[4]: Leaving directory '/builds/worker/workspace/obj-build/mfbt'
INFO - make[4]: Entering directory '/builds/worker/workspace/obj-build/mozglue/baseprofiler'
INFO - /builds/worker/fetches/clang/bin/clang++ --sysroot /builds/worker/fetches/sysroot -gcc-toolchain /builds/worker/fetches/clang -std=gnu++17 -o Unified_cpp_mozglue_baseprofiler0.o -c -I/builds/worker/workspace/obj-build/dist/stl_wrappers -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fstack-clash-protection -DNDEBUG=1 -DTRIMMED=1 -DIMPL_MFBT -DIMPL_MFBT -DMOZ_HAS_MOZGLUE -I/builds/worker/checkouts/gecko/mozglue/baseprofiler -I/builds/worker/workspace/obj-build/mozglue/baseprofiler -I/builds/worker/checkouts/gecko/mozglue/baseprofiler/core -I/builds/worker/checkouts/gecko/mozglue/linker -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -Qunused-arguments -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=free-nonheap-object -Wno-error=return-std-move -Wno-error=atomic-alignment -Wno-error=deprecated-copy -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-psabi -Wno-unknown-warning-option -fno-sized-deallocation -fno-aligned-new -fno-exceptions -fno-strict-aliasing -fPIC -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -O2 -fomit-frame-pointer -funwind-tables -Werror -Wno-error=shadow -Wno-ignored-qualifiers -fexperimental-new-pass-manager -MD -MP -MF .deps/Unified_cpp_mozglue_baseprofiler0.o.pp Unified_cpp_mozglue_baseprofiler0.cpp
INFO - In file included from Unified_cpp_mozglue_baseprofiler0.cpp:92:
INFO - In file included from /builds/worker/checkouts/gecko/mozglue/baseprofiler/core/platform.cpp:2465:
ERROR - /builds/worker/checkouts/gecko/mozglue/baseprofiler/core/platform-linux-android.cpp:216:9: error: variable 'r' set but not used [-Werror,-Wunused-but-set-variable]
INFO - int r = sem_init(&mMessage2, /* pshared */ 0, 0);
INFO - ^
ERROR - /builds/worker/checkouts/gecko/mozglue/baseprofiler/core/platform-linux-android.cpp:223:9: error: variable 'r' set but not used [-Werror,-Wunused-but-set-variable]
INFO - int r = sem_destroy(&mMessage2);
INFO - ^
INFO - 2 errors generated.
ERROR - make[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:676: Unified_cpp_mozglue_baseprofiler0.o] Error 1
INFO - make[4]: Leaving directory '/builds/worker/workspace/obj-build/mozglue/baseprofiler'
ERROR - make[3]: *** [/builds/worker/checkouts/gecko/config/recurse.mk:72: mozglue/baseprofiler/target-objects] Error 2
INFO - make[3]: *** Waiting for unfinished jobs....
INFO - make[4]: Entering directory '/builds/worker/workspace/obj-build/xpcom/glue/standalone'
INFO - /builds/worker/fetches/clang/bin/clang++ --sysroot /builds/worker/fetches/sysroot -gcc-toolchain /builds/worker/fetches/clang -std=gnu++17 -o nsXPCOMGlue.o -c -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fstack-clash-protection -DNDEBUG=1 -DTRIMMED=1 -DXPCOM_GLUE -I/builds/worker/checkouts/gecko/xpcom/glue/standalone -I/builds/worker/workspace/obj-build/xpcom/glue/standalone -I/builds/worker/checkouts/gecko/xpcom/build -I/builds/worker/checkouts/gecko/xpcom/threads -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -Qunused-arguments -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=free-nonheap-object -Wno-error=return-std-move -Wno-error=atomic-alignment -Wno-error=deprecated-copy -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-psabi -Wno-unknown-warning-option -fno-sized-deallocation -fno-aligned-new -fno-exceptions -fno-strict-aliasing -fPIC -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -O2 -fomit-frame-pointer -funwind-tables -Werror -I/builds/worker/fetches/sysroot/usr/include/glib-2.0 -I/builds/worker/fetches/sysroot/usr/lib/x86_64-linux-gnu/glib-2.0/include -fexperimental-new-pass-manager -MD -MP -MF .deps/nsXPCOMGlue.o.pp /builds/worker/checkouts/gecko/xpcom/glue/standalone/nsXPCOMGlue.cpp
INFO - make[4]: Leaving directory '/builds/worker/workspace/obj-build/xpcom/glue/standalone'
INFO - make[4]: Entering directory '/builds/worker/workspace/obj-build/mfbt'
INFO - mfbt/Unified_cpp_mfbt0.o

Flags: needinfo?(bpostelnicu)

Andi [:andi]

Assignee

Updated

•

3 years ago

Status: RESOLVED → REOPENED

Flags: needinfo?(bpostelnicu)

Resolution: FIXED → ---

Andi [:andi]

Assignee

Comment 17

•

3 years ago

Attached file Bug 1707096 - fix the build for `clang-trunk`. r=jfkthame (deleted) — Details

With D100581 LLVM added support for -Wunused-but-set-parameter and -Wunused-but-set-variable.

we shouldn't treat these warning as errors
for harfbuzz we apply a patch that has also been upstreamed, #2995, since pragma directives are somehow borken in clang vs gcc.

Andi [:andi]

Assignee

Comment 18

•

3 years ago

Comment on attachment 9224712 [details]
Bug 1707096 - fix the build for clang-trunk. r=jfkthame

Beta/Release Uplift Approval Request

User impact if declined: The user is not impacted.
Is this code covered by automated tests?: Yes
Has the fix been verified in Nightly?: Yes
Needs manual test from QE?: No
If yes, steps to reproduce:
List of other uplifts needed: None
Risk to taking this patch: Low
Why is the change risky/not risky? (and alternatives if risky): This is not risky
String changes made/needed:

Attachment #9224712 - Flags: approval-mozilla-release?

Pulsebot

Comment 19

•

3 years ago

Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7ceed945f49e fix the build for `clang-trunk`. r=jfkthame

Cristian Brindusan [:cbrindusan]

Comment 20

•

3 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/7ceed945f49e

Status: REOPENED → RESOLVED

Closed: 3 years ago → 3 years ago

status-firefox91: --- → fixed

Resolution: --- → FIXED

Comment hidden (Intermittent Failures Robot)

Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)

Comment 22

•

3 years ago

This still fails on release and also hasn't been fixed on beta where it doesn't run until it gets merged to release. Andi, please request uplift.

status-firefox89: fixed → affected

status-firefox90: fixed → affected

Flags: needinfo?(bpostelnicu)

Andi [:andi]

Assignee

Comment 23

•

3 years ago

Comment on attachment 9224712 [details]
Bug 1707096 - fix the build for clang-trunk. r=jfkthame

Beta/Release Uplift Approval Request

User impact if declined: None
Is this code covered by automated tests?: Unknown
Has the fix been verified in Nightly?: Yes
Needs manual test from QE?: No
If yes, steps to reproduce:
List of other uplifts needed: None
Risk to taking this patch: Low
Why is the change risky/not risky? (and alternatives if risky): We only removed an unused variable.
String changes made/needed:

Flags: needinfo?(bpostelnicu)

Attachment #9224712 - Flags: approval-mozilla-beta?

Julien Cristau [:jcristau]

Comment 24

•

3 years ago

This shouldn't run on m-r IMO. And it should definitely not run on m-r if it doesn't run on beta.

Julien Cristau [:jcristau]

Updated

•

3 years ago

Attachment #9224712 - Flags: approval-mozilla-beta? → approval-mozilla-beta-

Pascal Chevrel:pascalc (PTO until August 21)

Updated

•

3 years ago

Attachment #9224712 - Flags: approval-mozilla-release? → approval-mozilla-release-

Comment hidden (Intermittent Failures Robot)

Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)

Comment 26

•

3 years ago

Andi: Can you create a new bug about disabling the task on mozilla-release, please?

Flags: needinfo?(bpostelnicu)

Andi [:andi]

Assignee

Comment 27

•

3 years ago

(In reply to Julien Cristau [:jcristau] from comment #24)

This shouldn't run on m-r IMO. And it should definitely not run on m-r if it doesn't run on beta.

I don't agree with this. The task is specially also ran on m-r in order to detect performance regressions based only on clang-trunk compiler, something that we cannot meassure on m-c since it changes daily, and the performance diff can be impacted by landed patches.
Can we reassess this and land the patches in m-b and m-r?

Flags: needinfo?(bpostelnicu) → needinfo?(jcristau)

Julien Cristau [:jcristau]

Comment 28

•

3 years ago

Would you consider running the job on central and beta instead of central and release then? That's slightly more of a moving target than release, but not a whole lot, and it's easier to justify an uplift there for a tier-2 job that's not on the crit path for shipping.

Flags: needinfo?(jcristau)

Andi [:andi]

Assignee

Comment 29

•

3 years ago

(In reply to Julien Cristau [:jcristau] from comment #28)

Would you consider running the job on central and beta instead of central and release then? That's slightly more of a moving target than release, but not a whole lot, and it's easier to justify an uplift there for a tier-2 job that's not on the crit path for shipping.

Since we merge every 4 weeks m-c to m-b I think this is something doable.

Andi [:andi]

Assignee

Comment 30

•

3 years ago

Attached file Bug 1707096 - move linux64-bp-clang-trunk from m-r to m-b in order to make it easier for uplift patches when build issues arise. r=marco (obsolete) (deleted) — Details

Phabricator Automation

Comment 31

•

3 years ago

Comment on attachment 9227350 [details]
Bug 1707096 - move linux64-bp-clang-trunk from m-r to m-b in order to make it easier for uplift patches when build issues arise. r=marco

Revision D117989 was moved to bug 1716735. Setting attachment 9227350 [details] to obsolete.

Attachment #9227350 - Attachment is obsolete: true

Marco Castelluccio [:marco]

Updated

•

3 years ago

See Also: → https://bugzilla.mozilla.org/show_bug.cgi?id=1716735

Andi [:andi]

Assignee

Comment 32

•

3 years ago

(In reply to Andi-Bogdan Postelnicu [:andi] from comment #29)

(In reply to Julien Cristau [:jcristau] from comment #28)

Would you consider running the job on central and beta instead of central and release then? That's slightly more of a moving target than release, but not a whole lot, and it's easier to justify an uplift there for a tier-2 job that's not on the crit path for shipping.

Since we merge every 4 weeks m-c to m-b I think this is something doable.

So can we have this in beta?

Andi [:andi]

Assignee

Updated

•

3 years ago

Flags: needinfo?(jcristau)

Julien Cristau [:jcristau]

Comment 33

•

3 years ago

Comment on attachment 9224712 [details]
Bug 1707096 - fix the build for clang-trunk. r=jfkthame

approved for 90.0b9

Flags: needinfo?(jcristau)

Attachment #9224712 - Flags: approval-mozilla-beta- → approval-mozilla-beta+

Julien Cristau [:jcristau]

Comment 34

•

3 years ago

bugherder uplift

https://hg.mozilla.org/releases/mozilla-beta/rev/e0c1f71e0166

status-firefox90: affected → fixed

Andi [:andi]

Assignee

Comment 35

•

3 years ago

(In reply to Julien Cristau [:jcristau] from comment #34)

https://hg.mozilla.org/releases/mozilla-beta/rev/e0c1f71e0166

Thank you, you rock!

Julien Cristau [:jcristau]

Comment 36

•

3 years ago

As of bug 1716735 we no longer run those builds on mozilla-release, updating 89 status.

status-firefox89: affected → disabled

Comment hidden (Intermittent Failures Robot)

Chris Peterson [:cpeterson]

Updated

•

3 years ago

See Also: → https://bugzilla.mozilla.org/show_bug.cgi?id=1720253

Bug 1707096 - revert LLVM D79714 that causes build bustage on m-c and m-r. 4 years ago Andi [:andi] (deleted), text/x-phabricator-request		Details
Bug 1707096 - fix `deprecated-copy` detected by clang-trunk. r=sfink,jandem 4 years ago Andi [:andi] (deleted), text/x-phabricator-request	pascalc : approval-mozilla-beta- pascalc : approval-mozilla-release+	Details
Bug 1707096 - fix the build for `clang-trunk`. r=jfkthame 3 years ago Andi [:andi] (deleted), text/x-phabricator-request	jcristau : approval-mozilla-beta+ pascalc : approval-mozilla-release-	Details
Bug 1707096 - move linux64-bp-clang-trunk from m-r to m-b in order to make it easier for uplift patches when build issues arise. r=marco 3 years ago Andi [:andi] (deleted), text/x-phabricator-request		Details