stop using content/ css - move the css to the shared theme file instead
Categories
(Thunderbird :: General, task)
Tracking
(thunderbird_esr91 wontfix, thunderbird_esr102 unaffected, thunderbird93 wontfix)
Tracking | Status | |
---|---|---|
thunderbird_esr91 | --- | wontfix |
thunderbird_esr102 | --- | unaffected |
thunderbird93 | --- | wontfix |
People
(Reporter: mkmelin, Assigned: henry-x)
References
(Depends on 1 open bug)
Details
(Keywords: leave-open)
Attachments
(33 files)
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details |
content/ .css is not useful anymore now that xbl is gone and 3rd party full themes do not exist anymore.
The distinction of what is styling and structure is fluent enough that it makes sense to move such css into the platform shared file instead.
Reporter | ||
Comment 1•3 years ago
|
||
https://searchfox.org/comm-central/search?q=content%2F.*.css&path=jar.mn&case=false®exp=true
See mail/themes/shared/jar.inc.mn
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 2•3 years ago
|
||
Reporter | ||
Updated•3 years ago
|
Assignee | ||
Comment 3•3 years ago
|
||
Assignee | ||
Comment 4•3 years ago
|
||
Assignee | ||
Comment 5•3 years ago
|
||
Assignee | ||
Comment 6•3 years ago
|
||
Assignee | ||
Updated•3 years ago
|
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/9b74c095efbd
Merge newmailalert.css content into skin. r=mkmelin
https://hg.mozilla.org/comm-central/rev/88701f939fe0
Move glodacomplete.css into themes. r=mkmelin
https://hg.mozilla.org/comm-central/rev/237515af017b
Move fieldMapImport.css into themes. r=mkmelin
Assignee | ||
Comment 8•3 years ago
|
||
This stylesheet is intended for xul:notification elements. However, these are unused (instead, notifications use xul:notification-message elements, which uses message-bar.css).
Assignee | ||
Comment 9•3 years ago
|
||
Assignee | ||
Comment 10•3 years ago
|
||
Assignee | ||
Comment 11•3 years ago
|
||
Also removed MOZ_SUITE checks from customizeToolbar.xhtml since it is not a shared file.
Assignee | ||
Updated•3 years ago
|
Reporter | ||
Updated•3 years ago
|
Comment 12•3 years ago
|
||
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/421848d544b8
Merge am-server.css into accountManage.css. r=mkmelin
https://hg.mozilla.org/comm-central/rev/39059485f991
Move content calendar CSS files into themes/common. r=darktrojan
https://hg.mozilla.org/comm-central/rev/942ea0363403
Drop notification.css. r=mkmelin
https://hg.mozilla.org/comm-central/rev/c1285eaf5e9c
Merge tabmail.css content into skin. r=mkmelin
https://hg.mozilla.org/comm-central/rev/70327f18e16c
Move content/multimessageview.css into themes/shared. r=mkmelin
https://hg.mozilla.org/comm-central/rev/ff5255d2cdf5
Move content/customizeToolbar.css into themes/shared. r=mkmelin
Assignee | ||
Comment 13•3 years ago
|
||
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 14•3 years ago
|
||
Assignee | ||
Comment 15•3 years ago
|
||
Assignee | ||
Comment 16•3 years ago
|
||
Assignee | ||
Comment 17•3 years ago
|
||
Comment 18•3 years ago
|
||
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/0248e301860e
Move aboutAddonsExtra.css into themes. r=mkmelin
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 19•3 years ago
|
||
Assignee | ||
Comment 20•3 years ago
|
||
Assignee | ||
Comment 21•3 years ago
|
||
Assignee | ||
Comment 22•3 years ago
|
||
Depends on D125568
Comment 23•3 years ago
|
||
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/1392ebed9caf
Merge messenger.css content into shared/skin. r=mkmelin
https://hg.mozilla.org/comm-central/rev/d9d46bb38f5c
Move content/glodaFacetView.css into themes/shared. r=mkmelin
https://hg.mozilla.org/comm-central/rev/82eb38836661
Move converterDialog.css into themes. r=mkmelin
https://hg.mozilla.org/comm-central/rev/ff39f6fe10e8
Move content/menulist.css into themes/shared. r=mkmelin
https://hg.mozilla.org/comm-central/rev/766aef629be7
Merge multimessageview_print.css into multimessageview.css. r=mkmelin
https://hg.mozilla.org/comm-central/rev/ccc2b47a5cf8
Move santizeDialog.css into themes. r=mkmelin
https://hg.mozilla.org/comm-central/rev/6a13079a529f
Merge sharedsummary.css into multimessageview.css. r=mkmelin
Assignee | ||
Comment 24•3 years ago
|
||
Assignee | ||
Comment 25•3 years ago
|
||
Assignee | ||
Comment 26•3 years ago
|
||
Do you think mail/components/cloudfile/content/selectDialog.css
should be moved to
mail/themes/shared/mail/selectDialog.css
,mail/themes/shared/mail/cloudfileSelectDialog.css
(with or without renaming the other cloudfileselectDialog*
files), ormail/themes/shared/mail/cloudfile/selectDialog.css
?
Assignee | ||
Comment 27•3 years ago
|
||
Assignee | ||
Comment 28•3 years ago
|
||
Assignee | ||
Comment 29•3 years ago
|
||
Also, if you look at something like imAccountWizard.css
, it is stored in mail/components/im/themes
, but is registered in mail/themes/linux/jar.mn
. chat.css
is similarly spread around.
Should we move all of the content of mail/components/im/themes
into either chat/themes
or mail/themes
?
Assignee | ||
Comment 30•3 years ago
|
||
Assignee | ||
Comment 31•3 years ago
|
||
Reporter | ||
Updated•3 years ago
|
Comment 32•3 years ago
|
||
Pushed by thunderbird@calypsoblue.org:
https://hg.mozilla.org/comm-central/rev/379f5a94f1f4
fixup rev 6a13079a529f. r=mkmelin
Assignee | ||
Updated•3 years ago
|
Comment 33•3 years ago
|
||
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/d0f498534a79
Move composerOverlay.css into themes. r=mkmelin
https://hg.mozilla.org/comm-central/rev/e27e576b82b7
Remove hide-private.css. r=mkmelin
https://hg.mozilla.org/comm-central/rev/aea746d01c9a
Move aboutPolicies.css into themes. r=mkmelin
https://hg.mozilla.org/comm-central/rev/f70d87a3f162
Move EditorContent.css into themes. r=mkmelin
Assignee | ||
Updated•3 years ago
|
Comment 34•3 years ago
|
||
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/dc4d76159758
Move tree-listbox.css into themes. r=darktrojan
https://hg.mozilla.org/comm-central/rev/de35d92fd3ea
Move addressbook print.css into themes. r=darktrojan DONTBUILD
Comment 35•3 years ago
|
||
I've stopped encoding the strings in this test since btoa is now available in the test context. The values are the same as before with the stylesheet URL changed.
Comment 36•3 years ago
|
||
Pushed by geoff@darktrojan.net: https://hg.mozilla.org/comm-central/rev/23d8c3c61de0 follow-up - Update a test to match. r=mkmelin
Assignee | ||
Comment 37•3 years ago
|
||
Assignee | ||
Comment 38•3 years ago
|
||
Assignee | ||
Comment 39•3 years ago
|
||
There are no CSS files in this directory.
Assignee | ||
Comment 40•3 years ago
|
||
Files still to go are:
- mail/components/cloudfile/content/selectDialog.css - See comment 26.
- mail/components/im/content/chat.css - See comment 29.
- mail/base/content/aboutDialog.css - See Bug 1728474, which is moving the file.
- mail/branding/thunderbird/content/aboutDialog.css - Being edited in the same bug, but it is not being moved. I'm not sure if or where to move this.
- mail/branding/nightly/content/aboutDialog.css - Same as above.
Let me know what the approach should be for these.
Assignee | ||
Updated•3 years ago
|
Comment 41•3 years ago
|
||
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/fbf0197084ab
Move extensionPopup.css into themes. r=mkmelin
https://hg.mozilla.org/comm-central/rev/111c9676bb8b
Merge handlers.css into applications.css. r=mkmelin
https://hg.mozilla.org/comm-central/rev/cc5655a05392
Remove openpgp/ui/*.css entry. r=mkmelin
Reporter | ||
Comment 42•3 years ago
|
||
(In reply to Henry Wilkes [:henry] from comment #26)
Do you think
mail/components/cloudfile/content/selectDialog.css
should be moved to
2.mail/themes/shared/mail/cloudfileSelectDialog.css
(with or without renaming the other cloudfileselectDialog*
files), or
I'd go for this, and not renaming the other files there.
(In reply to Henry Wilkes [:henry] from comment #29)
Also, if you look at something like
imAccountWizard.css
, it is stored inmail/components/im/themes
, but is registered inmail/themes/linux/jar.mn
.chat.css
is similarly spread around.Should we move all of the content of
mail/components/im/themes
into eitherchat/themes
ormail/themes
?
I'd move it into mail/themes.
Re the branding, not sure but there is a prior example of using things to theme/ there:
https://searchfox.org/comm-central/rev/ddc5727d39202eaa94d280a4a5ba8d9532e5a9ec/mail/branding/thunderbird/jar.mn
Comment 43•3 years ago
|
||
The two branding aboutDialog.css
are different and moving them to /theme/ would also need new branding folders which then have only one file in it. Maybe it's better to leave them there they are to let it simple to know what all belongs to the specific branding.
Assignee | ||
Comment 44•3 years ago
|
||
(In reply to Richard Marti (:Paenglab) from comment #43)
The two branding
aboutDialog.css
are different and moving them to /theme/ would also need new branding folders which then have only one file in it. Maybe it's better to leave them there they are to let it simple to know what all belongs to the specific branding.
Yes, I don't think moving them into mail/themes makes sense. I wonder if, since the branding directories already include a locales
sub-directory for translations, we could similarly include a themes
sub-directory.
And maybe move the icons into there as well. Perhaps in a separate bug, since we have icons placed under "content" chrome paths, which probably need a similar treatment to the CSS files in this bug.
Assignee | ||
Comment 45•3 years ago
|
||
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 46•3 years ago
|
||
They are only used by the joinchat.xhtml dialog, so we should prevent leaking the rules to other windows. Moreover, the dialog does not use any other content/chat.css rules.
Assignee | ||
Comment 47•3 years ago
|
||
It is only used by the verify.xhtml dialog, so we should prevent leaking the rules to other windows. Moreover, the dialog does not use any other content/chat.css rules.
Depends on D126504
Assignee | ||
Comment 48•3 years ago
|
||
Both themes/chat.css and content/chat.css were merged together into mail/themes/shared/chat.css
Depends on D126505
Comment 49•3 years ago
|
||
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/257860a21169
Move cloudfile selectDialog.css into themes. r=mkmelin
Comment 50•3 years ago
|
||
Pushed by mkmelin@iki.fi: https://hg.mozilla.org/comm-central/rev/c76b23c147d4 Move joinchat CSS rules into joinchat.css. r=mkmelin
Comment 51•3 years ago
|
||
Pushed by mkmelin@iki.fi: https://hg.mozilla.org/comm-central/rev/61e6e26cce83 Move chat.css from mail/components/im into mail/themes. r=mkmelin
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Comment 52•3 years ago
|
||
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/32957980cdbf
Create verifychat.css for verify.xhtml. r=mkmelin
Reporter | ||
Comment 53•2 years ago
|
||
Looks like we're done with this, as far as it's reasonable to take it.
I did spot some minor cleanup so will post that. But after that, I guess we should close.
Reporter | ||
Comment 54•2 years ago
|
||
Assignee | ||
Comment 55•2 years ago
|
||
I think its only the various aboutDialog.css
files that remain. Bug 1728474 is still blocking on this, but we could make the change here instead.
Comment 56•2 years ago
|
||
Pushed by mkmelin@iki.fi: https://hg.mozilla.org/comm-central/rev/272ed718520a centralize some @imports. r=john.bieling
Comment 57•2 years ago
|
||
I agree with magnus per comment 53.
The about dialog is a different beast we will tackle in its own bug.
Reporter | ||
Updated•2 years ago
|
Description
•