Closed Bug 1707223 Opened 4 years ago Closed 3 years ago

macOS Mail option is not available in Share option

Categories

(Core :: Widget: Cocoa, defect, P2)

All
macOS
defect

Tracking

()

VERIFIED FIXED
90 Branch
Tracking Status
firefox-esr78 --- wontfix
firefox88 --- wontfix
firefox89 --- wontfix
firefox90 --- verified

People

(Reporter: bmaris, Assigned: spohl)

References

(Regression)

Details

(Keywords: regression, Whiteboard: [mac:integration])

Attachments

(2 files)

Attached image Photo showing the issue (deleted) —

Affected versions

  • Firefox 89.0b3
  • Latest Nightly 90.0a1

Affected platforms

  • macOS 11.2 MacBook Pro with Touch Bar

Steps to reproduce

  1. Start Firefox
  2. Visit a website (wikipedia.org)
  3. Right click the tab
  4. Select Share option
  5. From the mac Touch Bar click the share button

Expected result

  • Same options are found inside both the Touch Bar and Firefox Share option.

Actual result

  • Mail is missing inside Firefox Share option.

Regression range

  • This is not a regression since this is also reproducible with the nightly where this was implemented in the first place.

Additional notes

  • Not sure if this is a real issue or not, I think that Mail should be the first option inside Share from Firefox since I think that could be the most important share method. Even if not I think that Mail should be available inside nonetheless.
  • Mail also is not available in macOS 10.15 or macOS 11 without Touch Bar.
  • This could be moved as an enhancement if this is somewhat restricted by apple at the moment and could be implemented in the future.

Suggested severity

  • I would say this could be S3 severity if this indeed a defect and not a future enhancement.
Has Regression Range: --- → irrelevant
Has STR: --- → yes

I don't see Mail.app anywhere (including the touchbar), possibly because it's not my default mail client.

Still, I'm also fairly sure this is not a proton bug - I expect that the page action menu's "Share" item in an earlier nightly would also not have listed Mail.app . Bogdan, can you confirm? (I tried doing it myself but because I cannot reproduce the "good" state anyway, that doesn't tell us anything)

Flags: needinfo?(bogdan.maris)

(In reply to :Gijs (he/him) from comment #1)

I don't see Mail.app anywhere (including the touchbar), possibly because it's not my default mail client.

Still, I'm also fairly sure this is not a proton bug - I expect that the page action menu's "Share" item in an earlier nightly would also not have listed Mail.app . Bogdan, can you confirm? (I tried doing it myself but because I cannot reproduce the "good" state anyway, that doesn't tell us anything)

As you suspected:

  • If I have Thunderbird as a default mail client then indeed the Mail app is not listed in the Touch Bar even when using older Nightly builds before Share was implemented in Nightly. Also Mail is not available if using share from Page items inside URL bar so you are right, this is not proton related.
  • If I have the mac default Mail client as default then Mail app is listed in Touch Bar with the same old Nightly as above.
Flags: needinfo?(bogdan.maris)
No longer blocks: proton-context-menus, 1692408
Summary: [Proton] [Mac] Mail is not available in Share option → [Mac] Mail is not available in Share option
Whiteboard: [proton-context-menus]

It appears we're explicitly filtering out mail.app, because of bug 1455304. Dale, the bug provides context around filtering the Safari mailing list, but not for Mail.app . Can you elaborate on why we don't show the Mail sharing provider?

Severity: S3 → --
Component: Menus → Widget: Cocoa
Flags: needinfo?(dharvey)
Product: Firefox → Core
Regressed by: 1455304
Summary: [Mac] Mail is not available in Share option → macOS Mail option is not available in Share option

Ah yeh there should have been a comment to explain but if I remember correctly the page actions used to already include an option to email the url and so including a duplicate button here would have been redundant / confusing. Probably worth removing the filter now though

Flags: needinfo?(dharvey)
Whiteboard: [mac:integration]
Severity: -- → S3
Priority: -- → P2
Assignee: nobody → spohl.mozilla.bugs
Status: NEW → ASSIGNED
Pushed by spohl@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c5793ed71d30 Add mail option to the context menu's share menu on macOS and bring it in line with the share menu that is accessible via the TouchBar where the mail option is already shown. r=mac-reviewers,harry
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch

Verified that in latest Nightly 90.0a1 from today the Mail option is visible (and properly working) in Share from Tab context menu in macOS 11.3. All the options from the TouchBar are correctly displayed in the context menu.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: