Closed Bug 1707424 Opened 4 years ago Closed 4 years ago

bookmark icon in the Address Bar shortcuts is not consistent with theme colouring

Categories

(Firefox :: Foxfooding, defect, P3)

Product:
Firefox
Component:
Foxfooding
Version:
Firefox 89
Platform:
Desktop
All
Type:
defect
Points:
2

Tracking

()

Status:
VERIFIED FIXED
Milestone:
90 Branch
Iteration:
90.2 - May 3 - May 16
Tracking Flags:
Tracking Status
firefox89 --- wontfix
firefox90 --- verified

People

(Reporter: pdehaan, Assigned: daisuke)

References

(Blocks 1 open bug)

Details

(Whiteboard: [foxfooding][community] [proton-foxfooding] [proton-address-bar])

Attachments

(3 files)

Custom "Dark Space" theme
(deleted), image/png
Details
Firefox default "Dark" theme
(deleted), image/png
Details
Bug 1707424: Use color of --toolbarbutton-icon-fill-attention for all of bookmark star image in urlbar related.r?harry!
(deleted), text/x-phabricator-request
Details

This comment is copy/pasted from a community issue filed during the Foxfooding program.

Firefox Version: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:90.0) Gecko/20100101 Firefox/90.0
Window Size (inner width and height): 1920x955

Steps to Reproduce

  1. install "Dark space - The best dynamic theme" from the firefox addons store
  2. go to settings -> search -> search shortcuts:
  3. make sure the "bookmarks" option is checked in the list of search engines
  4. go to a page that you have bookmarked so that the bookmarks star in the address bar is filled in colour rather tha an outline
  5. click on the address bar to prompt the megabar to appear
  6. notice that the bookmarks star is purple in the address bar but blue in the suggestions

Expected Behavior

the bookmarks stars should both be the colour set by the theme for consistency

Actual Behavior

the bookmarks star is purple in the address bar but blue in the search provider suggestions at the bottom

Attached image Custom "Dark Space" theme (deleted) —
Attached image Firefox default "Dark" theme (deleted) —
Priority: -- → P3
Blocks: proton-address-bar
Whiteboard: [foxfooding][community] [proton-foxfooding] → [foxfooding][community] [proton-foxfooding] [proton-address-bar]
Summary: bookmark icon in megabar not consitent with theme colouring → bookmark icon in the Address Bar shortcuts is not consistent with theme colouring

Also the bookmarked badge on the favicon of the fifth result.

Assignee: nobody → daisuke
Status: NEW → ASSIGNED
Iteration: --- → 90.2 - May 3 - May 16
Points: --- → 2
Pushed by dakatsuka.birchill@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/06ac765779a9 Use color of --toolbarbutton-icon-fill-attention for all of bookmark star image in urlbar related.r=harry,desktop-theme-reviewers,dao

https://hg.mozilla.org/mozilla-central/rev/06ac765779a9

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
Flags: qe-verify+

Hello! I have reproduced the issue on an affected Nightly build 90.0a1 (2021-04-24).
The fix was verified on 90.0b2 (2021-06-01). Tests were performed on Ubuntu 20.04, Windows 10x64 and macOS 10.15. Thank you!

Status: RESOLVED → VERIFIED
status-firefox90: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: