Convert chatZilla from an extension
Categories
(SeaMonkey :: Chat, task)
Tracking
(seamonkey2.53 unaffected, seamonkey2.57esr fixed)
Tracking | Status | |
---|---|---|
seamonkey2.53 | --- | unaffected |
seamonkey2.57esr | --- | fixed |
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
References
Details
Attachments
(3 files, 9 obsolete files)
(deleted),
patch
|
frg
:
review+
frg
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
frg
:
review+
|
Details | Diff | Splinter Review |
(deleted),
text/plain
|
flod
:
review+
|
Details |
Change chatZilla from being an extension to being part of SeaMonkey.
This moves everything from suite/extensions/irc to suite/chatzilla
On l10n need to copy files in each locale from extensions/irc to suite/chatzilla
Things left to potentially do:
- Change MOZ_IRC to MOZ_CHATZILLA
- Reorganise the structure in suite/chatzilla to more closely match other parts of SeaMonkey
The above can always be done as follow-up bugs
Once chatZilla is no longer an extension we do not need to reference it in l10n.mk
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.8
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: 2 strings removed
Maybe some changes needed in suite/installer/removed-files.in but that could be a follow-up patch.
Fix typo whilst rebasing in suite/locale/Makefile.in
Updated•3 years ago
|
Make an incremental patch on top of Bug 1604663
Patch for landing on comm-central, it will need a script to copy files in l10n-central from */extensions/irc to */suite/chatzilla for all locales that have extensions/irc
As far as I can tell the l10n.toml in suite/chatzilla/locales will only expose the strings in Pontoon to those locales that currently localise chatZilla
Fixed basepath issue in l10n.toml
Assignee | ||
Comment 10•3 years ago
|
||
Fixed paths in l10n.toml and removed unneeded extension hacks in suite/locales/*
Assignee | ||
Comment 11•3 years ago
|
||
Include DEFINES['CHATZILLA_VERSION'] which will get used when bug 1712509 lands on cc.
Comment 12•3 years ago
|
||
Comment on attachment 9224555 [details] [diff] [review]
1707459-irc-embed-v1_6-cc.patch
LGTM
Updated•3 years ago
|
Assignee | ||
Comment 13•3 years ago
|
||
Tested that this works locally and that when running merge the l10n.* seem to successfully ignore those locales that don't localize cZ. I'm hoping that will also apply on Pontoon.
What is the best way to notify dev-l10n now, via discourse?
Comment 14•3 years ago
|
||
Comment on attachment 9226687 [details]
Bug-1707459-copy-irc-locales.bash
I will have to rewrite this to adapt it to my scripts, but it seems reasonable.
Comment 15•3 years ago
|
||
(In reply to Ian Neal from comment #13)
Created attachment 9226687 [details]
Bug-1707459-copy-irc-locales.bashTested that this works locally and that when running merge the l10n.* seem to successfully ignore those locales that don't localize cZ. I'm hoping that will also apply on Pontoon.
Not sure what you mean? All locales will find these string in SM, those who translated the old add-on will find them already translated.
What is the best way to notify dev-l10n now, via discourse?
Yes, and the Matrix channel.
Assignee | ||
Comment 16•3 years ago
|
||
(In reply to Francesco Lodolo [:flod] from comment #15)
(In reply to Ian Neal from comment #13)
Created attachment 9226687 [details]
Bug-1707459-copy-irc-locales.bashTested that this works locally and that when running merge the l10n.* seem to successfully ignore those locales that don't localize cZ. I'm hoping that will also apply on Pontoon.
Not sure what you mean? All locales will find these string in SM, those who translated the old add-on will find them already translated.
I thought Pontoon made use of the l10n.toml files to determine what entities to present to localisers
Comment 17•3 years ago
|
||
(In reply to Ian Neal from comment #16)
I thought Pontoon made use of the l10n.toml files to determine what entities to present to localisers
No, that's not used for hg projects, it's only used for build/automation
Assignee | ||
Comment 18•3 years ago
|
||
(In reply to Francesco Lodolo [:flod] from comment #17)
(In reply to Ian Neal from comment #16)
I thought Pontoon made use of the l10n.toml files to determine what entities to present to localisers
No, that's not used for hg projects, it's only used for build/automation
Okay, that's fine. Ready for the l10n copy to happen when you are.
Comment 19•3 years ago
|
||
(In reply to Ian Neal from comment #18)
(In reply to Francesco Lodolo [:flod] from comment #17)
(In reply to Ian Neal from comment #16)
I thought Pontoon made use of the l10n.toml files to determine what entities to present to localisers
No, that's not used for hg projects, it's only used for build/automation
Okay, that's fine. Ready for the l10n copy to happen when you are.
This needs to land in comm-central and go through the cross-channel generation (which is automated), for me to be able to run the copy.
Comment 20•3 years ago
|
||
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/d176681b6bce
Convert chatZilla from an extension. r=frg
Comment 21•3 years ago
|
||
Comment on attachment 9224549 [details] [diff] [review]
1707459-irc-embed-v1_5-257.patch
LGTM nits addressed in v1.6
Updated•3 years ago
|
Comment 22•3 years ago
|
||
Script is running, should be done in about 30 minutes, then I'll re-enable Sync in Pontoon.
Test run on Italian
https://hg.mozilla.org/l10n-central/it/rev/be38bd5a89d6ba38d771fd7c25cbf049ba49360f
Updated•3 years ago
|
Description
•