Checkboxes and icons in modal dialogs are no longer aligned
Categories
(Toolkit Graveyard :: Notifications and Alerts, defect, P2)
Tracking
(firefox88 disabled, firefox89 verified, firefox90 verified)
People
(Reporter: rdoghi, Assigned: Gijs)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [proton-modals] [priority:2b] [proton-uplift])
Attachments
(3 files)
(deleted),
image/png
|
Details | |
(deleted),
image/png
|
Details | |
(deleted),
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details |
[Affected platforms]:
Platforms: All
[Steps to reproduce]
- Have Zoom installed and Launch the Firefox Browser.
- Reach https://mozilla.zoom.us/j/73233092083 and click the Launch meeting button in order for the Protocol Handler modal to be displayed.
[Expected result]
The Checkbox label text should be a pixel higher.
[Actual result]
The Checkbox label text is aligned with the bottom of the Checkbox square.
Reporter | ||
Comment 1•3 years ago
|
||
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 2•3 years ago
|
||
Bah, didn't mean to clear needinfo.
Updated•3 years ago
|
Updated•3 years ago
|
Assignee | ||
Comment 3•3 years ago
|
||
On current nightly, icons and checkboxes in other places have also lost some alignment, now that the font is smaller again. I'll try and fix that and the bug this originally highlighted, in the protocol handling dialogs.
Updated•3 years ago
|
Assignee | ||
Comment 4•3 years ago
|
||
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/0bf658f4c20e align checkbox and modal icons correctly given changes in font-size, r=Mardak
Comment 7•3 years ago
|
||
bugherder |
Assignee | ||
Comment 8•3 years ago
|
||
Comment on attachment 9219303 [details]
Bug 1707538 - align checkbox and modal icons correctly given changes in font-size, r?Mardak
Beta/Release Uplift Approval Request
- User impact if declined: Required for MR1 / Proton
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: See comment 0 and bug 1707828 - generally, please check icon and checkbox alignment in content (alert/prompt/confirm) modals, the protocol handling dialog, and the default browser dialog
- List of other uplifts needed: None that haven't already been uplifted
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): We're
translate
ing some stuff in CSS to make it line up better. Shouldn't affect much else - String changes made/needed: Nope
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Comment 9•3 years ago
|
||
Comment on attachment 9219303 [details]
Bug 1707538 - align checkbox and modal icons correctly given changes in font-size, r?Mardak
Approved for 89 beta 7, thanks.
Comment 10•3 years ago
|
||
bugherder uplift |
Updated•3 years ago
|
Reporter | ||
Comment 11•3 years ago
|
||
This issue is Verified as fixed in our latest beta 89.0b8 and our latest Nightly 90.0a1 (2021-05-04) on Windows 10 , Mac 11 and Ubuntu 20.04.
Updated•1 year ago
|
Description
•