Open Bug 1707724 Opened 3 years ago Updated 3 years ago

test failures in browser/base/content/test/general/browser_restore_isAppTab.js on apple silicon

Categories

(Toolkit :: Crash Reporting, task)

task

Tracking

()

Tracking Status
firefox90 --- affected

People

(Reporter: jmaher, Unassigned)

References

Details

Last week we turned on tests for Apple Silicon (OSX 11.2.3 on new Apple based hardware). We are using the simplified new test config process:
https://firefox-source-docs.mozilla.org/testing/ci-configs/index.html

As the tests are live, we are now filing bugs to help close the loop and hope to fix any issues over the next 7 weeks. As the process outlines, there are tier-3 jobs running on m-c which run these skipped tests and will expect a failure/timeout/crash- if it doesn't fail, then the job will turn orange.

Here is a link to a try push that shows the test failing:
browser/base/content/test/general/browser_restore_isAppTab.js

:mossop, please take a look and see if there is something we can do to fix this or accept this as a known issue on this new platform.

Flags: needinfo?(dtownsend)

Also related to this component is another failure a different test:
browser/base/content/test/performance/io/../browser_startup_mainthreadio.js

(In reply to Joel Maher ( :jmaher ) (UTC -0800) from comment #2)

Also related to this component is another failure a different test:
browser/base/content/test/performance/io/../browser_startup_mainthreadio.js

Hi Joel. Thanks for the failure log. The root cause is bug 1707855. I would like to tweak the test to ignore these errors on Mac M1 until the bug is fixed. Is there a scriptable way to detect that we are running on a Mac M1?

Flags: needinfo?(jmaher)

at the python level we have the manifest where we get os and version and arch - basically I made a keyword so we can skip-if = apple_silicon. I suspect you want to do this in javascript.

there is prior art to either a pref or getting the os version (in this case we run 11.2.3, so 11 +):
https://searchfox.org/mozilla-central/search?q=sandbox.apple_silicon&path=

Flags: needinfo?(jmaher)

Looks like you're taking this Florian?

Assignee: nobody → florian
Flags: needinfo?(dtownsend)

(In reply to Dave Townsend [:mossop] (Out May 3-14) from comment #5)

Looks like you're taking this Florian?

I'm looking into the browser_startup_mainthreadio.js failure (and I can do it in bug 1707855 if we need a separate bug), but I think you still need an owner for the browser_restore_isAppTab.js failure.

Assignee: florian → nobody

Ok, Mike can you take this or pass it on?

Flags: needinfo?(mconley)

The browser_restore_isAppTab.js failure looks similar to the issue in bug 1707729 - the test intentionally crashes the frame, and I think our crash reporter infrastructure is really not happy about it and taking down the main process.

I suspect someone from the macdev team is going to have to figure out why the crash reporter stuff isn't working.

Component: General → Crash Reporting
Flags: needinfo?(mconley)
Product: Firefox → Toolkit

(In reply to Joel Maher ( :jmaher ) (UTC -0800) from comment #2)

Also related to this component is another failure a different test:
browser/base/content/test/performance/io/../browser_startup_mainthreadio.js

A newer log for this failure can be found on https://treeherder.mozilla.org/jobs?repo=mozilla-central&tier=1%2C2%2C3&searchStr=macosx1100&revision=eac40293649628d32911c909219d514bebb8ce63&test_paths=browser%2Fbase%2Fcontent%2Ftest%2Fperformance%2Fio&selectedTaskRun=R4y3QBtnRay_cAxo-rZATg.0

(In reply to Joel Maher ( :jmaher ) (UTC -0800) from comment #0)

browser/base/content/test/general/browser_restore_isAppTab.js

this test appears to have gotten fixed at some point. It's passing on central now.

You need to log in before you can comment on or make changes to this bug.