Search nudge "Ok, got it" button should use proton primary button styles
Categories
(Firefox :: Theme, task, P1)
Tracking
()
People
(Reporter: ntim, Assigned: bugzilla)
References
(Blocks 1 open bug)
Details
(Whiteboard: [proton-address-bar], [proton-icons] [proton-uplift])
Attachments
(3 files)
|
(deleted),
image/png
|
Details | |
|
(deleted),
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details |
|
(deleted),
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details |
image.png
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 1•4 years ago
|
||
|
|
Assignee | |
Comment 2•4 years ago
|
||
Depends on D113530
|
|
Assignee | |
Comment 3•4 years ago
|
||
Setting P1 only because this patch updates an icon. Afaik, all icon patches are P1.
|
||
Updated•4 years ago
|
|
|
Assignee | |
Comment 4•4 years ago
|
||
[Tracking Requested - why for this release]:
Part 1 is CSS-only and updates a UI element that's seen quite often to Proton styling.
Part 2 is an icon patch, which is high priority for Proton.
I'll request uplift tomorrow, after I verify in Nightly.
|
||
Comment 7•4 years ago
|
||
Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=ddfb12358dcd4d00ac97cc94c7c053a2c4483ba7
Failure log: https://treeherder.mozilla.org/logviewer?job_id=338182372&repo=autoland
Backout link: https://hg.mozilla.org/integration/autoland/rev/79a68ceee155f6bb45dc538ad8d6a903beedf7be
|
||
Updated•4 years ago
|
|
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 9•4 years ago
|
||
Comment on attachment 9218679 [details]
Bug 1707756 - Part 1 - Update Urlbar tips to Proton styles. r?mak,dao
Beta/Release Uplift Approval Request
- User impact if declined: Fairly high-profile button will be using pre-Proton styling. Part 2 uplifts a Proton icon.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: Set
browser.urlbar.searchTips.test.ignoreShowLimitsto make testing easier.
- Go to about:home and observe that the button in the Search Tip below the Urlbar has Proton styling.
- Set your default search engine to Google and go to google.com. Observe that the button in the Search Tip below the Urlbar has Proton styling.
- Type "update firefox" in the address bar. Observe that the button in the second result has Proton styling.
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): CSS-only, affecting only these particular buttons in some Urlbar results.
- String changes made/needed:
|
|
Assignee | |
Updated•4 years ago
|
|
||
Comment 10•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/703bb6b1d811
https://hg.mozilla.org/mozilla-central/rev/6c256f8029d9
|
|
||
Updated•4 years ago
|
|
|
||
Comment 11•4 years ago
|
||
Comment on attachment 9218679 [details]
Bug 1707756 - Part 1 - Update Urlbar tips to Proton styles. r?mak,dao
Low risk css +svg patch, approved for 89 beta 8, thanks.
|
|
||
Updated•4 years ago
|
|
|
||
Comment 12•4 years ago
|
||
| bugherder uplift | ||
|
||
Updated•4 years ago
|
|
||
Comment 13•4 years ago
|
||
I reproduced this issue using Fx 89.0a1(2021-04-19) on macOS 10.13.6.
I can confirm this issue is fixed; I verified using Fx 90.0a1(2021-05-05) and Fx 89.0b8 on macOS 10.13.6, Ubuntu 20.04 LTS and Windows 10 x64.
Description
•