Closed Bug 1707760 Opened 4 years ago Closed 2 years ago

Uses of `#ifdef CharT_is_char` after `CharT` was removed from the string code

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Type:
defect

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: jld, Unassigned)

References

(Regression)

Details

(Keywords: regression)

Bug 1393230 changed the XPCOM string classes to use templates instead of macros, but two uses of the CharT_is_char macro remain even though it's no longer defined.

On Matrix, Nika suggests using something like if constexpr (std::is_same_v<char_type, char>) to replace the broken ifdef.

Has Regression Range: --- → yes

These have been removed.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.