Closed Bug 1707895 Opened 4 years ago Closed 4 years ago

make toolbar color scheme mediaquery able to detect system theme

Categories

(Firefox :: Theme, task)

Product:
Firefox
Component:
Theme
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox89 --- fixed
firefox90 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-foundations] [proton-uplift])

Attachments

(1 file)

Bug 1707895 - Make the -moz-toolbar-prefers-color-scheme a tri-state. r=mstriemer
(deleted), text/x-phabricator-request
pascalc
: approval-mozilla-beta+
Details
No description provided.

This will allow detecting the system theme, which allows fixing some of
the blocked bugs.

Note that when using the system theme we will still match light or dark
appropriately, so this shouldn't change behavior just yet.

Assignee: nobody → emilio
Status: NEW → ASSIGNED
No longer blocks: 1707872
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/96caf8d820c3 Make the -moz-toolbar-prefers-color-scheme a tri-state. r=mstriemer
Whiteboard: [proton-foundations]

https://hg.mozilla.org/mozilla-central/rev/96caf8d820c3

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch

Emilio, do you want to request uplift to beta?

Flags: needinfo?(emilio)

Comment on attachment 9218645 [details]
Bug 1707895 - Make the -moz-toolbar-prefers-color-scheme a tri-state. r=mstriemer

Beta/Release Uplift Approval Request

  • User impact if declined: None, yet, but future patches might need it.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: none
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Doesn't change behavior on its own.
  • String changes made/needed: none
Flags: needinfo?(emilio)
Attachment #9218645 - Flags: approval-mozilla-beta?
status-firefox89: --- → affected
Whiteboard: [proton-foundations] → [proton-foundations] [proton-uplift]

Comment on attachment 9218645 [details]
Bug 1707895 - Make the -moz-toolbar-prefers-color-scheme a tri-state. r=mstriemer

Low risk as it is not currently in use and baked on nightly for a week, uplift approved for 89 beta 8, thanks.

Attachment #9218645 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: