Closed
Bug 1707946
Opened 4 years ago
Closed 4 years ago
Move usage of Promise.jsm to regular DOM Promises in devtools/client/inspector/markup/markup.js
Categories
(DevTools :: Inspector, task)
DevTools
Inspector
Tracking
(firefox90 fixed)
RESOLVED
FIXED
90 Branch
Tracking | Status | |
---|---|---|
firefox90 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: nchevobbe)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
No description provided.
Assignee | ||
Comment 1•4 years ago
|
||
an initial patch revealed some test failures, as pending Promise.jsm promises don't cause test failure (?) + another one that seems to be caused by slight change in timing. I'll update those tests
Assignee | ||
Comment 2•4 years ago
|
||
This was making 2 tests failing:
- browser_toolbox_selectionchanged_event.js had a pending promise that would make
the test fail (whereas pending Promise.jsm don't). It was setting anundefined
selected node with a reason, which is something we don't do in the codebase (we set
it to null, with no reason). So here we change it by setting the selection to a
null node, which is consistent with real world scenario. - browser_markup_shadowdom_clickreveal.js was failing because the container of
a node was slotted while it shouldn't be. It looks like the switch to DOM Promises
changed the timing slightly, so we're now waiting in the test to make sure we
have another container than the slotted one we were handling before.
Updated•4 years ago
|
Attachment #9218703 -
Attachment description: Bug 1707946 - [devtools] Replace Promise.jsm with regular Promises in devtools/client/inspector/markup/markup.js. r=jdescottes. → Bug 1707946 - [devtools] Replace Promise.jsm with regular Promises in devtools/client/inspector/markup/markup.js. r=ochameau.
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/36de91ab59b9
[devtools] Replace Promise.jsm with regular Promises in devtools/client/inspector/markup/markup.js. r=ochameau.
Comment 4•4 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox90:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•