Closed Bug 1708042 Opened 4 years ago Closed 4 years ago

Consider to have very high priority ("control") for DidComposite tasks

Categories

(Core :: Performance, defect, P3)

Product:
Core
Component:
Performance
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
90 Branch
Project Flags:
Performance Impact high
Tracking Flags:
Tracking Status
firefox90 --- fixed

People

(Reporter: smaug, Assigned: smaug)

References

(Blocks 1 open bug)

Details

(Keywords: perf-alert, perf:responsiveness)

Attachments

(4 files, 1 obsolete file)

Bug 1708042, add control priority to the main thread, r=bas
(deleted), text/x-phabricator-request
Details
Bug 1708042, add support for 'control' priority in ipdl, r=jld
(deleted), text/x-phabricator-request
Details
Bug 1708042, use control priority for DidComposite but dispatch MozAfterPaint using mediumhigh, since scripts shouldn't run in control queue, r=bas
(deleted), text/x-phabricator-request
Details
Bug 1708042, background-color-animation-in-body.html fails more often on debug-Android, r=emilio
(deleted), text/x-phabricator-request
Details

Currently a pending DidComposite may cause refreshdriver to not paint soon enough.

Making this qf:p1:responsiveness since we know at least one place where this really hurts and it's likely to help us across the board.

Severity: -- → S3
Priority: -- → P3
Whiteboard: [qf:p1:responsiveness]
Attachment #9218810 - Attachment is obsolete: true

Just to remind myself,
https://palmeral.github.io/interactive-mandelbrot/ is the case where this helps a lot on linux with MOZ_ENABLE_WAYLAND=1

The difference is like
http://mozilla.pettay.fi/moztests/DidComposite_using_control_group.webm

Pushed by opettay@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ddc6d95f0601 add control priority to the main thread, r=bas https://hg.mozilla.org/integration/autoland/rev/a0fccd7121b5 add support for 'control' priority in ipdl, r=jld,ipc-reviewers https://hg.mozilla.org/integration/autoland/rev/f8febc2db198 use control priority for DidComposite but dispatch MozAfterPaint using mediumhigh, since scripts shouldn't run in control queue, r=bas

Backed out for causing wr failures on background-color-animation-in-body.html.

Push with failures

Failure log

Backout link

Status: RESOLVED → REOPENED
status-firefox90: fixed → ---
Flags: needinfo?(bugs)
Resolution: FIXED → ---
Target Milestone: 90 Branch → ---

There is existing bug https://bugzilla.mozilla.org/show_bug.cgi?id=1702588 hinting that the failure has been there before the
changes to DidComposite.

Depends on D115406

Pushed by opettay@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1063abf99c57 add control priority to the main thread, r=bas https://hg.mozilla.org/integration/autoland/rev/50871b972cf8 add support for 'control' priority in ipdl, r=jld,ipc-reviewers https://hg.mozilla.org/integration/autoland/rev/5d6d1f75e513 use control priority for DidComposite but dispatch MozAfterPaint using mediumhigh, since scripts shouldn't run in control queue, r=bas https://hg.mozilla.org/integration/autoland/rev/ff9588d5696f background-color-animation-in-body.html fails more often on debug-Android, r=emilio
Flags: needinfo?(bugs)
Regressions: 1712684

== Change summary for alert #30162 (as of Fri, 21 May 2021 21:19:45 GMT) ==

Improvements:

Ratio Suite Test Platform Options Absolute values (old vs new)
6% motionmark_webgl (docs) 3DGraphics-WebGL macosx1015-64-shippable e10s stylo webgl-ipc 14.78 -> 15.67
5% motionmark_webgl (docs) 3DGraphics-WebGL windows10-64-shippable-qr e10s stylo webrender-sw 11.51 -> 12.07
5% motionmark_webgl (docs) 3DGraphics-WebGL windows10-64-shippable e10s stylo 11.44 -> 11.99

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=30162

Blocks: 1633256
Performance Impact: --- → P1
Keywords: perf:responsiveness
Whiteboard: [qf:p1:responsiveness]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: